[Freeciv-Dev] [patch #7653] while(

Follow-up Comment #2, patch #7653 (project freeciv): I prefer comments about what should be considered correct style in form of tickets with patch to doc/CodingStyle and good arguments how the policy change would improve things. ___ Reply

[Freeciv-Dev] [patch #7652] Msys2: Ruledit dll list update for msys2 env 160821

Update of patch #7652 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #7393] Valid usa.svg flag

Follow-up Comment #5, patch #7393 (project freeciv): Suggested "Planned release": 2.7 or later, updating the credits in flags.spec will need some work for the "now PD" refreshs from commons, and some special cases like the Dryads in patch #7476.

[Freeciv-Dev] [patch #7393] Valid usa.svg flag

Follow-up Comment #4, patch #7393 (project freeciv): No license change (that doesn't imply that it ever was okay): patch #7483, patch #7480, patch #7476, patch #7437, patch #7436, patch #7429, patch #7426, patch #7425, patch #7413, patch #7412, patch #7411, patch #7410. Now PD (refresh from

[Freeciv-Dev] [patch #7656] Qt client - Use QStackedLayout as main layout

URL: Summary: Qt client - Use QStackedLayout as main layout Project: Freeciv Submitted by: mir3x Submitted on: Wed 24 Aug 2016 08:21:55 PM CEST Category: client-qt Priority: 5

[Freeciv-Dev] [patch #7629] Three valid SVGs for data/graphics

Follow-up Comment #2, patch #7629 (project freeciv): Actually that was only a text editor fix, but the question in patch #7393 was about the license: Whatever it was, no change. ___ Reply to this item at:

[Freeciv-Dev] [patch #7629] Three valid SVGs for data/graphics

Follow-up Comment #1, patch #7629 (project freeciv): All rsvg-convert, no license changes, reported as (default) GPL on the corresponding Wiki pages, for more info check SVN and update the Wiki pages where GPL should be something else (most likely PD for openclipart stuff.) Info requested on

[Freeciv-Dev] [patch #7636] 11 valid SVG wonders

Follow-up Comment #3, patch #7636 (project freeciv): All rsvg-convert, no license changes, reported as (default) GPL on the corresponding Wiki pages, for more info check SVN and update the Wiki pages where GPL should be something else (most likely PD for openclipart stuff.) Info requested on

[Freeciv-Dev] [patch #7637] 16 valid SVG techs

Follow-up Comment #4, patch #7637 (project freeciv): All rsvg-convert, no license changes, reported as (default) GPL on the corresponding Wiki pages, for more info check SVN and update the Wiki pages where GPL should be something else (most likely PD for openclipart stuff.) I attach svg2true.rex

[Freeciv-Dev] [patch #7613] Flags clean-up

Follow-up Comment #5, patch #7613 (project freeciv): *Fourth* part of what I had in mind, rename svg.svg (sic!) to vincentian.svg later, after this patch #7613 made it into SVN, and after two affected SVGs in http://freeciv.wikia.com/wiki/Category:Edit_requests are renamed by an active Wiki

[Freeciv-Dev] [bug #24982] Pending SVG flag patches

Follow-up Comment #5, bug #24982 (project freeciv): Sorry, I missed the new dependency list, yes, it's also suited as tracking bug, and of course it should be not closed as fixed while it tracks those patches. For some pending nation patches *NOT* tracked here I added comments roughly

[Freeciv-Dev] [patch #7235] data/graphics/logo+splash/Freeciv_Logo.svg

Follow-up Comment #2, patch #7235 (project freeciv): Also see http://forum.freeciv.org/f/viewtopic.php?f=14=926=13591#p13591 ___ Reply to this item at: ___

[Freeciv-Dev] [patch #7393] Valid usa.svg flag

Follow-up Comment #3, patch #7393 (project freeciv): flag page linked in the corresponding flag. should be flag page linked in the corresponding patch. Example for this patch #7393 at the bottom, the one-liner means "nothing special, just fixed, now valid, copy to SVN". I was a bit more

[Freeciv-Dev] [patch #7393] Valid usa.svg flag

Follow-up Comment #2, patch #7393 (project freeciv): *invalid* is determined by: "one or more errors reported by the W3C validator" https://validator.w3.org/ So far there was one special case "(only) visually invalid" for the Dryads, that was discussed on the forum (link in patch #7476). For

[Freeciv-Dev] [patch #5468] German Empire (1871-1914) nation

Follow-up Comment #5, patch #5468 (project freeciv): Based on a comment in patch #7613 don't hold your breath for 2.5.6, but this business should be really part of 2.6.0 (or any 2.6.0 beta or RC = release candidate before 2.6.0, excluding the already existing unoffocial 2.6.0-beta0 test

[Freeciv-Dev] [bug #24982] Pending SVG flag patches

Follow-up Comment #4, bug #24982 (project freeciv): Just in case, the (fixed) flags addressed in bug #24982 are visible at the bottom of http://freeciv.wikia.com/wiki/Flags_Catalogue (everything after the zulu - GAP - hongkong - danzig row belongs to this bug, hongkong + danzig belong to patch

[Freeciv-Dev] [patch #7633] Qt client - updated help page

Update of patch #7633 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

Update of patch #7491 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #24982] Pending SVG flag patches

Follow-up Comment #3, bug #24982 (project freeciv): The purpose is to collect five years old pending (open) patches about flags and nations, check the SVGs (done), upload the SVGs to Wikia (done), and fix invalid SVGs (done). Next steps as they come, all these SVGs do not yet have the four

[Freeciv-Dev] [patch #7613] Flags clean-up

Follow-up Comment #4, patch #7613 (project freeciv): The purpose of this patch is to finish the german empire efforts in patch #5468 started 2014 and now ready from my POV. It also adds an (unused) Hongkong flag requested in the Wiki in 2007, and adds an (unused) Danzig flag by J.M. Maalderink in

[Freeciv-Dev] [patch #7653] while(

Follow-up Comment #1, patch #7653 (project freeciv): Yes, while(1) is horrible. I'd prefer while 1 or, because you obviously love TRUE and FALSE, while TRUE. The new while (TRUE) is a matter of taste, admittedly not my taste, but okay. However, one case of while (FALSE) cries for an

[Freeciv-Dev] [bug #25015] Tatar Qazan(189, 34) {d0 u0 g0} has NO valid state!

URL: Summary: Tatar Qazan(189,34) {d0 u0 g0} has NO valid state! Project: Freeciv Submitted by: chrisk Submitted on: Mi 24 Aug 2016 11:23:18 CEST Category: None Severity: 3 -

[Freeciv-Dev] [patch #7655] Nationality, Extra, and Style requirement types value editing

URL: Summary: Nationality, Extra, and Style requirement types value editing Project: Freeciv Submitted by: cazfi Submitted on: Wed 24 Aug 2016 11:16:53 AM EEST Category: freeciv-ruledit

[Freeciv-Dev] [patch #7646] Unitclass, output type, goods requirement types value editing

Update of patch #7646 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #7654] Msys2-next after 160821

URL: Summary: Msys2-next after 160821 Project: Freeciv Submitted by: cazfi Submitted on: Wed 24 Aug 2016 09:49:30 AM EEST Category: general Priority: 5 - Normal

[Freeciv-Dev] [bug #25007] Extern "C" block terminated in the middle of fc_types.h

Update of bug #25007 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed