Re: [Freeciv-Dev] (PR#39685) [Bug] player_find_????_by_id() broken

2007-09-15 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39685 > On 08/09/2007, Marko Lindqvist wrote: > > Comment says that pplayer can be NULL to check if city/unit is in > game at all. But that will return TRUE only for units which have no > owner (owner also NULL). Patches. Only callers using NULL

[Freeciv-Dev] (PR#39685) [Bug] player_find_????_by_id() broken

2007-09-08 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39685 > Comment says that pplayer can be NULL to check if city/unit is in game at all. But that will return TRUE only for units which have no owner (owner also NULL). I guess NULL handling has been added to player_find__by_id() to replace remo