Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-18 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > William Allen Simpson wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39868 > > > Found it! After straightening the code, and getting some sleep, the answer > leaped right out. When taking a unit out of sentry by client instead of

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-18 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > Found it! After straightening the code, and getting some sleep, the answer leaped right out. When taking a unit out of sentry by client instead of server, it is already in the focus, and should not be added to the queue. Committed S2_1 rev

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-17 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > Jason Dorje Short wrote: > This was introduced in 39817. > I've been over and over my code in PR#39817 today. I don't see the problem. Apparently, it needs more eyeballs. I'll leave this to Jason. ___

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-17 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > I have verified that a unit sentried and then moved does not lose focus. The report accurately describes the problem. I have not yet found the problem. Unfortunately, there seem to be several methods used for every test, and for every actio

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-16 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > This was introduced in 39817. I'm not sure why but at a guess the unsentried unit is being put onto the urgent-focus queue then refocused later when it runs out of moves and unit focus is supposed to advance. -jason ___

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-16 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > On 11/16/07, Christian Prochaska <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39868 > > > > [wsimpson - Fr 16. Nov 2007, 09:32:20]: > > > > Daniel Markstedt wrote: > > > Not necessarily. It may also be somethi

Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-16 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > Christian Prochaska wrote: > And from http://en.wikipedia.org/wiki/Software_regression: > > "A software regression is a software bug which makes a feature stop > working after a certain event (system upgrade, system patching, daylight > sav

[Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-16 Thread Christian Prochaska
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > > [wsimpson - Fr 16. Nov 2007, 09:32:20]: > > Daniel Markstedt wrote: > > Not necessarily. It may also be something that has ceased to work as > > intended, regardless of having been previously reported as a bug or > > not. > > > Sorry, per

[Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected

2007-11-15 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39868 > > [dmarks - Thu Nov 15 12:26:01 2007]: > > S2_1 r13945: > > Put unit in sentry, then wake it up and move it somewhere using up all > its moves. > > Expected behavior: > Unit gets deselected and the next unit is selected. > > Actual behavi