Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-13 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > Jason Dorje Short wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > > William Allen Simpson wrote: > >> Madeline, where is your code? The AUTH code here is cryptologically >> unsound. Did the AUTH code come from someplace

Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-13 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > William Allen Simpson wrote: > Madeline, where is your code? The AUTH code here is cryptologically > unsound. Did the AUTH code come from someplace special? Is there any > reason to be backward compatible with anything? The auth code was

Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-12 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > Madeline Book wrote: > I am slightly confused here in that you change subject to the database > auth code (i.e. server/auth.[ch]) - I assume you meant the hack > mechanism. > No, I was looking at the auth code. > ... I have on more than o

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-12 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > [wsimpson - Wed Dec 12 14:25:21 2007]: > > Jason Dorje Short wrote: > > But the point is that having HACK access allows you to write directly to > > the filesystem, through the /save command among others. HACK access > > should only b

Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-12 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > Jason Dorje Short wrote: > But the point is that having HACK access allows you to write directly to > the filesystem, through the /save command among others. HACK access > should only be given when you do not mind the user having write acc

Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-11 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > William Allen Simpson wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > > Jason Dorje Short wrote: >> Also the whole point of the HACK check is that the client SHOULD have >> permission to delete the file created. If the cl

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-11 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > [jdorje - Tue Dec 11 06:55:12 2007]: > > > [book - Mon Dec 10 16:22:28 2007]: > > > We ameliorated this situation somewhat for warserver by > > introducing/modifying the cmdlevels to: > > [...] > > What's the difference between ADMIN an

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-11 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > [jdorje - Mar. Déc. 11 06:55:12 2007]: > > > [book - Mon Dec 10 16:22:28 2007]: > > > We ameliorated this situation somewhat for warserver by > > introducing/modifying the cmdlevels to: > > [...] > > What's the difference between ADMIN

Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-11 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > Jason Dorje Short wrote: > Also the whole point of the HACK check is that the client SHOULD have > permission to delete the file created. If the client cannot write to > that file then it should not be granted hack access. Speaking as an

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > [book - Mon Dec 10 16:22:28 2007]: > We ameliorated this situation somewhat for warserver by > introducing/modifying the cmdlevels to: [...] What's the difference between ADMIN and CTRL access levels? -jason __

Re: [Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-10 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > William Allen Simpson wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > > server/gamehand.c >handle_single_want_hack_req() > Sent send_ruleset_choices() when HACK is not successful. > Redundant send_conn_info()

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-10 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > [wsimpson - Sun Dec 09 22:15:45 2007]: > > server/gamehand.c >handle_single_want_hack_req() > Sent send_ruleset_choices() when HACK is not successful. > Redundant send_conn_info() when HACK is not successful. > > client/conn

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-09 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > server/gamehand.c handle_single_want_hack_req() Sent send_ruleset_choices() when HACK is not successful. Redundant send_conn_info() when HACK is not successful. client/connectdlg_common.c handle_single_want_hack_reply()