http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Hopefully committed correctly to S2_2 (r14846) and trunk (r14847).
There were some files added/moved and lots of changes to
makefiles, so be sure to re-run autogen.sh.
--
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
2008/6/19 Madeline Book:
>
> When I get the OK, I'll commit this editor work so far
> so that I can continue implementing other editor features.
Looks good to me.
> Meanwhile, I am having a problem with my method of composi-
> ting sprites
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [book - Wed Jun 11 19:56:11 2008]:
>
> > [EMAIL PROTECTED] - Wed Jun 11 16:51:03 2008]:
> >
> > - Add FIXME about the fact that following code is not
> > generic enough (gen-movement)
> >
> > + coastal = is_sailing_unittype(punittype);
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [book - Wed Jun 11 20:43:45 2008]:
>
> > [EMAIL PROTECTED] - Wed Jun 11 19:15:25 2008]:
> >
> > - packhand.c:2368: handle_tile_info: Assertion
> > `unit_list_size(ptile->units) == 0' failed. I were removing vision
> > from tile with someb
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Thanks for the thorough reply. My ideas for specific issues
follow below.
> [EMAIL PROTECTED] - Thu Jun 12 21:21:14 2008]:
>
> Please don't assume that bases are stored as specials. Iterating
> specials should already skip S_FORTRESS and S
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
2008/6/12 Madeline Book:
>
> PR#37356, which you can feel free
> to ignore if you've heard before or just have not had time to
> address the issues raised there).
That's temporary halfway solution. Old codebase had just specials
AIRBASE and
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [book - Wed Jun 11 19:56:11 2008]:
>
> > [EMAIL PROTECTED] - Wed Jun 11 16:51:03 2008]:
> >
> > - There's some new direct S_FORTRESS and S_AIRBASE references.
> > That goes against work for generic military bases. See common/
> > base.[ch
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Madeline Book wrote:
> I actually like the whole 3 line "..." header as a visual
> separator between functions (thanks in large part due to the
> nice color difference in syntax hilighting). Anyway, that is
> just my preference; are you sugg
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [EMAIL PROTECTED] - Thu Jun 12 04:43:02 2008]:
>
> Madeline Book wrote:
> > http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> >
> >> [EMAIL PROTECTED] - Wed Jun 11 16:51:03 2008]:
> >>
> >> I only read sources, not yet tested.
> >
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Madeline Book wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
>
>> [EMAIL PROTECTED] - Wed Jun 11 16:51:03 2008]:
>>
>> I only read sources, not yet tested.
>>
>>
>> - Please don't add new empty function headers. New code
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Madeline Book wrote:
>> - Why city creation now fails without telling reason to client?
>> (modifications to handle_edit_city_create() /
>> handle_edit_create_city() )
>
> I thought a long time about how and when to do error messages
> in
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [EMAIL PROTECTED] - Wed Jun 11 19:15:25 2008]:
>
> After some testing:
>
> - Only functionality missing from this new model, but present in old
> version seems to be modifying city internals
I don't recall there being any GUI for doing
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [EMAIL PROTECTED] - Wed Jun 11 18:35:06 2008]:
>
> About splitting this to smaller commits:
>
> - Helper functions from civclient.c should go in immediately. They
> are simple enough, and they have use outside editor part of the code.
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [EMAIL PROTECTED] - Wed Jun 11 16:51:03 2008]:
>
> I only read sources, not yet tested.
>
>
> - Please don't add new empty function headers. New code should have
> function headers already when committed.
What do you mean by "empty f
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
On Tue, Jun 10, 2008 at 11:32 AM, Madeline Book <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
>
>> [EMAIL PROTECTED] - Tue Jun 10 12:37:35 2008]:
>>
>> 2008/6/9 Madeline Book
>> > With your blessing I w
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [EMAIL PROTECTED] - Tue Jun 10 12:37:35 2008]:
>
> 2008/6/9 Madeline Book
> > With your blessing I will being to merge this new
> > editor gui code into S2_2 and trunk. That way afterwards
> > individual commits can stay relatively small a
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [book - Mon May 05 05:46:41 2008]:
>
> I started to add some packet definitions, so to avoid
> conflicts with existing packet numbers I made all editor
> packets start at 200. Is there any reason why this would
> not be a good idea?
So th
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [engla - Mon Apr 28 16:15:54 2008]:
>
> 2008/4/28 Madeline Book <[EMAIL PROTECTED]>:
> >
> > http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> >
> > The usual status update, gentlemen.
> >
> > I will have more time to work on thi
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
2008/4/28 Madeline Book <[EMAIL PROTECTED]>:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
>
> The usual status update, gentlemen.
>
> I will have more time to work on this this week since
> the stuff I wanted to do for longt
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
> [EMAIL PROTECTED] - Sun Apr 06 16:20:31 2008]:
>
> On 04/04/2008, Madeline Book wrote:
> >
> > A small preview of the editor toolbar in action, as
> > described in the editor wikia page.
> > I have also attached a screenshot if you do
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
On 04/04/2008, Madeline Book wrote:
>
> A small preview of the editor toolbar in action, as
> described in the editor wikia page.
> I have also attached a screenshot if you do not have
> the time (or the means) to apply a git binary diff
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Here it is: http://forum.freeciv.org/viewtopic.php?p=19680#19680
On 4/4/08, Daniel Markstedt <[EMAIL PROTECTED]> wrote:
> Very nice, Madeleine! I'm thinking of starting a forum thread to
> attract the attention of Freeciv's creative minds.
On Fri, Apr 4, 2008 at 10:45 AM, Daniel Markstedt <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
>
> Very nice, Madeleine! I'm thinking of starting a forum thread to
> attract the attention of Freeciv's creative minds. :)
Yes, really awesome. I am happy to
http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
Very nice, Madeleine! I'm thinking of starting a forum thread to
attract the attention of Freeciv's creative minds. :)
On 4/4/08, Madeline Book <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=40184 >
>
> A sma
24 matches
Mail list logo
