[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 [EMAIL PROTECTED] - Mon Jun 16 01:14:01 2008]: 2008/6/15 Madeline Book: This gave me another idea along the same lines: PREREQS_KNOWN. I were worried this would turn out too long, but in the end I'm quite happy with it. In

[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 Discussion about this started in #38372. Attached patch renames: player_invention_is_ready() - player_invention_reachable() TECH_REACHABLE - TECH_PREREQS COLOR_REQTREE_REACHABLE_GOAL - COLOR_REQTREE_PREREQS_GOAL

Re: [Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 2008/6/15 Madeline Book: If the goal is to make the names more intuitive from the point of view of an English speaker, then in my opinion HAS_PREREQS (or maybe even HAVE to implicitly indicate that it is I/you/we the player that has

[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 [EMAIL PROTECTED] - Sun Jun 15 14:01:02 2008]: Discussion about this started in #38372. Attached patch renames: TECH_REACHABLE - TECH_PREREQS COLOR_REQTREE_REACHABLE - COLOR_REQTREE_PREREQS COLOR_REQTREE_REACHABLE_GOAL -

[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 [EMAIL PROTECTED] - Sun Jun 15 19:07:47 2008]: Actually, HAS_PREREQS sounds like technology that has prereqs defined, not one that somebody has prereqs researched for. Yes that ambiguity is a little annoying. :/ How about

Re: [Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready

2008-06-15 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40280 2008/6/15 Madeline Book: This gave me another idea along the same lines: PREREQS_KNOWN. I were worried this would turn out too long, but in the end I'm quite happy with it. In addition to this change, I moved word GOAL before