Re: [Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-20 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > 2008/7/20 Marko Lindqvist: > Client is crashing because > phase number is considered to be same as number of active player and > 32 is illegal player number. > now I looked it, it seems to be > almost trivial to fix Like this. - ML dif

Re: [Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-20 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > On Sat, Jul 19, 2008 at 5:10 PM, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=40384 > > > 2008/7/20 Jason Dorje Short: >> >> It's only illegal in that particular assertion. Fix the assertion a

Re: [Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-19 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > 2008/7/20 Jason Dorje Short: > > It's only illegal in that particular assertion. Fix the assertion and > that is fixed! Though for backwards compatibility with old clients > 2.1 may prefer a workaround. What assertion you are talking abou

Re: [Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-19 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > On 7/19/08, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=40384 > > > 2008/7/19 Jason Dorje Short <[EMAIL PROTECTED]>: >> >> http://bugs.freeciv.org/Ticket/Display.html?id=40384 > >> >> On 7/19/

Re: [Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-19 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > 2008/7/19 Jason Dorje Short <[EMAIL PROTECTED]>: > > http://bugs.freeciv.org/Ticket/Display.html?id=40384 > > > On 7/19/08, Marko Lindqvist <[EMAIL PROTECTED]> wrote: >> >> http://bugs.freeciv.org/Ticket/Display.html?id=40384 > >> >> With al

Re: [Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-19 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > On 7/19/08, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=40384 > > > With altering movement phase can end being 32, causing crash in > client update_info_label(). Fix attached. I'm pretty sur

[Freeciv-Dev] (PR#40384) [Patch] Fix altering movement crash due to illegal phase

2008-07-19 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40384 > With altering movement phase can end being 32, causing crash in client update_info_label(). Fix attached. - ML diff -Nurd -X.diff_ignore freeciv/client/packhand.c freeciv/client/packhand.c --- freeciv/client/packhand.c 2008-07-09 10:44