Update of bug #13587 (project freeciv):
Status: In Progress = Postponed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #8, bug #13587 (project freeciv):
Updated to recent trunk.
逃げ出してるよ！
(file #5993)
___
Additional Item Attachment:
File name:
Follow-up Comment #7, bug #13587 (project freeciv):
I made some minor improvements to your patch, see
the attached version. This would be the version that
I commit, if nobody sees anything wrong with it.
I made unit_description() only append the upkeep
information if the unit is owned by the
Follow-up Comment #5, bug #13587 (project freeciv):
version 3
changes:
- both functions take an astring parameter
- unit_activity_text() is now a wrapper for
unit_activity_astr()
- move include file to unit.c
Also, do not include headers in other headers
(as I have told you in another
Follow-up Comment #6, bug #13587 (project freeciv):
version 4:
- remove upkeep_info (see 13586)
(file #5904)
___
Additional Item Attachment:
File name: version4-13587-gold6.patch.diff Size:8 KB
Follow-up Comment #4, bug #13587 (project freeciv):
Alright, I was not sufficiently clear in my
last comments, so I will explain what I meant.
I wanted you to change unit_upkeep_text() to
take an astring parameter:
void unit_upkeep_text(const struct unit *punit, struct astring *astr);
and
Follow-up Comment #3, bug #13587 (project freeciv):
changes in version 2:
- use astring
- upkeep information are only visible for own units
- also update unit_activity_text()
(file #5844)
___
Additional Item Attachment:
File name:
Update of bug #13587 (project freeciv):
Assigned to:None = mbook
___
Reply to this item at:
http://gna.org/bugs/?13587
___
Message sent
URL:
http://gna.org/bugs/?13587
Summary: [patch] add upkeep information to units in city
dialog
Project: Freeciv
Submitted by: syntron
Submitted on: Donnerstag 28.05.2009 um 12:15
Category: general
Follow-up Comment #1, bug #13587 (project freeciv):
possible problem: to much information for a diplomat/spy?
___
Reply to this item at:
http://gna.org/bugs/?13587
___
Nachricht geschickt
2009/5/28 Matthias Pfafferodt:
depends on 13856
You may want to make your patches a bit less interdependant. That way
several of them could be handled parallel. Now it seems that I cannot
handle any of them before book has finished handling first ones.
- ML
This patch really depends on 13856 due to the upkeep information saved in the
unit struct. At the moment this is not working as mentioned in the text to
13856. Somehow the upkeep information is not transfered to the client.
Due to the fact, that the patches touch the same code a certain
On 28/05/2009, Marko Lindqvist cazf...@gmail.com wrote:
2009/5/28 Matthias Pfafferodt:
depends on 13856
You may want to make your patches a bit less interdependant. That way
several of them could be handled parallel. Now it seems that I cannot
handle any of them before book has finished
Update of bug #13587 (project freeciv):
Status:None = In Progress
___
Follow-up Comment #2:
possible problem: to much information for a diplomat/spy?
Then the server should not send the
14 matches
Mail list logo
