Update of bug #13621 (project freeciv):
Status: In Progress = Duplicate
Assigned to: mbook = cazfi
Open/Closed:Open = Closed
Follow-up Comment #11, bug #13621 (project freeciv):
a new version can be found in gna bug #13873
___
Reply to this item at:
http://gna.org/bugs/?13621
___
Nachricht geschickt von/durch
Follow-up Comment #10, bug #13621 (project freeciv):
So any error messages from the setting_*()
functions would be only advisory, and should
probably only be echoed to the console with
freelog(LOG_ERROR, ...).
If server is going to die because of the error, you should use LOG_FATAL.
Update of bug #13621 (project freeciv):
Severity: 3 - Normal = 2 - Minor
Priority: 5 - Normal = 3 - Low
Status:None = In Progress
Follow-up Comment #7, bug #13621 (project freeciv):
version 5; changes:
- separate functions to set the bool, int
string values
- called from ruleset.c and stdinhand.c
- reordering of set_command()
(file #5991)
___
Additional Item
Follow-up Comment #8, bug #13621 (project freeciv):
version 5; changes:
Some slight problems with this version:
- A better name would be load_ruleset_game_settings().
- 'astr' should not be static.
- 'astr' should not even be an astring, a stack
allocated char array would suffice (just pass
Follow-up Comment #5, bug #13621 (project freeciv):
The attached version has some minor style and
formatting improvements and is more or less
good enough to commit, I think. There is though
the obvious problem that ruleset_set_cmd() does
not handle setting side-effects like the
set_command()
Follow-up Comment #6, bug #13621 (project freeciv):
Thanks for looking at this patch.
Could A cleanup for the FIXME reminders
be the following:
- a function game_setting(op, bool *bval,
int *ival, char* sval) which set the
requested option (in stdinhand.c)
switch (op-stype) {
case
Follow-up Comment #4, bug #13621 (project freeciv):
updated patch (version 3)
changes:
- remove {} /* no error */
- reorder include files alphabetical
(file #5896)
___
Additional Item Attachment:
File name:
Follow-up Comment #2, bug #13621 (project freeciv):
updated version of the patch
changes:
- change 'do {...} while (...)' to 'for(...) {...}'
- update is _not_ needed as this function is
called pre-game so the ruleset information
are send to the client(s) after the function call
- the '{}
Update of bug #13621 (project freeciv):
Assigned to:None = mbook
___
Follow-up Comment #3:
A better and more c compiler friendly style would
be to either declare the variables before the
URL:
http://gna.org/bugs/?13621
Summary: [patch] load game settings from ruleset
Project: Freeciv
Submitted by: syntron
Submitted on: Mittwoch 03.06.2009 um 23:18
Category: general
Severity: 3 - Normal
Follow-up Comment #1, bug #13621 (project freeciv):
Some basic things I noticed looking at the
patch:
You can just use the simpler
for (op = settings; op-name; op++)
instead of 'do {} while' to iterate over
settings. (Maybe there should be a settings
_iterate macro.)
You probably do not
13 matches
Mail list logo
