[Freeciv-Dev] [bug #13846] recursion checking for the read command

URL: Summary: recursion checking for the read command Project: Freeciv Submitted by: syntron Submitted on: Mittwoch 01.07.2009 um 21:42 Category: general Severity: 2 - Minor

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #1, bug #13846 (project freeciv): add missing changes to stdinhand.h (file #6108) ___ Additional Item Attachment: File name: 0001-recursion-checking-for-the-read-command.patch Size:7 KB

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #2, bug #13846 (project freeciv): Just infinite recursion should be prohibited, not any read inside other read. That is, original file should not read itself, nor file that reads the original, nor file that reads file that read original... but otherwise read should be allowed.

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #3, bug #13846 (project freeciv): Easy, but acceptable, solution would be to add max recursion level. Nobody needs recursion deeper than 5 (so make max 10 to be safe :-) levels and exceeding it may mean infinite recursion. ___

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #4, bug #13846 (project freeciv): Please no static variables. Use a context argument and a wrapper/recursive function pair. Ask if you need an example. なんじゃそりゃ。 __

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #5, bug #13846 (project freeciv): I added 'bool read_cmd'. I thin this can be changed to 'int read_level' and for 'read_level >= 5' there will be an error message ... ___ Reply to this item at:

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #6, bug #13846 (project freeciv): updated patch changes: - max 10 calls to read - check is possible for the read command (used for voting?) (file #6132) ___ Additional Item Attachment: File name: gna13846-recursion-c

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Update of bug #13846 (project freeciv): Assigned to:None => cazfi ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #7, bug #13846 (project freeciv): I think book's comment about wrappers asked for something like this: bool handle_stdin_input(...) { return handle_stdin_input_real(... , 0); } bool read_init_script(...) { return read_init_script_real(... , 0); } static bool handle_stdin_

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #8, bug #13846 (project freeciv): OK; after a _long_ time looking at the code I think I see what you mean. I will prepare an updated patch ... ___ Reply to this item at: __

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Follow-up Comment #9, bug #13846 (project freeciv): updated patch: recursion checking for the read command * using a wrapper/recursive function pair * add 'bool check' to read_init_script() (file #6186) ___ Additional Item Attachment

[Freeciv-Dev] [bug #13846] recursion checking for the read command

Update of bug #13846 (project freeciv): Status:None => Fixed Open/Closed:Open => Closed ___ Reply to this item at: