Update of bug #16655 (project freeciv):
Status: Ready For Test = Fixed
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #8, bug #16655 (project freeciv):
updated version of the patch with the changes proposed on comment #7
(file #10289)
___
Additional Item Attachment:
File name: 20100910-07-trunk-fix-log_normal-messages.patch Size:6 KB
Update of bug #16655 (project freeciv):
Category:None = general
Status:None = Ready For Test
Assigned to:None = pepeto
Follow-up Comment #4, bug #16655 (project freeciv):
Well, I have checked that too, but I doubt it is a good
solution. I think some of those messages shouldn't be
log_normal() but log_verbose().
I did check the messages and here are my ideas about possible changes of the
log levels:
Follow-up Comment #5, bug #16655 (project freeciv):
I totally agree with your analysis, I would have done exactly the same.
Also, I noticed a translation with Q_() of the meta message
that looks very strange, since this string can be set by the
user.
There do you find this?
Using _grep
Follow-up Comment #6, bug #16655 (project freeciv):
updated patch including the changes mentioned in comment #5 and comment #3
savegame2.c: The messages are also only additional output. So
they should be log_verbose (loading /saving in format x) or
log_debug (time needed to create the
Follow-up Comment #7, bug #16655 (project freeciv):
savegame2.c: The messages are also only additional output. So
they should be log_verbose (loading /saving in format x) or
log_debug (time needed to create the secfile).
I did use for both log_verbose().
I would prefer personally the
URL:
http://gna.org/bugs/?16655
Summary: Trunk contains not translated log_normal() messages
Project: Freeciv
Submitted by: pepeto
Submitted on: mardi 07.09.2010 à 10:08
Category: None
Severity: 3 -
Follow-up Comment #1, bug #16655 (project freeciv):
add _() for all messages found in my local git tree by the following
command:
'git grep log_normal( | grep -v _('
(file #10235)
___
Additional Item Attachment:
File name:
Follow-up Comment #2, bug #16655 (project freeciv):
Well, I have checked that too, but I doubt it is a good solution. I think
some of those messages shouldn't be log_normal() but log_verbose().
Also, I noticed a translation with Q_() of the meta message that looks very
strange, since this
Follow-up Comment #3, bug #16655 (project freeciv):
Attached a version of file #10235 with a couple of (pre-existing) typos
fixed.
(file #10239)
___
Additional Item Attachment:
File name: trunk-translate-log_normal-messages-bis.patch
11 matches
Mail list logo
