Update of patch #1252 (project freeciv):
Status:None = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #11, patch #1252 (project freeciv):
updated patch attached
changes:
* set RS_MAX_UPGRADE_VETERAN_LOSS to MAX_VET_LEVELS (= 10)
* adapted civ1/civ2 ruleset
(file #6678)
___
Additional Item Attachment:
File name:
Follow-up Comment #10, patch #1252 (project freeciv):
- MAX_UPGRADE_VETERAN_LOSS should be lower. It's certainly
a mistake if
someone tries to set this to more than 100 veterancy levels
(default ruleset has 5 and IIRC code supports up to 32)
I recalled wrongly. I now checked this and max
Follow-up Comment #9, patch #1252 (project freeciv):
- I guess xxx_BRIDE_COST should be xxx_BRIBE_COST :-)
ups; you are correct ...
In general min/max checks should be only against illegal values, and not
restricting too much what ruleset can do. So I'd set some max values to
ridiculously
Follow-up Comment #5, patch #1252 (project freeciv):
as requested I created an updated patch:
cleanup of load_ruleset_game()
* define min/max/default values for most ruleset settings
* define the standard values for all ruleset settings in
game.h using 'RS_*'
* add
Follow-up Comment #6, patch #1252 (project freeciv):
the function ruleset_error has to be changed to send a
notification to all clients ...
___
Reply to this item at:
http://gna.org/patch/?1252
Follow-up Comment #7, patch #1252 (project freeciv):
the function ruleset_error has to be changed to send a
notification to all clients ...
No. It would be potential security issue if remote clients get error messages
quite internal to server.
Update of patch #1252 (project freeciv):
Assigned to:None = cazfi
Planned Release:None = 2.2.0
___
Follow-up Comment #4:
I added such a
Follow-up Comment #3, patch #1252 (project freeciv):
That would mean this patch only replaces need to check min/max values (at
calling side) with need to check for returned error message.
I would use callback function that handles error messages. In case of
ruleset loading ruleset_error()
Follow-up Comment #1, patch #1252 (project freeciv):
version 2:
* add missing change from game.rgame to game.server.rgame
(file #6478)
___
Additional Item Attachment:
File name: version2-cleanup-of-load_ruleset_game.patch Size:28 KB
URL:
http://gna.org/patch/?1252
Summary: cleanup of load_ruleset_game()
Project: Freeciv
Submitted by: syntron
Submitted on: Dienstag 18.08.2009 um 12:23
Category: general
Priority: 3 - Low
Follow-up Comment #2, patch #1252 (project freeciv):
How should the functions in registry.c be changed to send a
message to the clients? An extra argument 'char *err_msg' could
be added to each of these functions. It would be NULL if there
is no error, else it would contain the error message
12 matches
Mail list logo
