On Fri, 31 May 2013 11:06:26 PM you wrote:
> I apoligize if this is not the correct way to submit a fix.

The best method is to attach a diff to either the bug tracker or to a message 
to the developer's mailing list.  Mailing to me directly is less helpful as I 
usually try not to handle GUI problems.  However, ATM, the people that 
actually understand the FreeCol GUI are busy, so it amounts to the same thing.
 
> I believe that the bug it would be fix by adding :
> okButton.requestFocus();
> on  line 105 after add(okButton, "tag ok");
> 
> In the next file:
> *
> \workspace\freecol\src\net\sf\freecol\client\gui\panel\InformationDialog.jav

I am sure you are right, and that would fix some problems.  Thanks for that, I 
will commit your fix soon.  However, I do not know if it fixes *all* the 
problems referred to in the bug report.  What is needed to close that bug is a 
complete review of *all* the dialogs FreeCol displays, and for a consistent 
choice to be made for each case which of the buttons should have focus, or if 
it is more appropriate that *no* button has focus.  

Cheers,
Mike Pope

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to