I agree from a practical standpoint 100%. If we can share the credit I'm
all for that from a principle standpoint.
If SF can't make it work, then we have no choice but to commit the change
ourselves.
Caleb
On Sep 20, 2016 10:55 PM, "Michael T. Pope" wrote:
> On Tue, 20 Sep 2016 21:43:07 -0500
On Tue, 20 Sep 2016 21:43:07 -0500
Caleb Williams wrote:
> Can you give it a shot Mike?
Michael Vetter has a point about the information being richer, and
somewhat politer, but cycling the repo for a one character fix is
disproportionate.
Cheers,
Mike Pope
pgpccm3F_txf6.pgp
Description: OpenPG
On Tue, Sep 20, 2016 at 9:34 PM, Caleb Williams wrote:
> > Oh but you made a small mistake.
> > If you would have used: git apply
> > 0001-Fix-testing-of-jar-in-FHS-location.patch
>
> > Thenn all the author information would have been used. Like this it was
> > written like its your patch. Some p
> Oh but you made a small mistake.
> If you would have used: git apply
> 0001-Fix-testing-of-jar-in-FHS-location.patch
> Thenn all the author information would have been used. Like this it was
> written like its your patch. Some people could either take this the
> wrong way (unfair) or generally i
On Tue, 20 Sep 2016 19:45:51 +0930
"Michael T. Pope" wrote:
> On Tue, 20 Sep 2016 11:37:19 +0200
> Michael Vetter wrote:
> > I think I spotted a small mistake in the freecol.sh script.
> > You use test -d there which is used to look for a directory.
> > Actually we want to look for a jar file in
On Tue, 20 Sep 2016 11:37:19 +0200
Michael Vetter wrote:
> I think I spotted a small mistake in the freecol.sh script.
> You use test -d there which is used to look for a directory. Actually
> we want to look for a jar file in that directory, so we should use test
> -r.
Good catch. Applied.
com
Hello guys,
I think I spotted a small mistake in the freecol.sh script.
You use test -d there which is used to look for a directory. Actually
we want to look for a jar file in that directory, so we should use test
-r.
Let me know what you think.
Patch is attached to this mail.
jubalh>From 7f20b9
