Re: [Freecol-developers] Bartolome De las Casas Bonus isn't persistent

2022-09-24 Thread David Lewis
I think I wrote that mod a few years back? But yes, went back over old discussions, wanted to bring it up to put in a fix to the FreeCol ruleset. David On Sat, Sep 24, 2022, 15:47 Michael T. Pope wrote: > On Sat, 24 Sep 2022 13:10:58 -0700 > David Lewis wrote: > >[Casas] > > We discussed Casa

Re: [Freecol-developers] Bartolome De las Casas Bonus isn't persistent

2022-09-24 Thread Michael T. Pope
On Sat, 24 Sep 2022 13:10:58 -0700 David Lewis wrote: >[Casas] We discussed Casas years ago, and agreed the Col1 behaviour was broken. You might want to look at the convertUpgrade mod which emerged from that discussion. Cheers, Mike Pope pgpw4yywNM421.pgp Description: OpenPGP digital signature

Re: [Freecol-developers] Bartolome De las Casas Bonus isn't persistent

2022-09-24 Thread David Lewis
I don't recall that being the case in Col1, but it would be a little weird to lose ability through the conversation or education. I'm not convinced the Col1 behavior makes sense, but that's why this change would go into the FreeCol ruleset. David On Sat, Sep 24, 2022, 02:36 Jonas Stumph Stevnsv

Re: [Freecol-developers] Bartolome De las Casas Bonus isn't persistent

2022-09-24 Thread Jonas Stumph Stevnsvig
If I recall correctly, converts have a small bonus to farming, fishing, etc. That may be advantageous to keep in some situations. Maybe the clear speciality or education is a more controllable way of "upgrading" them? Den 24. sep. 2022 09.53, fra 09.53, Stian Grenborgen skrev: >> From: David L

Re: [Freecol-developers] Fixing issues with production on tiles

2022-09-24 Thread Stian Grenborgen
> From: Lone_Wolf via Freecol-developers > > Sent: 07 September 2022 10:47 > > [...] > > I strongly suggest to look at the code used for production in buildings . > > The data the formulae used there are based on is found in bug tickets > created by me. > > Analysis is also found in those ticket

Re: [Freecol-developers] Fixing issues with production on tiles

2022-09-24 Thread Stian Grenborgen
> From: Sébastien Fauvel > Sent: 07 September 2022 00:33 > > To quickly create non-regression tests on cases with high combinatorics, > I use approvaltests. You execute code with all cases and for each, you write > the value in a file. You just have to check that this file is always the same > aft

Re: [Freecol-developers] Bartolome De las Casas Bonus isn't persistent

2022-09-24 Thread Stian Grenborgen
> From: David Lewis > Sent: 24 September 2022 00:27 > > I feel like this particular bonus – which matches Col1 – is actually part of > a Col1 bug. > That is that after you recruit Bartolome and your converts are converted to > Free Colonist, > the benefit ends there. No future Convert will becom