Re: [Freecol-developers] internal getters vs performance

2016-12-08 Thread Enrico Weigelt, metux IT consult
On 08.12.2016 22:02, Michael T. Pope wrote: >> Should we instead make them final or use the underlying fields >> directly ? > > We could. Patches welcome. This is low priority stuff though. Okay, I'll do that when touching these places for other reasons. --mtx

Re: [Freecol-developers] internal getters vs performance

2016-12-08 Thread Michael T. Pope
On Thu, 8 Dec 2016 17:50:41 +0100 "Enrico Weigelt, metux IT consult" wrote: > we've got a lot of trivila getters that are heavily used within > their classes. As they're public and not final, the compiler can't > inline them (it must assume that they might be overwritten

[Freecol-developers] internal getters vs performance

2016-12-08 Thread Enrico Weigelt, metux IT consult
Hi folks, we've got a lot of trivila getters that are heavily used within their classes. As they're public and not final, the compiler can't inline them (it must assume that they might be overwritten by derived classes), which of course introduces a performance penalty. Should we instead make