Re: [Freedos-devel] MEM null string bug fix

2025-03-04 Thread E. C. Masloch via Freedos-devel
On at 2025-02-25 22:40 +0100, tom ehlert via Freedos-devel wrote: Hi, and whatever UPBs and DPBs and lDOS style S MCBs are: can't be that important. UPBs (Unit Parameter Blocks) are known to the FreeDOS kernel and the interrupt list as DDTs (Drive Data Tables), to EDR-DOS as UDSCs (Unit De

Re: [Freedos-devel] MEM null string bug fix

2025-02-26 Thread Danilo Pecher via Freedos-devel
Bernd, I saw that. That's exactly why I was a bit confused about the initialization in the variable declaration. Back when I was a lad there were two schools of thought. One half of people did initialize all variables upon declaration, the other half never did so, initializing them in the main code

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread tom ehlert via Freedos-devel
Hi, >> and whatever UPBs and DPBs and lDOS style S MCBs are: can't be that >> important. > UPBs (Unit Parameter Blocks) are known to the FreeDOS kernel and the > interrupt list as DDTs (Drive Data Tables), to EDR-DOS as UDSCs (Unit > Descriptors), and to MS-DOS as BDS (Block Data Structure).

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread E. C. Masloch via Freedos-devel
Hello, On at 2025-02-25 15:52 +0100, tom ehlert via Freedos-devel wrote: "On current lDOS, loading things into the HMA or UMA makes it so that only the DOS-internal UPBs and DPBs are allocated within the Low Memory Area MCB chain. (BIOCODE and DOSDATA are in front of the first MCB.) They already

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread E. C. Masloch via Freedos-devel
On at 2025-02-25 19:16 +0100, Danilo Pecher via Freedos-devel wrote: Actually the first snippet looks a bit dodgy to me. Why initialize one pointer and not the other? If you'd actually looked into the source text for this [1] you would have found quickly that the other pointer *is* already ini

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread Bernd Böckmann via Freedos-devel
On 25.02.2025 19:16, Danilo Pecher via Freedos-devel wrote: Actually the first snippet looks a bit dodgy to me. Why initialize one pointer and not the other? https://gitlab.com/FreeDOS/base/mem/-/blob/62832f6570204d3cacff7dc858ec84860ff12d91/SOURCE/MEM/MEM.C#L1677 ;)

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread Danilo Pecher via Freedos-devel
Actually the first snippet looks a bit dodgy to me. Why initialize one pointer and not the other? It almost looks like someone just wanted to make his patch look a bit more substantial than it really is. On Tue, 25 Feb 2025 at 17:45, tom ehlert via Freedos-devel wrote: > > Hi, > > > Recently, ECM

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread tom ehlert via Freedos-devel
Hi, > Recently, ECM submitted a pair updates to the MEM command "fix search_sd > returning an uninitialised pointer if empty SD MCB” > and “fix search_sd omitting last SD sub-MCB if it is empty” the FreeDOS > GitLab Archive. [1] > As far as I know, there is no upstream project for the MEM comm

Re: [Freedos-devel] MEM null string bug fix

2025-02-25 Thread Danilo Pecher via Freedos-devel
Funny. My go-to language in the early 90s was Pascal as well, but I don't think I could code in anything but C or assembler these days. Compared to those two Pascal seems almost cumbersome with 30 years of hindsight... On Tue, 25 Feb 2025 at 13:53, Jerome Shidel via Freedos-devel wrote: > > Hi,

[Freedos-devel] MEM null string bug fix

2025-02-25 Thread Jerome Shidel via Freedos-devel
Hi, Recently, ECM submitted a pair updates to the MEM command "fix search_sd returning an uninitialised pointer if empty SD MCB” and “fix search_sd omitting last SD sub-MCB if it is empty” the FreeDOS GitLab Archive. [1] As far as I know, there is no upstream project for the MEM command. I ha