I took a pass through the driver looking for CONFIG_ paths that were
untested. I found a few cases where either compile was broken, or the
config path was never used. Here's a few patches to fix it up.
Here's hoping this will avoid any nastygrams from folks running into
compilation issues once dpu
It's mostly gone and won't compile with CONFIG_ION, so
remove the remaining pieces.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 25 -
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 4
2 files changed, 29 deletions(-)
diff --git a/drivers/gpu/d
See subject.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile
index 2604ccfd0653..3624b5af5ecd 100644
--- a/drivers/gpu/drm/msm/Makefile
+++ b/drivers/gpu/
It's pretty easy to just s/debug/err/
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h
b/drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.h
index 773b52e71a22..bc07381d7429 100644
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h
b/drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h
index 89edf2526aca..1e6fa945f98b 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu
QC bus scaling isn't upstream yet, so remove the bus scaling code until
it is.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 35 --
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 7 +-
.../gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 522 +-
.../
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/Makefile| 4 ++--
drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile
index 3624b5af5ecd..1639ea8c0d13 100644
--- a
On Thu, Jun 28, 2018 at 4:10 PM Jordan Crouse wrote:
>
> On Thu, Jun 28, 2018 at 02:28:55PM -0400, Sean Paul wrote:
> > This time the iomap/iounmap helper functions. Move map into dpu and
> > refactor it to reflect their actual use. iounmap wasn't useful, so
> > delete it and call iounmap directly
On Thu, Jun 28, 2018 at 02:28:55PM -0400, Sean Paul wrote:
> This time the iomap/iounmap helper functions. Move map into dpu and
> refactor it to reflect their actual use. iounmap wasn't useful, so
> delete it and call iounmap directly.
>
> Signed-off-by: Sean Paul
> ---
> drivers/gpu/drm/msm/di
It's never called since we use the atomic helpers
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 26 -
drivers/gpu/drm/msm/msm_kms.h | 3 ---
2 files changed, 29 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drive
This allows us to remove postinit, which was added with dpu support.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 13 ++---
drivers/gpu/drm/msm/msm_drv.c | 9 -
drivers/gpu/drm/msm/msm_kms.h | 1 -
3 files changed, 6 insertions(+),
It's unused.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 32 -
1 file changed, 32 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
index 12dc6a9d3b25..44fefc97e1b3 100644
--- a
Allocate pstates from the heap to avoid the following warning when
building with an arm target.
warning: the frame size of 1080 bytes is larger than 1024 bytes
[-Wframe-larger-than=]
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +--
1 file changed, 5 insertions
It's not used anywhere and it lets us revert the changes to msm_fb
to match upstream.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 279
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 69 --
drivers/gpu/drm/msm/msm_drv.h | 3 -
driver
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 --
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 4
2 files changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index 52f3e0667c33..c70b609aa7f2 1006
It's not called anywhere.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 44 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 4 ---
drivers/gpu/drm/msm/msm_kms.h | 3 --
3 files changed, 51 deletions(-)
diff --git a/drivers/gpu/drm/msm
We don't use dpucustom, and the suspend blanking should be done by
userspace instead of in kernel.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 51 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 7
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c |
No need to have this in msm_drv, so move it into dpu. While we're at
it, remove the other CONFIG_DRM_MSM_DPU ifdef gates.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 ++-
drivers/gpu/drm/msm/msm_drv.c | 41 -
2 files changed
Revert the component_bind function back to upstream.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/msm_drv.c | 30 +-
1 file changed, 5 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 561617db7338..51
It's unused.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8
drivers/gpu/drm/msm/msm_kms.h | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 1f2163430caf..
We don't use it for anything else, so hide it in dpu. A few other
whitespace/trivial fixes to revert dpu changes in msm.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 37 ++---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 +
drivers/gpu/drm/msm/msm_dr
This time the iomap/iounmap helper functions. Move map into dpu and
refactor it to reflect their actual use. iounmap wasn't useful, so
delete it and call iounmap directly.
Signed-off-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 38 +---
drivers/gpu/drm/msm/dis
This patch is removing a bunch more dpu changes that
touch msm core.
Signed-off-by: Sean Paul
Change-Id: I1c82454ad372b34ca5b0d6db2af1b513a5ba2fe1
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 77 +--
drivers/gpu/drm/msm/msm_atomic.c | 3 +-
drivers/gpu/drm/msm/msm_drv.c
It's the only change in that file, so... remove it.
Signed-off-by: Sean Paul
---
include/video/mipi_display.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h
index c83f8a35d765..49a53ef8da96 100644
--- a/include/video/mipi_display.h
Same old thing here, more cleanup patches to reduce the amount of dpu
code leaking into msm core. Most of this has already been squashed into
for-next, because it should be (mostly) uncontraversial and (mostly)
code removal.
Sean
Sean Paul (15):
drm/msm: Remove more dpu changes from msm core
On Thu, Jun 28, 2018 at 04:13:06PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Changes from the previous version mainly involve Danoie's suggestion
Can't type today either: "Daniel's"
> of hiding the drm_encoder_find() in the iterator macro. I also polished
> the msm and tilcdc cases
From: Ville Syrjälä
Use drm_connector_has_possible_encoder() for checking
whether the encoder has an associated connector.
v2: Replace the drm_for_each_connector_encoder_ids() loop
with a simple drm_connector_has_possible_encoder() call
Cc: Rob Clark
Cc: linux-arm-...@vger.kernel.org
Cc: f
From: Ville Syrjälä
Changes from the previous version mainly involve Danoie's suggestion
of hiding the drm_encoder_find() in the iterator macro. I also polished
the msm and tilcdc cases a bit more with another small helper.
Cc: Alex Deucher
Cc: amd-...@lists.freedesktop.org
Cc: Ben Skeggs
Cc:
28 matches
Mail list logo