Re: [Freedreno] [PATCH] drm/msm: rework vblank event handling in dpu_crtc

2018-07-13 Thread Sean Paul
On Fri, Jul 13, 2018 at 06:27:23PM +0530, Rajesh Yadav wrote: > The vblank on/off calls were missing in dpu_crtc > leading to "driver forgot to call drm_crtc_vblank_off()" > warning while entering suspend state. > Also handle the state update completion event for > a crtc being disabled in current

Re: [Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-13 Thread Jordan Crouse
On Thu, Jul 12, 2018 at 09:46:58PM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 12:59:19PM -0600, Jordan Crouse wrote: > > Add a drm printer suitable for use with the read callback for > > devcoredump or other suitable buffer based output format that > > isn't otherwise covered by seq_file

Re: [Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-13 Thread Jordan Crouse
On Thu, Jul 12, 2018 at 08:40:55PM +0100, Chris Wilson wrote: > Quoting Jordan Crouse (2018-07-12 19:59:19) > > Add a drm printer suitable for use with the read callback for > > devcoredump or other suitable buffer based output format that > > isn't otherwise covered by seq_file. > > > > Signed-of

Re: [Freedreno] [PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-13 Thread Rob Clark
On Thu, Jul 12, 2018 at 2:59 PM, Jordan Crouse wrote: > Add a put function for the coredump printer to bypass printf() > for constant strings for a speed boost. s/put/puts/ (and in the $subject) BR, -R > > v2: Add EXPORT_SYMBOL for _drm_puts_coredump > Signed-off-by: Jordan Crouse > --- > dri

[Freedreno] [PATCH] drm/msm: rework vblank event handling in dpu_crtc

2018-07-13 Thread Rajesh Yadav
The vblank on/off calls were missing in dpu_crtc leading to "driver forgot to call drm_crtc_vblank_off()" warning while entering suspend state. Also handle the state update completion event for a crtc being disabled in current atomic commit. This patch depends on https://www.spinics.net/lists/dri-