Re: [Freedreno] [PATCH v3 18/19] dt-bindings: msm/disp: Add bindings for Snapdragon 845 DPU

2018-07-24 Thread Rob Herring
On Fri, Jul 20, 2018 at 04:43:09PM -0400, Sean Paul wrote: > From: Jeykumar Sankaran > > Adds bindings for Snapdragon 845 display processing unit > > Changes in v2: > - Use SoC specific compatibles for mdss and dpu (Rob Herring) > - Use assigned-clocks to set initial clock frequency (Rob

Re: [Freedreno] [PATCH 03/13] drm: Add drm_puts() to complement drm_printf()

2018-07-24 Thread Emil Velikov
Hi Jordan, I might be a bit late for the party, so consider the following jfyi. On 24 July 2018 at 17:33, Jordan Crouse wrote: > +void drm_puts(struct drm_printer *p, const char *str) One could easily use the compiler to detect if drm_printf or drm_puts should be used. See the trace_printk

Re: [Freedreno] [PATCH v2] drm/msm/display: negative x/y in cursor move

2018-07-24 Thread Archit Taneja
Hi, On Tuesday 17 July 2018 04:33 AM, Carsten Behling wrote: modesetting X11 driver may provide negative x/y cordinates in mdp5_crtc_cursor_move call when rotation is enabled. Cursor buffer can overlap down to its negative width/height. ROI has to be recalculated for negative x/y indicating

[Freedreno] [PATCH 12/13] drm/msm/adreno: Add a5xx specific registers for the GPU state

2018-07-24 Thread Jordan Crouse
HLSQ, SP and TP registers are only accessible from a special aperture and to make matters worse the aperture is blocked from the CPU on targets that can support secure rendering. Luckily the GPU hardware has its own purpose built register dumper that can access the registers from the aperture. Add

[Freedreno] [PATCH 08/13] drm/msm/gpu: Rearrange the code that collects the task during a hang

2018-07-24 Thread Jordan Crouse
Do a bit of cleanup to prepare for upcoming changes to pass the hanging task comm and cmdline to the crash dump function. v2: Use GFP_ATOMIC while holding the rcu lock per Chris Wilson Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpu.c | 20 +++- 1 file changed, 11

[Freedreno] [PATCH 09/13] drm/msm/gpu: Capture the GPU state on a GPU hang

2018-07-24 Thread Jordan Crouse
Capture the GPU state on a GPU hang and store it for later playback via the devcoredump facility. Only one crash state is stored at a time on the assumption that the first hang is usually the most interesting. The existing crash state can be cleared after capturing it and then a new one will be

[Freedreno] [PATCH 07/13] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-07-24 Thread Jordan Crouse
Convert the existing GPU show function to use the GPU state to dump the information rather than reading it directly from the hardware. This will require an additional step to capture the state before dumping it for the existing nodes but it will greatly facilitate reusing the same code for dumping

[Freedreno] [PATCH 11/13] drm/msm/adreno: Add ringbuffer data to the GPU state

2018-07-24 Thread Jordan Crouse
Add the contents of each ringbuffer to the GPU state and dump the data in the crash file encoded with ascii85. To save space only the used portions of the ringbuffer are dumped. Signed-off-by: Jordan Crouse --- Documentation/gpu/msm-crash-dump.rst| 7 +

[Freedreno] [PATCH 04/13] drm: Add a -puts() function for the seq_file printer

2018-07-24 Thread Jordan Crouse
Add a puts() function to use seq_puts() to help speed up up print time for constant strings. Reviewed-by: Daniel Vetter Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 6 ++ include/drm/drm_print.h | 2 ++ 2 files changed, 8 insertions(+) diff --git

[Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-24 Thread Jordan Crouse
Add a drm printer suitable for use with the read callback for devcoredump or other suitable buffer based output format that isn't otherwise covered by seq_file. v2: Add improved documentation per Daniel Vetter Signed-off-by: Jordan Crouse --- drivers/gpu/drm/drm_print.c | 74

[Freedreno] [PATCH 06/13] drm/msm/gpu: Capture the state of the GPU

2018-07-24 Thread Jordan Crouse
Add the infrastructure to capture the current state of the GPU and store it in memory so that it can be dumped later. For now grab the same basic ringbuffer information and registers that are provided by the debugfs 'gpu' node but obviously this should be extended to capture a much larger set of

[Freedreno] [v8 PATCH 00/13] drm/msm: Capture and dump the GPU crash state

2018-07-24 Thread Jordan Crouse
This is revision 8 implementing a GPU crash state for drm/msm (https://patchwork.freedesktop.org/series/36097/). This patchset adds better documentation and reflects comments from the mailing lists. I know we will miss 4.19 at this point, but I think this is ready to soak in msm-next for a while.

[Freedreno] [PATCH 01/13] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-07-24 Thread Jordan Crouse
The i915 DRM driver very cleverly used ascii85 encoding for their GPU state file. Move the encode functions to a general header file to support other drivers that might be interested in the same functionality. v4: Make the return value const char * as suggested by Chris Wilson v3: Fix error_puts

[Freedreno] [PATCH 05/13] drm: Add puts callback for the coredump printer

2018-07-24 Thread Jordan Crouse
Add a puts function for the coredump printer to bypass printf() for constant strings for a speed boost. Reorganize the coredump printf callback to share as much code as possible. v2: Try to reuse code between print and puts as suggested by Chris Wilson Signed-off-by: Jordan Crouse ---

[Freedreno] [PATCH] drm/msm: mark PM functions as __maybe_unused

2018-07-24 Thread Arnd Bergmann
The suspend/resume functions are not referenced when power management is disabled: drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:1288:12: error: 'dpu_runtime_resume' defined but not used [-Werror=unused-function] drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:1261:12: error: 'dpu_runtime_suspend' defined

Re: [Freedreno] [PATCH v13 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-24 Thread Robin Murphy
On 19/07/18 11:15, Vivek Gautam wrote: From: Sricharan R The smmu needs to be functional only when the respective master's using it are active. The device_link feature helps to track such functional dependencies, so that the iommu gets powered when the master device enables itself using

[Freedreno] [PATCH linux-next] gnu: fix mismatch in function argument.

2018-07-24 Thread zhong jiang
Fix the sparse error. the dpu_rm_init declaration is not consistent with the implement. Signed-off-by: zhong jiang --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h

[Freedreno] [PATCH linux-next] gnu: fix mismatch in function argument.

2018-07-24 Thread zhong jiang
Fix the sparse error. the dpu_rm_init declaration is not consistent with the implement. Signed-off-by: zhong jiang --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h