Re: [Freedreno] [PATCH 3/3] drm/msm: Don't fail bind if nothing connected to dsi

2018-07-30 Thread abhinavk
On 2018-07-30 08:26, Sean Paul wrote: If there is no bridge or panel connected to a dsi node, don't fail the entire msm bind. Just ignore the dsi block and move on. Cc: Doug Anderson Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 9 +++-- 1

Re: [Freedreno] [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails

2018-07-30 Thread abhinavk
On 2018-07-30 08:26, Sean Paul wrote: If dt parsing fails, we should return an error instead of pretending everything completed successfully. Cc: Doug Anderson Signed-off-by: Sean Paul Thanks for fixing this ! Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1

Re: [Freedreno] [PATCH 1/3] drm/msm: dsi: Initialize msm_dsi->id to -1

2018-07-30 Thread abhinavk
On 2018-07-30 08:26, Sean Paul wrote: Currently msm_dsi->id is initialized to 0 during kzalloc. If bind fails for a secondary dsi device before its id can be properly set (such as during dt parsing), the id will point to the primary dsi device, causing its reference to be removed from

[Freedreno] [PATCH 3/3] drm/msm: Don't fail bind if nothing connected to dsi

2018-07-30 Thread Sean Paul
If there is no bridge or panel connected to a dsi node, don't fail the entire msm bind. Just ignore the dsi block and move on. Cc: Doug Anderson Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Freedreno] [PATCH 2/3] drm/msm: dsi: Return errors whan dt parsing fails

2018-07-30 Thread Sean Paul
If dt parsing fails, we should return an error instead of pretending everything completed successfully. Cc: Doug Anderson Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c

[Freedreno] [PATCH 1/3] drm/msm: dsi: Initialize msm_dsi->id to -1

2018-07-30 Thread Sean Paul
Currently msm_dsi->id is initialized to 0 during kzalloc. If bind fails for a secondary dsi device before its id can be properly set (such as during dt parsing), the id will point to the primary dsi device, causing its reference to be removed from dsi_manager's global (msm_dsim_glb) array. This

[Freedreno] [PATCH 0/3] drm/msm: dsi: Properly handle disconnected secondary dsi block

2018-07-30 Thread Sean Paul
The configuration where dsi0 is connected and dsi1 is disconnected doesn't work currently. When dsi1 fails, it paves the reference to dsi0 in dsi_manager, which causes mass carnage. This set ensures that we clean up the correct dsi device, and that we fail gracefully if a device is not connected

Re: [Freedreno] [PATCH][drm-next] drm/msm/disp/dpu: fix two spelling mistakes

2018-07-30 Thread Sean Paul
On Mon, Jul 30, 2018 at 02:44:46PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in error messages > "diable" -> "disable" > "cliend" -> "client" > > Signed-off-by: Colin Ian King Reviewed-by: Sean Paul > --- >

[Freedreno] [PATCH][drm-next] drm/msm/disp/dpu: fix two spelling mistakes

2018-07-30 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in error messages "diable" -> "disable" "cliend" -> "client" Signed-off-by: Colin Ian King --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 2 +- 2 files changed, 2

[Freedreno] [resend][pull] drm/msm: msm-next for 4.19

2018-07-30 Thread Rob Clark
re-send to fix s-o-b vs committer problem that I overlooked. Sorry, Stephen Rothwell's email about it was lost in the noise. original pull msg: Hi Dave, A bit larger this time around, due to introduction of "dpu1" support for the display controller in sdm845 and beyond. This has been on list