Re: [Freedreno] [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

2018-10-30 Thread Rob Clark
On Tue, Oct 30, 2018 at 1:34 PM Emil Velikov wrote: > > On Tue, 30 Oct 2018 at 17:19, Rob Clark wrote: > > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov > > wrote: > > > > > > NOTE: if bisecting a build error takes you hear, try a clean build. > > > > > There are a bunch of ways things can go w

Re: [Freedreno] [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

2018-10-30 Thread Emil Velikov
On Tue, 30 Oct 2018 at 17:19, Rob Clark wrote: > On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov > wrote: > > > > NOTE: if bisecting a build error takes you hear, try a clean build. > > > > There are a bunch of ways things can go wrong if you still have > > > > libdrm_freedreno cflags. > > > > >

Re: [Freedreno] [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

2018-10-30 Thread Rob Clark
On Tue, Oct 30, 2018 at 11:27 AM Emil Velikov wrote: > > On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote: > > > > On Tuesday, 2018-10-23 10:49:26 -0400, > > mesa-dev-boun...@lists.freedesktop.org wrote: > > > In the pursuit of lowering driver overhead, it became clear that some > > > amount o

[Freedreno] [PATCH v2 3/3] drm/msm: dpu: Make legacy cursor updates asynchronous

2018-10-30 Thread Sean Paul
From: Sean Paul This patch sprinkles a few async/legacy_cursor_update checks through commit to ensure that cursor updates aren't blocked on vsync. There are 2 main components to this, the first is that we don't want to wait_for_commit_done in msm_atomic before returning from atomic_complete. The

[Freedreno] [PATCH v2 2/3] drm/msm: dpu: Only check flush register against pending flushes

2018-10-30 Thread Sean Paul
From: Sean Paul There exists a case where a flush of a plane/dma may have been triggered & started from an async commit. If that plane/dma is subsequently disabled by the next commit, the flush register will continue to hold the flush bit for the disabled plane. Since the bit remains active, pend

[Freedreno] [PATCH v2 1/3] drm/msm: dpu: Mask inactive pending flushes

2018-10-30 Thread Sean Paul
From: Sean Paul This patch masks any pending flushes which have not been latched for a commit. This will catch the case where an asynchronous update is nullified by a disable in the same frame. Changes in v2: - Added to the set Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw

Re: [Freedreno] [Mesa-dev] [RFC] freedreno: import libdrm_freedreno + redesign submit

2018-10-30 Thread Emil Velikov
On Thu, 25 Oct 2018 at 10:32, Eric Engestrom wrote: > > On Tuesday, 2018-10-23 10:49:26 -0400, mesa-dev-boun...@lists.freedesktop.org > wrote: > > In the pursuit of lowering driver overhead, it became clear that some > > amount of redesign of how libdrm_freedreno constructs the submit ioctl > > w