Re: [Freedreno] [PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-05 Thread Rob Clark
On Tue, Feb 4, 2020 at 9:42 AM Jordan Crouse wrote: > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a > universal GBIF un-halt into a6xx_start(). This can cause problems for > a630 targets which do not use GBIF and might have access protection > enabled on the region now occ

Re: [Freedreno] [PATCH] drm/msm/a6xx: Update the GMU bus tables for sc7180

2020-02-05 Thread Rob Clark
On Wed, Feb 5, 2020 at 9:01 AM Jordan Crouse wrote: > > Fixup the GMU bus table values for the sc7180 target. > > Signed-off-by: Jordan Crouse I suspect that we'll need to figure out a better way to get these values from the interconnect driver in the long run, esp. since there are several diffe

Re: [Freedreno] [PATCH v2] drm/msm: Fix a6xx GMU shutdown sequence

2020-02-05 Thread Rob Clark
On Wed, Feb 5, 2020 at 12:48 PM Jordan Crouse wrote: > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") missed > updating the VBIF flush in a6xx_gmu_shutdown and instead > inserted the new sequence into a6xx_pm_suspend along with a redundant > GMU idle. > > Move a6xx_bus_clear_pendin

[Freedreno] [PATCH v2] drm/msm: Fix a6xx GMU shutdown sequence

2020-02-05 Thread Jordan Crouse
Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") missed updating the VBIF flush in a6xx_gmu_shutdown and instead inserted the new sequence into a6xx_pm_suspend along with a redundant GMU idle. Move a6xx_bus_clear_pending_transactions to a6xx_gmu.c and use it in the appropriate place in

Re: [Freedreno] [PATCH] drm/msm/a6xx: Remove unneeded GBIF unhalt

2020-02-05 Thread John Stultz
On Tue, Feb 4, 2020 at 9:42 AM Jordan Crouse wrote: > > Commit e812744c5f95 ("drm: msm: a6xx: Add support for A618") added a > universal GBIF un-halt into a6xx_start(). This can cause problems for > a630 targets which do not use GBIF and might have access protection > enabled on the region now occ

Re: [Freedreno] [PATCH v4 3/3] arm64: dts: qcom: sc7180: Add A618 gpu dt blob

2020-02-05 Thread Doug Anderson
Hi, On Tue, Feb 4, 2020 at 11:02 PM Sharat Masetty wrote: > > + power-domains = <&gpucc CX_GDSC>, <&gpucc GX_GDSC>; I should note that this is going to be a PITA to land because the patch adding "GX_GDSC" should technically land in the "clk" tree. Without extra work that's

Re: [Freedreno] [PATCH v4 1/3] dt-bindings: clk: qcom: Add support for GPU GX GDSCR

2020-02-05 Thread Doug Anderson
Hi, On Tue, Feb 4, 2020 at 11:01 PM Sharat Masetty wrote: > > From: Taniya Das > > In the cases where the GPU SW requires to use the GX GDSCR add > support for the same. > > Signed-off-by: Taniya Das Since you are re-posting Taniya's patch you need to add your own Signed-off-by as per kernel p

Re: [Freedreno] [PATCH v4 2/3] clk: qcom: gpucc: Add support for GX GDSC for SC7180

2020-02-05 Thread Doug Anderson
Hi, On Tue, Feb 4, 2020 at 11:02 PM Sharat Masetty wrote: > > From: Taniya Das > > Most of the time the CPU should not be touching the GX domain on the > GPU > except for a very special use case when the CPU needs to force the GX Really weird word-wrapping? You've also indented your whole c

Re: [Freedreno] [PATCH v4 3/3] arm64: dts: qcom: sc7180: Add A618 gpu dt blob

2020-02-05 Thread Doug Anderson
Hi, On Tue, Feb 4, 2020 at 11:02 PM Sharat Masetty wrote: > > This patch adds the required dt nodes and properties > to enabled A618 GPU. > > Signed-off-by: Sharat Masetty > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 102 > +++ > 1 file changed, 102 insertions

[Freedreno] [PATCH] drm/msm/a6xx: Update the GMU bus tables for sc7180

2020-02-05 Thread Jordan Crouse
Fixup the GMU bus table values for the sc7180 target. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 85 --- 1 file changed, 60 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/adr

Re: [Freedreno] [PATCHv3 1/2] dt-bindings: display: add visionox rm69299 panel variant

2020-02-05 Thread Rob Herring
On Wed, 5 Feb 2020 18:36:29 +0530, Harigovindan P wrote: > Add bindings for visionox rm69299 panel. > > Signed-off-by: Harigovindan P > --- > > Changes in v1: > - Added a compatible string to support sc7180 panel version. > Changes in v2: > - Removed unwanted properties from descrip

[Freedreno] [PATCHv3 2/2] drm/panel: add support for rm69299 visionox panel driver

2020-02-05 Thread Harigovindan P
Add support for Visionox panel driver. Signed-off-by: Harigovindan P --- Changes in v1: - Split out panel driver patch from dsi config changes(Rob Clark). - Remove unrelated code(Stephen Boyd). - Remove static arrays to make regulator setup open coded in probe(Ste

[Freedreno] [PATCHv3 0/2] Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel

2020-02-05 Thread Harigovindan P
Adding support for visionox rm69299 panel driver and adding bindings for the same panel. Harigovindan P (2): dt-bindings: display: add visionox rm69299 panel variant drm/panel: add support for rm69299 visionox panel driver .../bindings/display/visionox,rm69299.yaml | 109 ++ dri

[Freedreno] [PATCHv3 1/2] dt-bindings: display: add visionox rm69299 panel variant

2020-02-05 Thread Harigovindan P
Add bindings for visionox rm69299 panel. Signed-off-by: Harigovindan P --- Changes in v1: - Added a compatible string to support sc7180 panel version. Changes in v2: - Removed unwanted properties from description. - Creating source files without execute permissions(Rob He