Re: [Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-06-04 Thread Jordan Crouse
On Thu, Jun 04, 2020 at 03:38:28PM -0700, Rob Clark wrote: > On Thu, Jun 4, 2020 at 3:02 PM Jordan Crouse wrote: > > > > On Thu, Jun 04, 2020 at 02:27:21PM -0700, Rob Clark wrote: > > > On Thu, Jun 4, 2020 at 1:57 PM Jordan Crouse > > > wrote: > > > > > > > > Set the qcom,adreno-smmu compatible

Re: [Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-06-04 Thread Rob Clark
On Thu, Jun 4, 2020 at 3:02 PM Jordan Crouse wrote: > > On Thu, Jun 04, 2020 at 02:27:21PM -0700, Rob Clark wrote: > > On Thu, Jun 4, 2020 at 1:57 PM Jordan Crouse wrote: > > > > > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > > > split pagetables. > > > > > >

Re: [Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-06-04 Thread Jordan Crouse
On Thu, Jun 04, 2020 at 02:27:21PM -0700, Rob Clark wrote: > On Thu, Jun 4, 2020 at 1:57 PM Jordan Crouse wrote: > > > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > > split pagetables. > > > > Signed-off-by: Jordan Crouse > > --- > > > >

Re: [Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-06-04 Thread Rob Clark
On Thu, Jun 4, 2020 at 1:57 PM Jordan Crouse wrote: > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables. > > Signed-off-by: Jordan Crouse > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

[Freedreno] [PATCH v7 6/6] arm6: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-06-04 Thread Jordan Crouse
Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable split pagetables. Signed-off-by: Jordan Crouse --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi

[Freedreno] [PATCH v7 4/6] iommu/arm-smmu: Add implementation for the adreno GPU SMMU

2020-06-04 Thread Jordan Crouse
Add a special implementation for the SMMU attached to most Adreno GPU target triggered from the qcom,adreno-gpu-smmu compatible string. When selected the driver will attempt to enable split pagetables. Signed-off-by: Jordan Crouse --- drivers/iommu/arm-smmu-impl.c | 5 -

[Freedreno] [PATCH v7 2/6] iommu/arm-smmu: Add support for split pagetables

2020-06-04 Thread Jordan Crouse
Enable TTBR1 for a context bank if IO_PGTABLE_QUIRK_ARM_TTBR1 is selected by the io-pgtable configuration. Signed-off-by: Jordan Crouse --- drivers/iommu/arm-smmu.c | 21 - drivers/iommu/arm-smmu.h | 25 +++-- 2 files changed, 35 insertions(+), 11

[Freedreno] [PATCH v7 1/6] iommu/arm-smmu: Pass io-pgtable config to implementation specific function

2020-06-04 Thread Jordan Crouse
Construct the io-pgtable config before calling the implementation specific init_context function and pass it so the implementation specific function can get a chance to change it before the io-pgtable is created. Signed-off-by: Jordan Crouse --- drivers/iommu/arm-smmu-impl.c | 3 ++-

[Freedreno] [PATCH v7 3/6] dt-bindings: arm-smmu: Add compatible string for Adreno GPU SMMU

2020-06-04 Thread Jordan Crouse
Every Qcom Adreno GPU has an embedded SMMU for its own use. These devices depend on unique features such as split pagetables, different stall/halt requirements and other settings. Identify them with a compatible string so that they can be identified in the arm-smmu implementation specific code.

[Freedreno] [PATCH v7 0/6] iommu/arm-smmu: Enable split pagetable support

2020-06-04 Thread Jordan Crouse
Another iteration of the split-pagetable support for arm-smmu and the Adreno GPU SMMU. After email discussions [1] we opted to make a arm-smmu implementation for specifically for the Adreno GPU and use that to enable split pagetable support and later other implementation specific bits that we

[Freedreno] [PATCH v7 5/6] drm/msm: Set the global virtual address range from the IOMMU domain

2020-06-04 Thread Jordan Crouse
Use the aperture settings from the IOMMU domain to set up the virtual address range for the GPU. This allows us to transparently deal with IOMMU side features (like split pagetables). Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 13 +++--

Re: [Freedreno] [PATCH v6] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-04 Thread Doug Anderson
Hi, On Thu, Jun 4, 2020 at 6:20 AM Kalyan Thota wrote: > > -#ifdef CONFIG_PM > -static int msm_runtime_suspend(struct device *dev) > +#ifdef CONFIG_PM_SLEEP > +static int msm_pm_suspend(struct device *dev) > { > - struct drm_device *ddev = dev_get_drvdata(dev); > - struct

Re: [Freedreno] [v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-04 Thread Sam Ravnborg
Hi Harigovindan On Thu, Jun 04, 2020 at 04:04:38PM +0530, Harigovindan P wrote: > ti-sn65dsi86 bridge is enumerated as a runtime device. > > Adding sleep ops to force runtime_suspend when PM suspend is > requested on the device. Patch looks correct - but could you please explain why it is

[Freedreno] [PATCH v6] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-04 Thread Kalyan Thota
"The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime devices. When suspend is triggered, PM core adds a refcount on all the devices and calls device suspend,

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-04 Thread kalyan_t
On 2020-05-28 03:41, Doug Anderson wrote: Hi, On Fri, May 15, 2020 at 9:37 AM Doug Anderson wrote: Hi, On Fri, May 15, 2020 at 5:06 AM wrote: > > On 2020-05-14 21:47, Doug Anderson wrote: > > Hi, > > > > On Fri, May 1, 2020 at 6:31 AM Kalyan Thota > > wrote: > >> > >> "The PM core always

[Freedreno] [v2] drm/bridge: ti-sn65dsi86: ensure bridge suspend happens during PM sleep

2020-06-04 Thread Harigovindan P
ti-sn65dsi86 bridge is enumerated as a runtime device. Adding sleep ops to force runtime_suspend when PM suspend is requested on the device. Signed-off-by: Harigovindan P --- Changes in v2: - Include bridge name in the commit message and remove dependent patchwork link from the