Re: [Freedreno] [PATCH v2 1/2] drm/msm: Fix premature purging of BO

2020-09-23 Thread Rob Clark
On Wed, Sep 23, 2020 at 11:28 AM Akhil P Oommen wrote: > > On 9/23/2020 8:20 PM, Jordan Crouse wrote: > > On Tue, Sep 22, 2020 at 08:25:26PM +0530, Akhil P Oommen wrote: > >> In the case where we have a back-to-back submission that shares the same > >> BO, this BO will be prematurely moved to

[Freedreno] [PATCH] drm/msm/dp: fix incorrect function prototype of dp_debug_get()

2020-09-23 Thread Abhinav Kumar
Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning. Fixes: f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/") Reported-by: kernel test robot Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.h |

Re: [Freedreno] [PATCH v2 1/2] drm/msm: Fix premature purging of BO

2020-09-23 Thread Akhil P Oommen
On 9/23/2020 8:20 PM, Jordan Crouse wrote: On Tue, Sep 22, 2020 at 08:25:26PM +0530, Akhil P Oommen wrote: In the case where we have a back-to-back submission that shares the same BO, this BO will be prematurely moved to inactive_list while retiring the first submit. But it will be still part

Re: [Freedreno] [PATCHv5 5/6] iommu: arm-smmu-impl: Use table to list QCOM implementations

2020-09-23 Thread Robin Murphy
On 2020-09-22 07:18, Sai Prakash Ranjan wrote: Use table and of_match_node() to match qcom implementation instead of multiple of_device_compatible() calls for each QCOM SMMU implementation. Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 12 1

Re: [Freedreno] [PATCH v2] drm/msm/a6xx: Fix a size determination in a6xx_get_indexed_registers()

2020-09-23 Thread Jordan Crouse
On Mon, Sep 14, 2020 at 10:29:49AM +0800, Zhenzhong Duan wrote: > It's allocating an array of a6xx_gpu_state_obj structure rather than > its pointers. > > Fixes: d6852b4b2d01 ("drm/msm/a6xx: Track and manage a6xx state memory") > Signed-off-by: Zhenzhong Duan Reviewed-by: Jordan Crouse > --- >

Re: [Freedreno] [PATCHv5 4/6] drm/msm/a6xx: Add support for using system cache(LLC)

2020-09-23 Thread Jordan Crouse
On Tue, Sep 22, 2020 at 11:48:17AM +0530, Sai Prakash Ranjan wrote: > From: Sharat Masetty > > The last level system cache can be partitioned to 32 different > slices of which GPU has two slices preallocated. One slice is > used for caching GPU buffers and the other slice is used for > caching

[Freedreno] [PATCH v3 12/22] drm/pl111: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in pl111. The only exception is gem_prime_mmap, which is non-trivial to convert. v2: * use

Re: [Freedreno] [PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Lucas Stach
On Mi, 2020-09-23 at 12:21 +0200, Thomas Zimmermann wrote: > GEM object functions deprecate several similar callback interfaces in > struct drm_driver. This patch replaces the per-driver callbacks with > per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, > which is

Re: [Freedreno] [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Laurentiu Palcu
Hi Thomas, On Wed, Sep 23, 2020 at 12:21:44PM +0200, Thomas Zimmermann wrote: > The i.MX DCSS driver uses CMA helpers with default callback functions. > Initialize the driver structure with the rsp CMA helper macro. The > driver is being converted to use GEM object functions as part of > this

[Freedreno] [PATCH v3 19/22] drm/vkms: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vkms. Signed-off-by: Thomas Zimmermann Reviewed-by: Melissa Wen --- drivers/gpu/drm/vkms/vkms_drv.c | 8

[Freedreno] [PATCH v3 11/22] drm/omapdrm: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in omapdrm. v2: * make omap_gem_free_object() static (Tomi) Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart

[Freedreno] [PATCH v3 20/22] drm/xen: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in xen. The only exception is gem_prime_mmap, which is non-trivial to convert. v2: * convert xen_drm_drv_free_object_unlocked()

[Freedreno] [PATCH v3 10/22] drm/nouveau: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in nouveau. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_drm.c | 9 -

[Freedreno] [PATCH v3 22/22] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver

2020-09-23 Thread Thomas Zimmermann
Several GEM and PRIME callbacks have been deprecated in favor of per-instance GEM object functions. Remove the callbacks as they are now unused. The only exception is .gem_prime_mmap, which is still in use by several drivers. What is also gone is gem_vm_ops in struct drm_driver. All drivers now

[Freedreno] [PATCH v3 15/22] drm/tegra: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in tegra. Signed-off-by: Thomas Zimmermann Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 4

[Freedreno] [PATCH v3 00/22] Convert all remaining drivers to GEM object functions

2020-09-23 Thread Thomas Zimmermann
The GEM and PRIME related callbacks in struct drm_driver are deprecated in favor of GEM object functions in struct drm_gem_object_funcs. This patchset converts the remaining drivers to object functions and removes most of the obsolete interfaces. Version 3 of this patchset mostly fixes

[Freedreno] [PATCH v3 02/22] drm/armada: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in armada. Signed-off-by: Thomas Zimmermann Acked-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 3 ---

[Freedreno] [PATCH v3 17/22] drm/vgem: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vgem. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Melissa

[Freedreno] [PATCH v3 18/22] drm/virtgpu: Set PRIME export function in struct drm_gem_object_funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces virtgpu's per-driver PRIME export function with a per-object function. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.c| 1 -

[Freedreno] [PATCH v3 01/22] drm/amdgpu: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in amdgpu. The only exception is gem_prime_mmap, which is non-trivial to convert. v3: * remove amdgpu_object.c from patch

[Freedreno] [PATCH v3 04/22] drm/exynos: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in exynos. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel

[Freedreno] [PATCH v3 03/22] drm/etnaviv: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in etnaviv. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by:

[Freedreno] [PATCH v3 08/22] drm/mediatek: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in mediatek. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by:

[Freedreno] [PATCH v3 21/22] drm/xlnx: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Thomas Zimmermann
The xlnx driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .dumb_destroy and .gem_prime_import, were initialized to their default

[Freedreno] [PATCH v3 06/22] drm/i915: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in i915. v2: * move object-function instance to i915_gem_object.c (Jani) Signed-off-by: Thomas Zimmermann Reviewed-by: Tvrtko

[Freedreno] [PATCH v3 05/22] drm/gma500: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in gma500. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/gma500/framebuffer.c | 2 ++

[Freedreno] [PATCH v3 16/22] drm/vc4: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in vc4. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Eric

[Freedreno] [PATCH v3 13/22] drm/radeon: Introduce GEM object functions

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in radeon. v2: * move object-function instance to radeon_gem.c (Christian) * set callbacks in

[Freedreno] [PATCH v3 09/22] drm/msm: Introduce GEM object funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in msm. The only exception is gem_prime_mmap, which is non-trivial to convert. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel

[Freedreno] [PATCH v3 14/22] drm/rockchip: Convert to drm_gem_object_funcs

2020-09-23 Thread Thomas Zimmermann
GEM object functions deprecate several similar callback interfaces in struct drm_driver. This patch replaces the per-driver callbacks with per-instance callbacks in rockchip. The only exception is gem_prime_mmap, which is non-trivial to convert. v3: * update documentation Signed-off-by:

[Freedreno] [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

2020-09-23 Thread Thomas Zimmermann
The i.MX DCSS driver uses CMA helpers with default callback functions. Initialize the driver structure with the rsp CMA helper macro. The driver is being converted to use GEM object functions as part of this change. Two callbacks, .gem_prime_export and .gem_prime_import, were initialized to their

Re: [Freedreno] [PATCH v2 2/2] drm/msm: Leave inuse count intact on map failure

2020-09-23 Thread Jordan Crouse
On Tue, Sep 22, 2020 at 08:25:27PM +0530, Akhil P Oommen wrote: > Leave the inuse count intact on map failure to keep the accounting > accurate. > > Signed-off-by: Akhil P Oommen Reviewed-by: Jordan Crouse > --- > drivers/gpu/drm/msm/msm_gem_vma.c | 4 +++- > 1 file changed, 3 insertions(+),

Re: [Freedreno] [PATCH v2 1/2] drm/msm: Fix premature purging of BO

2020-09-23 Thread Jordan Crouse
On Tue, Sep 22, 2020 at 08:25:26PM +0530, Akhil P Oommen wrote: > In the case where we have a back-to-back submission that shares the same > BO, this BO will be prematurely moved to inactive_list while retiring the > first submit. But it will be still part of the second submit which is > being

Re: [Freedreno] [PATCH] drm/msm: Remove depends on interconnect

2020-09-23 Thread Jordan Crouse
On Wed, Sep 16, 2020 at 02:07:06PM +0300, Georgi Djakov wrote: > The dependency on interconnect in the Kconfig was introduced to avoid > the case of interconnect=m and driver=y, but the interconnect framework > has been converted from tristate to bool now. Remove the dependency as > the framework

Re: [Freedreno] [PATCH v3 00/22] Convert all remaining drivers to GEM object functions

2020-09-23 Thread Christian König
Feel free to add an Acked-by: Christian König to all patches which I haven't explicitly reviewed. I would say we should just push this to drm-misc-next now. Thanks for the nice cleanup, Christian. Am 23.09.20 um 12:21 schrieb Thomas Zimmermann: The GEM and PRIME related callbacks in struct