Re: [Freedreno] [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-02 15:09:19) > Connection state is set incorrectly happen at either failure of link train > or cable plugged in while suspended. This patch fixes these problems. > This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. > > Signed-off-by: Kuogee Hsieh Any

[Freedreno] [PATCH] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-02 Thread Kuogee Hsieh
Connection state is set incorrectly happen at either failure of link train or cable plugged in while suspended. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 52

Re: [Freedreno] [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 11:54 AM Daniel Vetter wrote: > > On Fri, Oct 02, 2020 at 10:22:42AM -0700, Rob Clark wrote: > > On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > > > > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar > > > wrote: > > > > > > > > Add support to capture the drm

Re: [Freedreno] [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Daniel Vetter
On Fri, Oct 02, 2020 at 10:22:42AM -0700, Rob Clark wrote: > On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar > > wrote: > > > > > > Add support to capture the drm atomic state snapshot which > > > can then be wired up with the

Re: [Freedreno] [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Rob Clark
On Fri, Oct 2, 2020 at 12:36 AM Daniel Vetter wrote: > > On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar wrote: > > > > Add support to capture the drm atomic state snapshot which > > can then be wired up with the devcoredump of the relevant display > > errors to give useful information to debug the

Re: [Freedreno] [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-02 Thread Jonathan Marek
On 10/2/20 3:53 AM, Christoph Hellwig wrote: @@ -8,6 +8,7 @@ #include #include #include +#include NAK, dma-noncoherent.h is not for driver use. And will in fact go away in 5.10. Not actually used, so can be removed. #include @@ -808,6 +809,20 @@ int

Re: [Freedreno] [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-02 Thread Christoph Hellwig
> @@ -8,6 +8,7 @@ > #include > #include > #include > +#include NAK, dma-noncoherent.h is not for driver use. And will in fact go away in 5.10. > > #include > > @@ -808,6 +809,20 @@ int msm_gem_cpu_fini(struct drm_gem_object *obj) > return 0; > } > > +void

Re: [Freedreno] [RFC PATCH] drm: add support for taking drm atomic state snapshot

2020-10-02 Thread Daniel Vetter
On Fri, Oct 2, 2020 at 3:47 AM Abhinav Kumar wrote: > > Add support to capture the drm atomic state snapshot which > can then be wired up with the devcoredump of the relevant display > errors to give useful information to debug the issues. > > Since the devcoredump is read by usermode and it is