Re: [Freedreno] [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-13 Thread Daniel Vetter
On Mon, Oct 12, 2020 at 08:07:38AM -0700, Rob Clark wrote: > On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > > > On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Any cross-device sync use-cases *must* use explicit sync. And if there > > > is o

Re: [Freedreno] [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-13 Thread Robin Murphy
On 2020-10-07 07:25, Christoph Hellwig wrote: On Tue, Oct 06, 2020 at 09:19:32AM -0400, Jonathan Marek wrote: One example why drm/msm can't use DMA API is multiple page table support (that is landing in 5.10), which is something that definitely couldn't work with DMA API. Another one is being a

Re: [Freedreno] [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread Akhil P Oommen
On 10/12/2020 11:10 PM, m...@chromium.org wrote: On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oommen wrote: On 10/10/2020 12:06 AM, m...@chromium.org wrote: Hi Akhil, On Thu, Oct 08, 2020 at 10:39:07PM +0530, Akhil P Oommen wrote: Register GPU as a devfreq cooling device so that it can b

Re: [Freedreno] [PATCH 2/3] drm/msm: add DRM_MSM_GEM_SYNC_CACHE for non-coherent cache maintenance

2020-10-13 Thread Rob Clark
On Tue, Oct 13, 2020 at 6:42 AM Robin Murphy wrote: > > On 2020-10-07 07:25, Christoph Hellwig wrote: > > On Tue, Oct 06, 2020 at 09:19:32AM -0400, Jonathan Marek wrote: > >> One example why drm/msm can't use DMA API is multiple page table support > >> (that is landing in 5.10), which is something

Re: [Freedreno] [PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-13 Thread Rob Clark
On Tue, Oct 13, 2020 at 4:08 AM Daniel Vetter wrote: > > On Mon, Oct 12, 2020 at 08:07:38AM -0700, Rob Clark wrote: > > On Mon, Oct 12, 2020 at 7:40 AM Daniel Vetter wrote: > > > > > > On Sun, Oct 11, 2020 at 07:09:49PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Any cross-de

Re: [Freedreno] [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread mka
On Tue, Oct 13, 2020 at 07:23:34PM +0530, Akhil P Oommen wrote: > On 10/12/2020 11:10 PM, m...@chromium.org wrote: > > On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oommen wrote: > > > On 10/10/2020 12:06 AM, m...@chromium.org wrote: > > > > Hi Akhil, > > > > > > > > On Thu, Oct 08, 2020 at 10

Re: [Freedreno] [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread Akhil P Oommen
On 10/13/2020 11:10 PM, m...@chromium.org wrote: On Tue, Oct 13, 2020 at 07:23:34PM +0530, Akhil P Oommen wrote: On 10/12/2020 11:10 PM, m...@chromium.org wrote: On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oommen wrote: On 10/10/2020 12:06 AM, m...@chromium.org wrote: Hi Akhil, On Thu,

[Freedreno] [PATCH v4] drm/msm/dp: return correct connection status after suspend

2020-10-13 Thread Kuogee Hsieh
During suspend, dp host controller and hpd block are disabled due to both ahb and aux clock are disabled. Therefore hpd plug/unplug interrupts will not be generated. At dp_pm_resume(), reinitialize both dp host controller and hpd block so that hpd plug/unplug interrupts will be generated and handle

[Freedreno] [PATCH v3] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-13 Thread Kuogee Hsieh
Connection state is not set correctly happen when either failure of link train due to cable unplugged in the middle of aux channel reading or cable plugged in while in suspended state. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Changes in V2: -

Re: [Freedreno] [PATCH v4] drm/msm/dp: return correct connection status after suspend

2020-10-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-13 16:35:22) > During suspend, dp host controller and hpd block are disabled due to > both ahb and aux clock are disabled. Therefore hpd plug/unplug interrupts > will not be generated. At dp_pm_resume(), reinitialize both dp host > controller and hpd block so that hpd

Re: [Freedreno] [PATCH v3] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-10-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-13 16:35:44) > Connection state is not set correctly happen when either failure of link > train due to cable unplugged in the middle of aux channel reading or > cable plugged in while in suspended state. This patch fixes these problems. > This patch also replace ST_SUS

Re: [Freedreno] [2/2] drm/msm: Add support for GPU cooling

2020-10-13 Thread mka
On Wed, Oct 14, 2020 at 12:51:55AM +0530, Akhil P Oommen wrote: > On 10/13/2020 11:10 PM, m...@chromium.org wrote: > > On Tue, Oct 13, 2020 at 07:23:34PM +0530, Akhil P Oommen wrote: > > > On 10/12/2020 11:10 PM, m...@chromium.org wrote: > > > > On Mon, Oct 12, 2020 at 07:03:51PM +0530, Akhil P Oom