Re: [Freedreno] [PATCH] drm/msm/atomic: Drop per-CRTC locks in reverse order

2020-10-20 Thread abhinavk
On 2020-10-20 15:26, Rob Clark wrote: From: Rob Clark lockdep dislikes seeing locks unwound in a non-nested fashion. Fixes: 37c2016e3608 ("drm/msm: Fix race condition in msm driver with async layer updates") Signed-off-by: Rob Clark Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_a

[Freedreno] [PATCH] drm/msm/atomic: Drop per-CRTC locks in reverse order

2020-10-20 Thread Rob Clark
From: Rob Clark lockdep dislikes seeing locks unwound in a non-nested fashion. Fixes: 37c2016e3608 ("drm/msm: Fix race condition in msm driver with async layer updates") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_atomic.c | 2 +- drivers/gpu/drm/msm/msm_kms.h| 4 include/

Re: [Freedreno] [PATCH] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-10-20 Thread Stephen Boyd
Quoting Kuogee Hsieh (2020-10-20 09:59:59) > No need to check LINK_STATuS_UPDATED bit before LINK_STATUS_UPDATED? > return 6 bytes of link status during link training. Why? > This patch also fix phy compliance test link rate > conversion error. How? > > Signed-off-by: Kuogee Hsieh > --- An

[Freedreno] [PATCH v3] drm/msm/dp: add opp_table corner voting support base on dp_ink_clk rate

2020-10-20 Thread Kuogee Hsieh
Set link rate by using OPP set rate api so that CX level will be set accordingly based on the link rate. Changes in v2: -- remove dev from dp_ctrl_put() parameters -- Add more information to commit message Changes in v3: -- return when dev_pm_opp_set_clkname() failed Signed-off-by: Kuogee Hsieh

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Rob Clark
On Tue, Oct 20, 2020 at 11:14 AM Daniel Vetter wrote: > > On Tue, Oct 20, 2020 at 7:23 PM Rob Clark wrote: > > > > On Tue, Oct 20, 2020 at 10:02 AM Daniel Vetter wrote: > > > > > > On Tue, Oct 20, 2020 at 5:08 PM Rob Clark wrote: > > > > > > > > On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wr

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 7:23 PM Rob Clark wrote: > > On Tue, Oct 20, 2020 at 10:02 AM Daniel Vetter wrote: > > > > On Tue, Oct 20, 2020 at 5:08 PM Rob Clark wrote: > > > > > > On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wrote: > > > > > > > > On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote:

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Rob Clark
On Tue, Oct 20, 2020 at 10:02 AM Daniel Vetter wrote: > > On Tue, Oct 20, 2020 at 5:08 PM Rob Clark wrote: > > > > On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wrote: > > > > > > On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote: > > > > > > > > On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wro

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 5:08 PM Rob Clark wrote: > > On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wrote: > > > > On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote: > > > > > > On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wrote: > > > > > > > > On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark

[Freedreno] [PATCH] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-10-20 Thread Kuogee Hsieh
No need to check LINK_STATuS_UPDATED bit before return 6 bytes of link status during link training. This patch also fix phy compliance test link rate conversion error. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 20 ++-- drivers/gpu/drm/msm/dp/dp_link.c | 2

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Rob Clark
On Tue, Oct 20, 2020 at 7:29 AM Daniel Vetter wrote: > > On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote: > > > > On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wrote: > > > > > > On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > In particular, co

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 4:01 PM Rob Clark wrote: > > On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wrote: > > > > On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > In particular, converting the async atomic commit (for cursor updates, > > > etc) to SCHE

Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Rob Clark
On Tue, Oct 20, 2020 at 4:24 AM Viresh Kumar wrote: > > On 20-10-20, 12:56, Daniel Vetter wrote: > > Yeah that's bad practice. Generally you shouldn't need to hold locks > > in setup/teardown code, since there's no other thread which can > > possible hold a reference to anything your touching anym

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Rob Clark
On Tue, Oct 20, 2020 at 1:24 AM Daniel Vetter wrote: > > On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > In particular, converting the async atomic commit (for cursor updates, > > etc) to SCHED_FIFO kthread_worker helps with some cases where we > > wouldn't

Re: [Freedreno] [PATCH 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-20 Thread Akhil P Oommen
On 10/19/2020 8:29 PM, Jordan Crouse wrote: On Mon, Oct 19, 2020 at 06:49:18PM +0530, Akhil P Oommen wrote: On targets with a6xx gpu, there is a duplicate gpu icc node listed in the interconnect summary. On these targets, calling This first sentence is confusing to me. I think the following fe

Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 1:24 PM Viresh Kumar wrote: > > On 20-10-20, 12:56, Daniel Vetter wrote: > > Yeah that's bad practice. Generally you shouldn't need to hold locks > > in setup/teardown code, since there's no other thread which can > > possible hold a reference to anything your touching anym

Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Viresh Kumar
On 20-10-20, 12:56, Daniel Vetter wrote: > Yeah that's bad practice. Generally you shouldn't need to hold locks > in setup/teardown code, since there's no other thread which can > possible hold a reference to anything your touching anymore. Ofc > excluding quickly grabbing/dropping a lock to insert

Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Daniel Vetter
On Tue, Oct 20, 2020 at 11:07 AM Viresh Kumar wrote: > > On 12-10-20, 08:43, Rob Clark wrote: > > On Mon, Oct 12, 2020 at 7:35 AM Daniel Vetter wrote: > > > > > > On Sun, Oct 11, 2020 at 07:09:34PM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Unfortunately, due to an dev_pm_op

Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-20 Thread Viresh Kumar
On 12-10-20, 08:43, Rob Clark wrote: > On Mon, Oct 12, 2020 at 7:35 AM Daniel Vetter wrote: > > > > On Sun, Oct 11, 2020 at 07:09:34PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Unfortunately, due to an dev_pm_opp locking interaction with > > > mm->mmap_sem, we need to do pm get be

Re: [Freedreno] [PATCH 0/3] drm/msm: kthread_worker conversion

2020-10-20 Thread Daniel Vetter
On Mon, Oct 19, 2020 at 02:10:50PM -0700, Rob Clark wrote: > From: Rob Clark > > In particular, converting the async atomic commit (for cursor updates, > etc) to SCHED_FIFO kthread_worker helps with some cases where we > wouldn't manage to flush the updates within the 1ms-before-vblank > deadline