Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-03 Thread Viresh Kumar
On 03-11-20, 08:50, Rob Clark wrote: > sorry, it didn't apply cleanly (which I guess is due to some other > dependencies that need to be picked back to v5.4 product kernel), and > due to some other things I'm in middle of debugging I didn't have time > yet to switch to v5.10-rc or look at what

[Freedreno] [PATCH v2 0/2] cherry-pick miised DP related patches

2020-11-03 Thread Kuogee Hsieh
Cherry-pick two missed drm/msm/dp related patches to msm-next-staging Kuogee Hsieh (2): drm/msm/dp: return correct connection status after suspend drm/msm/dp: fixes wrong connection state caused by failure of link train drivers/gpu/drm/msm/dp/dp_catalog.c | 13 +++

[Freedreno] [PATCH v2 2/2] drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-11-03 Thread Kuogee Hsieh
Connection state is not set correctly happen when either failure of link train due to cable unplugged in the middle of aux channel reading or cable plugged in while in suspended state. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Changes in V2:

[Freedreno] [PATCH v2 1/2] drm/msm/dp: return correct connection status after suspend

2020-11-03 Thread Kuogee Hsieh
During suspend, dp host controller and hpd block are disabled due to both ahb and aux clock are disabled. Therefore hpd plug/unplug interrupts will not be generated. At dp_pm_resume(), reinitialize both dp host controller and hpd block so that hpd plug/unplug interrupts will be generated and

[Freedreno] [PATCH 1/3] FROMLIST: drm/msm/dp: return correct connection status after suspend

2020-11-03 Thread Kuogee Hsieh
At dp_pm_resume, reinitialize both dp host controller and hpd block so that hpd connection can be detected at realtime by reading hpd state status register. Also hpd plug interrupt can be generated accordingly. Changes in v2: -- use container_of to cast correct dp_display_private pointer at

[Freedreno] [PATCH 3/3] FROMLIST: drm/msm/dp: fixes wrong connection state caused by failure of link train

2020-11-03 Thread Kuogee Hsieh
Connection state is not set correctly happen when either failure of link train due to cable unplugged in the middle of aux channel reading or cable plugged in while in suspended state. This patch fixes these problems. This patch also replace ST_SUSPEND_PENDING with ST_DISPLAY_OFF. Changes in V2:

[Freedreno] [PATCH 0/3] cherry-pick missed patches to msm-next-staging

2020-11-03 Thread Kuogee Hsieh
cherry-pick 3 patches at chromeos-5.4 to msm-next-staging Kuogee Hsieh (2): FROMLIST: drm/msm/dp: return correct connection status after suspend FROMLIST: drm/msm/dp: fixes wrong connection state caused by failure of link train Stephen Boyd (1): FIXUP: FROMLIST: drm/msm/dp: return

[Freedreno] [PATCH 2/3] FIXUP: FROMLIST: drm/msm/dp: return correct connection status after suspend

2020-11-03 Thread Kuogee Hsieh
From: Stephen Boyd During suspend, dp host controller and hpd block are disabled due to both ahb and aux clock are disabled. Therefore hpd plug/unplug interrupts will not be generated. At dp_pm_resume(), reinitialize both dp host controller and hpd block so that hpd plug/unplug interrupts will

[Freedreno] [PATCH 3/3] drm/msm/dp: promote irq_hpd handle to handle link training correctly

2020-11-03 Thread Kuogee Hsieh
Some dongles require link training done at irq_hpd request instead of plugin request. This patch promote irq_hpd handler to handle link training and setup hpd_state correctly. Fixes: fdaf9a5e3c15 (drm/msm/dp: fixes wrong connection state caused by failure of link training) Signed-off-by: Kuogee

[Freedreno] [PATCH 2/3] drm/msm/dp: skip checking LINK_STATUS_UPDATED bit

2020-11-03 Thread Kuogee Hsieh
Some dongle will not clear LINK_STATUS_UPDATED bit after DPCD read which cause link training failed. This patch just read 6 bytes of DPCD link status from sink and return without checking LINK_STATUS_UPDATED bit. Only 8 bits are used to represent link rate at sinker DPCD. The really link rate is

[Freedreno] [PATCH 0/3] fix dp link training failed at irq_hpd request

2020-11-03 Thread Kuogee Hsieh
Some dongle require link training be done at irq_hpd request. This serial patches address the issues so that DP/HDMI display can be lit up properlly. This serial Patch also fixes clock stuck at "off" state error caused by previous link training failed. Kuogee Hsieh (3): drm/msm/dp: deinitialize

[Freedreno] [PATCH 1/3] drm/msm/dp: deinitialize mainlink if link training failed

2020-11-03 Thread Kuogee Hsieh
DP compo phy have to be enable to start link training. When link training failed phy need to be disabled so that next link traning can be proceed smoothly at next plug in. This patch de-initialize mainlink to disable phy if link training failed. This prevent system crash due to

Re: [Freedreno] [PATCH] drm/msm/dp: deinitialize mainlink if link training failedo

2020-11-03 Thread khsieh
On 2020-11-02 12:59, Stephen Boyd wrote: Quoting Kuogee Hsieh (2020-10-30 16:22:53) DP compo phy have to be enable to start link training. When link training failed phy need to be disabled so that next link trainng can be proceed smoothly at next plug in. This s/trainng/training/ patch de

Re: [Freedreno] [PATCH] drm/msm: a5xx: Make preemption reset case reentrant

2020-11-03 Thread Jordan Crouse
On Mon, Nov 02, 2020 at 09:02:25PM +0100, Marijn Suijten wrote: > nr_rings is reset to 1, but when this function is called for a second > (and third!) time nr_rings > 1 is false, thus the else case is entered > to set up a buffer for the RPTR shadow and consequently written to > RB_RPTR_ADDR,

Re: [Freedreno] [PATCH] drm/msm/dp: promote irq_hpd handle to handle link trainign correctly

2020-11-03 Thread khsieh
On 2020-11-02 11:29, Stephen Boyd wrote: Subject has a typo in "training". Quoting Kuogee Hsieh (2020-10-30 16:23:24) Some dongles, such as Apple, required link training done at irq_hpd s/required/require/ request instead of plugin request. This patch promote irq_hpd hanlder

Re: [Freedreno] [PATCH] drivers: drm: fix msm_drv.h warning

2020-11-03 Thread Rob Clark
Should be fixed by: https://patchwork.freedesktop.org/patch/397039/?series=83038=1 On Mon, Nov 2, 2020 at 7:44 PM dev god wrote: > > Hi > > fix implicit declaration of function error. > > >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: error: implicit > >> declaration of function

Re: [Freedreno] [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-03 Thread Rob Clark
On Mon, Nov 2, 2020 at 9:47 PM Viresh Kumar wrote: > > On 27-10-20, 17:05, Viresh Kumar wrote: > > It isn't that straight forward unfortunately, we need to make sure the > > table doesn't get allocated for the same device twice, so > > find+allocate needs to happen within a locked region. > > > >

[Freedreno] [PATCH] drivers: drm: fix msm_drv.h warning

2020-11-03 Thread dev god
Hi fix implicit declaration of function error. >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1229:7: error: implicit declaration of function 'msm_dp_display_pre_disable' [-Werror,-Wimplicit-function-declaration] if (msm_dp_display_pre_disable(priv->dp, drm_enc))

[Freedreno] [PATCH v2] drm/msm/dp: do not notify audio subsystem if sink doesn't support audio

2020-11-03 Thread Abhinav Kumar
For sinks that do not support audio, there is no need to notify audio subsystem of the connection event. This will make sure that audio routes only to the primary display when connected to such sinks. changes in v2: - Added fixes tag - Removed nested if condition and removed usage of global