[Freedreno] [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-01-25 Thread Stephen Boyd
Lockdep complains about an AA deadlock when rebooting the device. WARNING: possible recursive locking detected 5.4.91 #1 Not tainted reboot/5213 is trying to acquire lock: ff80d13391b0

[Freedreno] [PATCH] drm/msm/kms: Make a lock_class_key for each crtc mutex

2021-01-25 Thread Stephen Boyd
Lockdep complains about an AA deadlock when rebooting the device. WARNING: possible recursive locking detected 5.4.91 #1 Not tainted reboot/5213 is trying to acquire lock: ff80d13391b0

Re: [Freedreno] [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-25 Thread Ville Syrjälä
On Mon, Jan 25, 2021 at 11:52:18AM +0100, Maxime Ripard wrote: > Hi Ville, > > On Fri, Jan 22, 2021 at 02:15:07PM +0200, Ville Syrjälä wrote: > > On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > > > Some drivers are storing the plane->state pointer in atomic_update and > > >

Re: [Freedreno] [PATCH v2 08/11] drm: Rename plane->state variables in atomic update and disable

2021-01-25 Thread Maxime Ripard
Hi Ville, On Fri, Jan 22, 2021 at 02:15:07PM +0200, Ville Syrjälä wrote: > On Thu, Jan 21, 2021 at 05:35:33PM +0100, Maxime Ripard wrote: > > Some drivers are storing the plane->state pointer in atomic_update and > > atomic_disable in a variable simply called state, while the state passed > > as

Re: [Freedreno] [PATCH v2 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-01-25 Thread Maxime Ripard
Hi Ville, On Fri, Jan 22, 2021 at 02:07:22PM +0200, Ville Syrjälä wrote: > On Thu, Jan 21, 2021 at 05:35:31PM +0100, Maxime Ripard wrote: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_check hook, which would be the old > > plane