Re: [Freedreno] [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-04 Thread Stephen Boyd
Maybe subject could be "Ignore debugfs failures, fix indentation, fix logical error"? Quoting Abhinav Kumar (2021-03-04 17:31:52) > Fix the warnings reported by kbot across MSM DP driver. Which warnings? Can you include them? Or at least list the three things that are being fixed in this patch?

[Freedreno] [PATCH] drm/msm/dp: Fix warnings reported by kbot in DP driver

2021-03-04 Thread Abhinav Kumar
Fix the warnings reported by kbot across MSM DP driver. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_debug.c | 33 + drivers/gpu/drm/msm/dp/dp_hpd.c | 4 ++--

Re: [Freedreno] [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-04 Thread Rob Clark
On Thu, Mar 4, 2021 at 7:48 AM Robin Murphy wrote: > > On 2021-03-01 08:42, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig > > Moreso than the previous patch, where the feature is at least relatively > generic (note that there's a bunch of in-flight development around >

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Lukasz Luba
On 3/4/21 4:53 PM, Daniel Lezcano wrote: Hi Lukasz, thanks for commenting this patch, On 04/03/2021 14:47, Lukasz Luba wrote: Hi Daniel, On 3/4/21 12:50 PM, Daniel Lezcano wrote: Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Daniel Lezcano
On 04/03/2021 16:06, Chanwoo Choi wrote: > Hi Daniel, > > As Lukasz's comment, actually some devfreq devices like memory bus > might not affect the thermal critically. In the mainline, > there are four types devfreq as following: > 1. GPU > 2. UFS Storage > 3. DMC (Memory Controller) > 4. Memory

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Daniel Lezcano
Hi Lukasz, thanks for commenting this patch, On 04/03/2021 14:47, Lukasz Luba wrote: > Hi Daniel, > > On 3/4/21 12:50 PM, Daniel Lezcano wrote: >> Currently the default behavior is to manually having the devfreq >> backend to register themselves as a devfreq cooling device. >> >> There are no

Re: [Freedreno] [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-04 Thread Robin Murphy
On 2021-03-01 08:42, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Moreso than the previous patch, where the feature is at least relatively generic (note that there's a bunch of in-flight development around DOMAIN_ATTR_NESTING), I'm really not convinced that it's beneficial to

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Lukasz Luba
Hi Daniel, On 3/4/21 12:50 PM, Daniel Lezcano wrote: Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq cooling device. There are no so many and actually it makes more sense to register the devfreq device when adding it. Consequently,

[Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Daniel Lezcano
Currently the default behavior is to manually having the devfreq backend to register themselves as a devfreq cooling device. There are no so many and actually it makes more sense to register the devfreq device when adding it. Consequently, every devfreq becomes a cooling device like cpufreq is.

Re: [Freedreno] [PATCH 14/17] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-04 Thread Robin Murphy
On 2021-03-01 08:42, Christoph Hellwig wrote: Use explicit methods for setting and querying the information instead. Now that everyone's using iommu-dma, is there any point in bouncing this through the drivers at all? Seems like it would make more sense for the x86 drivers to reflect their

Re: [Freedreno] [PATCH] devfreq: Register devfreq as a cooling device

2021-03-04 Thread Chanwoo Choi
Hi Daniel, As Lukasz's comment, actually some devfreq devices like memory bus might not affect the thermal critically. In the mainline, there are four types devfreq as following: 1. GPU 2. UFS Storage 3. DMC (Memory Controller) 4. Memory bus like AMBA AXI I think that you can specify this

Re: [Freedreno] cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver

2021-03-04 Thread Joerg Roedel
On Mon, Mar 01, 2021 at 09:42:40AM +0100, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |2 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 85

[Freedreno] [v1] drm/msm/disp/dpu1: fix warning reported by kernel bot in dpu driver

2021-03-04 Thread Kalyan Thota
Fix a warning, pointing to an early deference of a variable before check. This bug was introduced in the following commit. commit 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu driver") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Kalyan Thota