Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-06-03 Thread Rob Clark
On Wed, Jun 2, 2021 at 4:01 AM Vinod Koul wrote: > > On 27-05-21, 16:30, Rob Clark wrote: > > On Wed, May 26, 2021 at 8:00 AM Jeffrey Hugo > > wrote: > > > On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > > > > Frankly, I don't like the MSM ACPI solution that I've seen on the laptops. > > >

Re: [Freedreno] [RESEND 14/26] drm/msm/dp/dp_link: Fix some potential doc-rot

2021-06-03 Thread Dmitry Baryshkov
On 02/06/2021 17:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/dp/dp_link.c:374: warning: expecting prototype for dp_parse_video_pattern_params(). Prototype was for dp_link_parse_video_pattern_params() instead drivers/gpu/drm/msm/dp/dp_link.c:573

Re: [Freedreno] [RESEND 12/26] drm/msm/msm_gem: Demote kernel-doc abuses

2021-06-03 Thread Dmitry Baryshkov
On 02/06/2021 17:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/msm_gem.c:364: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst drivers/gpu/drm/msm/msm_gem.c:763: warning: This co

[Freedreno] [PATCH v5] drm/msm/dp: power off DP phy at suspend

2021-06-03 Thread Kuogee Hsieh
Normal DP suspend operation contains two steps, display off followed by dp suspend, to complete system wide suspending cycle if display is up at that time. In this case, DP phy will be powered off at display off. However there is an exception case that depending on the timing of dongle plug in duri

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-06-03 Thread abhinavk
On 2021-06-02 04:01, Vinod Koul wrote: On 27-05-21, 16:30, Rob Clark wrote: On Wed, May 26, 2021 at 8:00 AM Jeffrey Hugo wrote: > On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > Frankly, I don't like the MSM ACPI solution that I've seen on the laptops. > The ACPI assumes the entire MD

Re: [Freedreno] [PATCH v5] drm/msm/dp: power off DP phy at suspend

2021-06-03 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-06-03 14:59:49) > On 2021-06-03 13:22, Stephen Boyd wrote: > > Can you Cc dri-devel? > > > Sorry for dropping this cc. > Should I re submit this v5 with cc=dri-devel? > Yes please. Then the patchwork stuff will catch it. _

[Freedreno] [PATCH v4] arm64: dts: qcom: sc7180: Add DisplayPort node

2021-06-03 Thread Kuogee Hsieh
Add DP device node on sc7180. Signed-off-by: Kuogee Hsieh --- Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table Changes in v3: -- correct text of commit title Changes in v4: -- replace dp with mdss_dp -- replace opp_table with dp_opp_table arch/arm64/boot/dts/qc

Re: [Freedreno] [PATCH v5] drm/msm/dp: power off DP phy at suspend

2021-06-03 Thread khsieh
On 2021-06-03 13:22, Stephen Boyd wrote: Can you Cc dri-devel? Sorry for dropping this cc. Should I re submit this v5 with cc=dri-devel? Quoting Kuogee Hsieh (2021-06-03 08:40:46) Normal DP suspend operation contains two steps, display off followed by dp suspend, to complete system wide su

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread khsieh
On 2021-06-03 09:53, Bjorn Andersson wrote: On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: Add DP device node on sc7180. Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table I'm sorry for those suggestions, I don't like either one of them. And for everything b

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Kees Cook
On Thu, Jun 03, 2021 at 11:41:01PM +0200, Daniel Vetter wrote: > On Thu, Jun 3, 2021 at 11:29 PM Kees Cook wrote: > > > > On Thu, Jun 03, 2021 at 02:19:52PM -0700, Kees Cook wrote: > > > On Thu, Jun 03, 2021 at 09:19:42PM +0200, Daniel Vetter wrote: > > > > On Thu, Jun 3, 2021 at 8:43 PM Rob Herri

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Daniel Vetter
On Thu, Jun 3, 2021 at 11:29 PM Kees Cook wrote: > > On Thu, Jun 03, 2021 at 02:19:52PM -0700, Kees Cook wrote: > > On Thu, Jun 03, 2021 at 09:19:42PM +0200, Daniel Vetter wrote: > > > On Thu, Jun 3, 2021 at 8:43 PM Rob Herring wrote: > > > > > > > > On Wed, Jun 2, 2021 at 4:53 PM Kees Cook wrot

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-06-03 14:28:37) > On 2021-06-03 09:53, Bjorn Andersson wrote: > > On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: > > > >> Add DP device node on sc7180. > >> > >> Changes in v2: > >> -- replace msm_dp with dp > >> -- replace dp_opp_table with opp_table > >> > >

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread khsieh
On 2021-06-03 09:53, Bjorn Andersson wrote: On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: Add DP device node on sc7180. Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table I'm sorry for those suggestions, I don't like either one of them. And for everything b

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Kees Cook
On Thu, Jun 03, 2021 at 02:19:52PM -0700, Kees Cook wrote: > On Thu, Jun 03, 2021 at 09:19:42PM +0200, Daniel Vetter wrote: > > On Thu, Jun 3, 2021 at 8:43 PM Rob Herring wrote: > > > > > > On Wed, Jun 2, 2021 at 4:53 PM Kees Cook wrote: > > > > > > > > Avoid randconfig build failures by requirin

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Kees Cook
On Thu, Jun 03, 2021 at 09:19:42PM +0200, Daniel Vetter wrote: > On Thu, Jun 3, 2021 at 8:43 PM Rob Herring wrote: > > > > On Wed, Jun 2, 2021 at 4:53 PM Kees Cook wrote: > > > > > > Avoid randconfig build failures by requiring VEXPRESS_CONFIG: > > > > > > aarch64-linux-gnu-ld: drivers/gpu/drm/pl

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add DisplayPort node

2021-06-03 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-06-03 09:37:30) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 24d293e..40367a2 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -78

Re: [Freedreno] [PATCH v5] drm/msm/dp: power off DP phy at suspend

2021-06-03 Thread Stephen Boyd
Can you Cc dri-devel? Quoting Kuogee Hsieh (2021-06-03 08:40:46) > Normal DP suspend operation contains two steps, display off followed > by dp suspend, to complete system wide suspending cycle if display is > up at that time. In this case, DP phy will be powered off at display > off. However ther

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Rob Herring
On Thu, Jun 3, 2021 at 1:42 PM Rob Herring wrote: > > On Wed, Jun 2, 2021 at 4:53 PM Kees Cook wrote: > > > > Avoid randconfig build failures by requiring VEXPRESS_CONFIG: > > > > aarch64-linux-gnu-ld: drivers/gpu/drm/pl111/pl111_versatile.o: in function > > `pl111_vexpress_clcd_init': > > pl111

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Daniel Vetter
On Thu, Jun 3, 2021 at 8:43 PM Rob Herring wrote: > > On Wed, Jun 2, 2021 at 4:53 PM Kees Cook wrote: > > > > Avoid randconfig build failures by requiring VEXPRESS_CONFIG: > > > > aarch64-linux-gnu-ld: drivers/gpu/drm/pl111/pl111_versatile.o: in function > > `pl111_vexpress_clcd_init': > > pl111

Re: [Freedreno] [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB

2021-06-03 Thread Rob Herring
On Thu, Jun 3, 2021 at 3:48 AM Daniel Vetter wrote: > > On Wed, Jun 02, 2021 at 02:52:50PM -0700, Kees Cook wrote: > > When cleaning up other drm config dependencies, it is too easy to create > > larger problems. Instead, mark CONFIG_FB as a "depends": > > > > drivers/gpu/drm/Kconfig:74:error: rec

Re: [Freedreno] [PATCH 3/3] drm/pl111: depend on CONFIG_VEXPRESS_CONFIG

2021-06-03 Thread Rob Herring
On Wed, Jun 2, 2021 at 4:53 PM Kees Cook wrote: > > Avoid randconfig build failures by requiring VEXPRESS_CONFIG: > > aarch64-linux-gnu-ld: drivers/gpu/drm/pl111/pl111_versatile.o: in function > `pl111_vexpress_clcd_init': > pl111_versatile.c:(.text+0x220): undefined reference to > `devm_regmap_

Re: [Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add DisplayPort node

2021-06-03 Thread Bjorn Andersson
On Thu 03 Jun 11:37 CDT 2021, Kuogee Hsieh wrote: > Add DP device node on sc7180. > > Changes in v2: > -- replace msm_dp with dp > -- replace dp_opp_table with opp_table > > Changes in v3: > -- correct text of commit title In addition to the feedback I gave on v2, please also remove one of the

Re: [Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread Bjorn Andersson
On Thu 03 Jun 11:09 CDT 2021, Kuogee Hsieh wrote: > Add DP device node on sc7180. > > Changes in v2: > -- replace msm_dp with dp > -- replace dp_opp_table with opp_table > I'm sorry for those suggestions, I don't like either one of them. And for everything but changes to the DRM code the chang

[Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add DisplayPort node

2021-06-03 Thread Kuogee Hsieh
Add DP device node on sc7180. Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table Changes in v3: -- correct text of commit title Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78

Re: [Freedreno] [RFC 5/8] lib: add small API for handling register snapshots

2021-06-03 Thread Dmitry Baryshkov
On Thu, 3 Jun 2021 at 17:41, Rob Clark wrote: > > On Fri, May 28, 2021 at 5:25 PM Dmitry Baryshkov > wrote: > > > > Add small API covering lists of register dumps. Currently this is a part > > of MSM DRM driver, but is extracted as it might be usefull to other > > drivers too. > > > > Signed-off-

[Freedreno] [PATCH v2] arm64/dts/qcom/sc7180: Add Display Port dt node

2021-06-03 Thread Kuogee Hsieh
Add DP device node on sc7180. Changes in v2: -- replace msm_dp with dp -- replace dp_opp_table with opp_table Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 2 files changed,

[Freedreno] [PATCH v5] drm/msm/dp: power off DP phy at suspend

2021-06-03 Thread Kuogee Hsieh
Normal DP suspend operation contains two steps, display off followed by dp suspend, to complete system wide suspending cycle if display is up at that time. In this case, DP phy will be powered off at display off. However there is an exception case that depending on the timing of dongle plug in duri

Re: [Freedreno] [RFC 5/8] lib: add small API for handling register snapshots

2021-06-03 Thread Rob Clark
On Fri, May 28, 2021 at 5:25 PM Dmitry Baryshkov wrote: > > Add small API covering lists of register dumps. Currently this is a part > of MSM DRM driver, but is extracted as it might be usefull to other > drivers too. > > Signed-off-by: Dmitry Baryshkov > --- > include/linux/dump_state.h | 78 ++

Re: [Freedreno] [RESEND 00/26] Rid W=1 warnings from GPU

2021-06-03 Thread Lee Jones
On Thu, 03 Jun 2021, Daniel Vetter wrote: > On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote: > > Some off these patches have been knocking around for a while. > > > > Who will hoover them up please? > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel build

Re: [Freedreno] [RESEND 00/26] Rid W=1 warnings from GPU

2021-06-03 Thread Daniel Vetter
On Wed, Jun 02, 2021 at 03:32:34PM +0100, Lee Jones wrote: > Some off these patches have been knocking around for a while. > > Who will hoover them up please? > > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > nigg

Re: [Freedreno] [PATCH 1/3] drm: Avoid circular dependencies for CONFIG_FB

2021-06-03 Thread Daniel Vetter
On Wed, Jun 02, 2021 at 02:52:50PM -0700, Kees Cook wrote: > When cleaning up other drm config dependencies, it is too easy to create > larger problems. Instead, mark CONFIG_FB as a "depends": > > drivers/gpu/drm/Kconfig:74:error: recursive dependency detected! > > Suggested-by: Arnd Bergmann >