Re: [Freedreno] [PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP

2021-06-04 Thread Stephen Boyd
Quoting abhin...@codeaurora.org (2021-05-28 16:40:32) > On 2021-05-10 21:20, Bjorn Andersson wrote: > > The eDP controller found in SC8180x is at large compatible with the > > current implementation, but has its register blocks at slightly > > different offsets. > > > > Add the compatible and the n

Re: [Freedreno] [PATCH v3 4/4] drm/msm/dpu: hw_blk: make dpu_hw_blk empty opaque structure

2021-06-04 Thread abhinavk
On 2021-05-15 12:09, Dmitry Baryshkov wrote: The code does not really use dpu_hw_blk fields, so drop them, making dpu_hw_blk empty structure. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/disp/dpu1/dp

Re: [Freedreno] [PATCH v3 3/4] drm/msm/dpu: use struct dpu_hw_merge_3d in dpu_hw_pingpong

2021-06-04 Thread abhinavk
On 2021-05-15 12:09, Dmitry Baryshkov wrote: Use struct dpu_hw_merge_3d pointer in struct dpu_hw_pingpong rather than using struct dpu_hw_blk. This is the only user of dpu_hw_blk.id, which will be cleaned in the next patch. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- driv

Re: [Freedreno] [PATCH v3 2/4] drm/msm/dpu: drop dpu_hw_blk_destroy function

2021-06-04 Thread abhinavk
On 2021-05-15 12:09, Dmitry Baryshkov wrote: The dpu_hw_blk_destroy() function is empty, so we can drop it now. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 13 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.h

Re: [Freedreno] [PATCH v3 1/4] drm/msm/dpu: remove unused dpu_hw_blk features

2021-06-04 Thread abhinavk
On 2021-05-15 12:09, Dmitry Baryshkov wrote: Remove all unused dpu_hw_blk features and functions: - dpu_hw_blk_get()/_put() and respective refcounting, - global list of all dpu_hw_blk instances, - dpu_hw_blk_ops and empty implementation inside each hw_blk subdriver. This leaves dpu_hw_blk as a p

Re: [Freedreno] [PATCH] drm/msm/dsi: print error code when MIPI DSI host registration fails

2021-06-04 Thread abhinavk
On 2021-06-04 03:44, Dmitry Baryshkov wrote: In order to ease debugging of DSI host registration issues, print return code of dsi_mgr_setup_components(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- 1 file changed, 2 inserti

[Freedreno] [PATCH] drm/msm/dsi: print error code when MIPI DSI host registration fails

2021-06-04 Thread Dmitry Baryshkov
In order to ease debugging of DSI host registration issues, print return code of dsi_mgr_setup_components(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/

Re: [Freedreno] [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses

2021-06-04 Thread Lee Jones
On Fri, 04 Jun 2021, Dmitry Baryshkov wrote: > On 02/06/2021 17:32, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: expecting > > prototype for Register offsets in MDSS register file for the interrupt

Re: [Freedreno] [RESEND 10/26] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses

2021-06-04 Thread Dmitry Baryshkov
On 02/06/2021 17:32, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: expecting prototype for Register offsets in MDSS register file for the interrupt registers(). Prototype was for MDP_SSPP_TOP0_OFF() instead