Re: [Freedreno] [PATCH v3 16/20] drm/msm: always wait for the exclusive fence

2021-07-09 Thread Christian König
Am 08.07.21 um 19:37 schrieb Daniel Vetter: From: Christian König Drivers also need to to sync to the exclusive fence when a shared one is present. Signed-off-by: Christian König [danvet: Not that hard to compile-test on arm ...] Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: Sean Paul Cc:

Re: [Freedreno] [PATCH v3 16/20] drm/msm: always wait for the exclusive fence

2021-07-09 Thread Daniel Vetter
On Fri, Jul 9, 2021 at 10:48 AM Christian König wrote: > Am 08.07.21 um 19:37 schrieb Daniel Vetter: > > From: Christian König > > > > Drivers also need to to sync to the exclusive fence when > > a shared one is present. > > > > Signed-off-by: Christian König > > [danvet: Not that hard to compil

[Freedreno] [v1] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-07-09 Thread Kalyan Thota
Add safe lut configuration for all the targets in dpu driver as per QOS recommendation. Issue reported on SC7280: With wait-for-safe feature in smmu enabled, RT client buffer levels are checked to be safe before smmu invalidation. Since display was always set to unsafe it was delaying the invalid

Re: [Freedreno] [PATCH] drm/msm: Fix display fault handling

2021-07-09 Thread Yassine Oudjana
On Wed, Jul 7 2021 at 21:57:05 +0400, Rob Clark wrote: > From: Rob Clark > > It turns out that when the display is enabled by the bootloader, we > can > get some transient iommu faults from the display. Which doesn't go > over > too well when we install a fault handler that is gpu specifi

Re: [Freedreno] [v1] drm/msm/disp/dpu1: add safe lut config in dpu driver

2021-07-09 Thread Dmitry Baryshkov
On Fri, 9 Jul 2021 at 13:41, Kalyan Thota wrote: > > Add safe lut configuration for all the targets in dpu > driver as per QOS recommendation. > > Issue reported on SC7280: > > With wait-for-safe feature in smmu enabled, RT client > buffer levels are checked to be safe before smmu invalidation. >

Re: [Freedreno] [PATCH v1 0/7] drm/msm/dpu: add support for idependent DSI config

2021-07-09 Thread Alexey Minnekhanov
08.07.2021 15:28, Dmitry Baryshkov wrote: This patchseries adds support for independent DSI config to DPU1 display subdriver. Also drop one of msm_kms_funcs callbacks, made unnecessary now. Tested on RB5 (dpu, dsi). Previous iteration was tested by Alexey Minnekhanov. Changes since v1: - rena

Re: [Freedreno] [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-07-09 Thread Doug Anderson
Hi, On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan wrote: > > This series adds the support for the eDP panel that needs the backlight > controlling over the DP AUX channel using DPCD registers of the panel > as per the VESA's standard. > > This series also adds support for the Samsung eDP AMOLED p

Re: [Freedreno] [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-09 Thread khsieh
On 2021-07-08 00:21, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:20) Main link symbol locked is achieved at end of link training 2. Some dongle main link symbol may become unlocked again if host did not end link training soon enough after completion of link training 2. Host have t

Re: [Freedreno] [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-09 Thread khsieh
On 2021-07-08 00:33, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:15) Reduce link rate and re start link training if link training 1 failed due to loss of clock recovery done to fix Link Layer CTS case 4.3.1.7. Also only update voltage and pre-emphasis swing level after link train

Re: [Freedreno] [PATCH 5/7] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-07-09 Thread khsieh
On 2021-07-08 00:14, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-07-06 10:20:18) Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_panel.c |

Re: [Freedreno] [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-07-09 Thread Ville Syrjälä
On Fri, Jul 09, 2021 at 06:54:05AM -0700, Doug Anderson wrote: > Hi, > > On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan wrote: > > > > This series adds the support for the eDP panel that needs the backlight > > controlling over the DP AUX channel using DPCD registers of the panel > > as per the VE

[Freedreno] [PATCH v2 0/8] dsi: rework clock parents and timing handling

2021-07-09 Thread Dmitry Baryshkov
This patch series brings back several patches targeting assigning dispcc clock parents, that were removed from the massive dsi rework patchset earlier. Few notes: - assign-clock-parents is a mandatory proprety according to the current dsi.txt description. - There is little point in duplicatin

[Freedreno] [PATCH v2 2/8] arm64: dts: qcom: sc7180: assign DSI clock source parents

2021-07-09 Thread Dmitry Baryshkov
Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 6228ba

[Freedreno] [PATCH v2 1/8] dt-bindings: display: msm: dsi-controller-main: restore assigned-clocks

2021-07-09 Thread Dmitry Baryshkov
Restore the assgined-clocks and assigned-clock-parents properties that were lost during the txt -> YAML conversion. Signed-off-by: Dmitry Baryshkov --- .../display/msm/dsi-controller-main.yaml| 17 + 1 file changed, 17 insertions(+) diff --git a/Documentation/devicetree

[Freedreno] [PATCH v2 3/8] arm64: dts: qcom: sdm845: assign DSI clock source parents

2021-07-09 Thread Dmitry Baryshkov
Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 0a8

[Freedreno] [PATCH v2 5/8] arm64: dts: qcom: sm8250: assign DSI clock source parents

2021-07-09 Thread Dmitry Baryshkov
Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index 4c0

[Freedreno] [PATCH v2 4/8] arm64: dts: qcom: sdm845-mtp: assign DSI clock source parents

2021-07-09 Thread Dmitry Baryshkov
Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts ind

[Freedreno] [PATCH v2 8/8] drm/msm/dsi: drop msm_dsi_phy_get_shared_timings

2021-07-09 Thread Dmitry Baryshkov
Instead of fetching shared timing through an extra function call, get them directly from msm_dsi_phy_enable. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.h | 5 ++--- drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 +-- drivers/gpu/drm/msm/dsi/p

[Freedreno] [PATCH v2 7/8] drm/msm/dsi: phy: use of_device_get_match_data

2021-07-09 Thread Dmitry Baryshkov
Use of_device_get_match-data() instead of of_match_node(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm

[Freedreno] [PATCH v2 6/8] drm/msm/dsi: stop setting clock parents manually

2021-07-09 Thread Dmitry Baryshkov
There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to move registration of hw clock providers to generic place. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhina

Re: [Freedreno] [PATCH v1 3/7] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "bonded DSI" but also "two independent DSI" configurations. In future this would also

Re: [Freedreno] [PATCH v1 3/7] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-09 Thread Dmitry Baryshkov
On 10/07/2021 01:09, abhin...@codeaurora.org wrote: On 2021-07-08 05:28, Dmitry Baryshkov wrote: Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "bonded DSI" but also "two indepen

Re: [Freedreno] [PATCH v1 1/7] drm/msm/dsi: rename dual DSI to bonded DSI

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: We are preparing to support two independent DSI hosts in the DSI/DPU code. To remove possible confusion (as both configurations can be referenced as dual DSI) let's rename old "dual DSI" (two DSI hosts driving single device, with clocks being locked) t

Re: [Freedreno] [PATCH v1 2/7] drm/msm/dsi: add two helper functions

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: Add two helper functions to be used by display drivers for setting up encoders. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 7 +++ drivers/gpu/drm/msm/dsi/dsi_manager.c | 14 ++--

Re: [Freedreno] [PATCH v1 4/7] drm/msm/mdp5: move mdp5_encoder_set_intf_mode after msm_dsi_modeset_init

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: Move a call to mdp5_encoder_set_intf_mode() after msm_dsi_modeset_init(), removing set_encoder_mode callback. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 +++ 1 file changed

Re: [Freedreno] [PATCH v1 5/7] drm/msm/dp: stop calling set_encoder_mode callback

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code. Signed-off-by: Dmitry Baryshkov The change looks fine, Reviewed-by: Abhinav Kumar But has DP been re-verified with this change by Bjo

Re: [Freedreno] [PATCH v1 6/7] drm/msm/dsi: stop calling set_encoder_mode callback

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 2 -- drivers/gpu/drm/msm/dsi

Re: [Freedreno] [PATCH v1 7/7] drm/msm/kms: drop set_encoder_mode callback

2021-07-09 Thread abhinavk
On 2021-07-08 05:28, Dmitry Baryshkov wrote: set_encoder_mode callback is completely unused now. Drop it from msm_kms_func(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_kms.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/ms

Re: [Freedreno] [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20

2021-07-09 Thread Doug Anderson
Hi, On Fri, Jul 9, 2021 at 1:41 PM Ville Syrjälä wrote: > > On Fri, Jul 09, 2021 at 06:54:05AM -0700, Doug Anderson wrote: > > Hi, > > > > On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan > > wrote: > > > > > > This series adds the support for the eDP panel that needs the backlight > > > controlli

Re: [Freedreno] [PATCH v1 5/7] drm/msm/dp: stop calling set_encoder_mode callback

2021-07-09 Thread Dmitry Baryshkov
On 10/07/2021 01:16, abhin...@codeaurora.org wrote: On 2021-07-08 05:28, Dmitry Baryshkov wrote: None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code. Signed-off-by: Dmitry Baryshkov The change looks fine, Reviewed-by: Abhinav Kumar

[Freedreno] [PATCH v2 0/7] drm/msm/dpu: add support for independent DSI config

2021-07-09 Thread Dmitry Baryshkov
This patchseries adds support for independent DSI config to DPU1 display subdriver. Also drop one of msm_kms_funcs callbacks, made unnecessary now. Tested on RB5 (dpu, dsi). Previous iteration was tested by Alexey Minnekhanov. Cahanges since v1: - Rewrote dsi encoder setup function by separating

[Freedreno] [PATCH v2 2/7] drm/msm/dsi: add two helper functions

2021-07-09 Thread Dmitry Baryshkov
Add two helper functions to be used by display drivers for setting up encoders. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 7 +++ drivers/gpu/drm/msm/dsi/dsi_manager.c | 14 ++ drivers/gpu/drm/msm/msm_drv.h | 1

[Freedreno] [PATCH v2 1/7] drm/msm/dsi: rename dual DSI to bonded DSI

2021-07-09 Thread Dmitry Baryshkov
We are preparing to support two independent DSI hosts in the DSI/DPU code. To remove possible confusion (as both configurations can be referenced as dual DSI) let's rename old "dual DSI" (two DSI hosts driving single device, with clocks being locked) to "bonded DSI". Signed-off-by: Dmitry Baryshko

[Freedreno] [PATCH v2 4/7] drm/msm/mdp5: move mdp5_encoder_set_intf_mode after msm_dsi_modeset_init

2021-07-09 Thread Dmitry Baryshkov
Move a call to mdp5_encoder_set_intf_mode() after msm_dsi_modeset_init(), removing set_encoder_mode callback. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/d

[Freedreno] [PATCH v2 6/7] drm/msm/dsi: stop calling set_encoder_mode callback

2021-07-09 Thread Dmitry Baryshkov
None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.c | 2 -- drivers/gpu/drm/msm/dsi/dsi.h | 1 - drivers/gpu/drm/msm/dsi/ds

[Freedreno] [PATCH v2 3/7] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-09 Thread Dmitry Baryshkov
Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "bonded DSI" but also "two independent DSI" configurations. In future this would also help adding support for multiple DP connectors.

[Freedreno] [PATCH v2 5/7] drm/msm/dp: stop calling set_encoder_mode callback

2021-07-09 Thread Dmitry Baryshkov
None of the display drivers now implement set_encoder_mode callback. Stop calling it from the modeset init code. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dp/dp_display.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/gpu/

[Freedreno] [PATCH v2 7/7] drm/msm/kms: drop set_encoder_mode callback

2021-07-09 Thread Dmitry Baryshkov
set_encoder_mode callback is completely unused now. Drop it from msm_kms_func(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_kms.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_kms.h b/drivers/gpu/drm/msm/msm_kms.h index

Re: [Freedreno] [PATCH v2 3/7] drm/msm/dpu: support setting up two independent DSI connectors

2021-07-09 Thread abhinavk
On 2021-07-09 16:50, Dmitry Baryshkov wrote: Move setting up encoders from set_encoder_mode to _dpu_kms_initialize_dsi() / _dpu_kms_initialize_displayport(). This allows us to support not only "single DSI" and "bonded DSI" but also "two independent DSI" configurations. In future this would also