Re: [Freedreno] [PATCH] drm/msm/dsi: add support for dsi test pattern generator

2021-07-15 Thread abhinavk
Hi Marijn Sorry for the late response. On 2021-07-13 02:10, Marijn Suijten wrote: On 6/29/21 9:04 PM, Abhinav Kumar wrote: During board bringups its useful to have a DSI test pattern generator to isolate a DPU vs a DSI issue and focus on the relevant hardware block. To facilitate this, add

Re: [Freedreno] [PATCH v2] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-15 Thread maitreye
Hi Stephen, Thanks for reviewing my code. On 2021-07-08 18:27, Stephen Boyd wrote: Quoting maitreye (2021-07-08 12:13:44) From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of

Re: [Freedreno] [PATCH 7/7] drm/msm/dp: retrain link when loss of symbol lock detected

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:16:52) > On 2021-07-08 00:21, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-07-06 10:20:20) > >> Main link symbol locked is achieved at end of link training 2. Some > >> dongle main link symbol may become unlocked again if host did not end > >>

Re: [Freedreno] [PATCH 2/7] drm/msm/dp: reduce link rate if failed at link training 1

2021-07-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-07-09 10:46:41) > On 2021-07-08 00:33, Stephen Boyd wrote: > >> + > >> +static bool dp_ctrl_any_lane_cr_lose(struct dp_ctrl_private *ctrl, > >> + u8 *cr_status) > >> +{ > >> + int i; > >> + u8 status; > >> +

Re: [Freedreno] [PATCH v2 1/8] dt-bindings: display: msm: dsi-controller-main: restore assigned-clocks

2021-07-15 Thread Rob Herring
On Sat, 10 Jul 2021 00:07:22 +0300, Dmitry Baryshkov wrote: > Restore the assgined-clocks and assigned-clock-parents properties that > were lost during the txt -> YAML conversion. > > Signed-off-by: Dmitry Baryshkov > --- > .../display/msm/dsi-controller-main.yaml| 17 +

[Freedreno] [PATCH] drm/msm: mdp4: drop vblank get/put from prepare/complete_commit

2021-07-15 Thread David Heidelberg
msm_atomic is doing vblank get/put's already, currently there no need to duplicate the effort in MDP4 Fix warning: ... WARNING: CPU: 3 PID: 79 at drivers/gpu/drm/drm_vblank.c:1194 drm_vblank_put+0x1cc/0x1d4 ... and multiple vblank time-outs: ... msm 510.mdp: vblank time out, crtc=1 ...

[Freedreno] [PATCH 11/11] drm/msm/dsi: Pass DSC params to drm_panel

2021-07-15 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel.h| 7 +++ 2 files

[Freedreno] [PATCH 10/11] drm/msm/dsi: Add support for DSC configuration

2021-07-15 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul ---

[Freedreno] [PATCH 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-07-15 Thread Vinod Koul
For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. The topology information is provided by DTS so we try to deduce the topology required for DSC. Furthermore, we can use 1 DSC encoder in lesser

[Freedreno] [PATCH 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-07-15 Thread Vinod Koul
When DSC is enabled in DT, we need to configure the encoder for DSC configuration, calculate DSC parameters for the given timing. This patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled in DT Signed-off-by: Vinod Koul ---

[Freedreno] [PATCH 07/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-07-15 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul ---

[Freedreno] [PATCH 06/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-07-15 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[Freedreno] [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-07-15 Thread Vinod Koul
This add SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul --- Changes since RFC: - use BIT values from MASK .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 22 +++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[Freedreno] [PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-07-15 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 32 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 1 + 3 files changed, 34 insertions(+) diff --git

[Freedreno] [PATCH 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-07-15 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 2 files changed, 46

[Freedreno] [PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-07-15 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- Changes since RFC: - Drop unused enums drivers/gpu/drm/msm/Makefile | 1 + .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 13 ++

[Freedreno] [PATCH 01/11] drm/msm/dsi: add support for dsc data

2021-07-15 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- Changes since RFC: - Drop the DT parsing code - Port dsc param

[Freedreno] [PATCH 00/11] drm/msm: Add Display Stream Compression Support

2021-07-15 Thread Vinod Koul
Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel. The changes include adding DT properties for DSC then hardware blocks