Re: [Freedreno] [PATCH v3] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-20 Thread Stephen Boyd
Quoting maitreye (2021-07-20 15:39:30) > diff --git a/drivers/gpu/drm/msm/dp/dp_link.c > b/drivers/gpu/drm/msm/dp/dp_link.c > index be986da..316e8e6 100644 > --- a/drivers/gpu/drm/msm/dp/dp_link.c > +++ b/drivers/gpu/drm/msm/dp/dp_link.c > @@ -1036,43 +1036,46 @@ int

[Freedreno] [PATCH v3] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-20 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v3: - Got rid of redundant log messages. - Unstuck colon from printf specifier in various places. Signed-off-by: Maitreyee Rao --- drivers/gpu/drm/msm/dp/dp_catalog.c | 8 ++--

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Rob Clark
On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: > > On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > > > On Tue, Jul 20, 2021 at 11:03 AM Christian König > > wrote: > > > > > > Hi Rob, > > > > > > Am 20.07.21 um 17:07 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > Somehow

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Daniel Vetter
On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > On Tue, Jul 20, 2021 at 11:03 AM Christian König > wrote: > > > > Hi Rob, > > > > Am 20.07.21 um 17:07 schrieb Rob Clark: > > > From: Rob Clark > > > > > > Somehow we had neither ->wait() nor dma_fence_signal() calls, and no > > > one

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Rob Clark
On Tue, Jul 20, 2021 at 11:03 AM Christian König wrote: > > Hi Rob, > > Am 20.07.21 um 17:07 schrieb Rob Clark: > > From: Rob Clark > > > > Somehow we had neither ->wait() nor dma_fence_signal() calls, and no > > one noticed. Oops. > > > I'm not sure if that is a good idea. > > The

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Christian König
Hi Rob, Am 20.07.21 um 17:07 schrieb Rob Clark: From: Rob Clark Somehow we had neither ->wait() nor dma_fence_signal() calls, and no one noticed. Oops. I'm not sure if that is a good idea. The dma_fence->wait() callback is pretty much deprecated and should not be used any more. What

[Freedreno] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Rob Clark
From: Rob Clark Somehow we had neither ->wait() nor dma_fence_signal() calls, and no one noticed. Oops. Note that this removes the !timeout case, which has not been used in a long time. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_fence.c | 59 +++-- 1

Re: [Freedreno] [Linaro-mm-sig] [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups

2021-07-20 Thread Daniel Vetter
On Tue, Jul 20, 2021 at 04:16:56PM +0200, Christian König wrote: > Am 20.07.21 um 16:07 schrieb Daniel Vetter: > > On Mon, Jul 19, 2021 at 10:40:57AM +0200, Christian König wrote: > > > Am 17.07.21 um 22:29 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > Conversion to gpu_scheduler,

Re: [Freedreno] [Linaro-mm-sig] [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups

2021-07-20 Thread Christian König
Am 20.07.21 um 16:07 schrieb Daniel Vetter: On Mon, Jul 19, 2021 at 10:40:57AM +0200, Christian König wrote: Am 17.07.21 um 22:29 schrieb Rob Clark: From: Rob Clark Conversion to gpu_scheduler, and bonus removal of drm_gem_object_put_locked() Oh yes please! If I'm not completely mistaken

Re: [Freedreno] [PATCH 04/11] drm: Drop drm_gem_object_put_locked()

2021-07-20 Thread Daniel Vetter
On Sat, Jul 17, 2021 at 01:29:06PM -0700, Rob Clark wrote: > From: Rob Clark > > Now that no one is using it, remove it. > > Signed-off-by: Rob Clark Yay! Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem.c | 22 -- > include/drm/drm_gem.h | 2 -- > 2

Re: [Freedreno] [Linaro-mm-sig] [PATCH 00/11] drm/msm: drm scheduler conversion and cleanups

2021-07-20 Thread Daniel Vetter
On Mon, Jul 19, 2021 at 10:40:57AM +0200, Christian König wrote: > Am 17.07.21 um 22:29 schrieb Rob Clark: > > From: Rob Clark > > > > Conversion to gpu_scheduler, and bonus removal of > > drm_gem_object_put_locked() > > Oh yes please! > > If I'm not completely mistaken that was the last