Re: [Freedreno] [PATCH v5] drm/msm/dsi: add continuous clock support for 7nm PHY

2021-08-10 Thread abhinavk
On 2021-08-05 10:08, Dmitry Baryshkov wrote: Unlike previous generations, 7nm PHYs are required to collaborate with the host for conitnuos clock mode. Add changes neccessary to enable /continuous /necessary continuous clock mode in the 7nm DSI PHYs. Signed-off-by: Dmitry Baryshkov --- Changes

Re: [Freedreno] [PATCH] drm/msm/dsi: add support for dsi test pattern generator

2021-08-10 Thread abhinavk
Hi Marijn Thanks for reviewing and testing the latest patchset. On 2021-08-10 15:59, Marijn Suijten wrote: Hi Abhinav, On 7/16/21 2:01 AM, abhin...@codeaurora.org wrote: Hi Marijn Sorry for the late response. Apologies from my side as well. [...] +static void msm_dsi_host_cmd_test_patt

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dsi: add support for dsi test pattern generator

2021-08-10 Thread Marijn Suijten
Hi Abhinav, On 7/22/21 4:50 AM, Abhinav Kumar wrote: During board bringups its useful to have a DSI test pattern generator to isolate a DPU vs a DSI issue and focus on the relevant hardware block. To facilitate this, add an API which triggers the DSI controller test pattern. The expected output

Re: [Freedreno] [PATCH] drm/msm/dsi: add support for dsi test pattern generator

2021-08-10 Thread Marijn Suijten
Hi Abhinav, On 7/16/21 2:01 AM, abhin...@codeaurora.org wrote: Hi Marijn Sorry for the late response. Apologies from my side as well. [...] +static void msm_dsi_host_cmd_test_pattern_setup(struct msm_dsi_host *msm_host) +{ + u32 reg; + + reg = dsi_read(msm_host, REG_DSI_TEST_P

Re: [Freedreno] [PATCH v3 0/6] add fixes to pass DP Link Layer compliance test cases

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-05 13:44:49) > add fixes to pass DP Link Layer compliance test cases > > Kuogee Hsieh (6): > drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run > drm/msm/dp: reduce link rate if failed at link training 1 > drm/msm/dp: reset aux controller afte

Re: [Freedreno] [PATCH v3 6/6] drm/msm/dp: do not end dp link training until video is ready

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-05 13:44:55) > Initialize both pre-emphasis and voltage swing level to 0 before > start link training and do not end link training until video is > ready to reduce the period between end of link training and video > start to meet Link Layer CTS requirement. Some dongl

Re: [Freedreno] [PATCH v3 5/6] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-05 13:44:54) > Response with correct edid checksum saved at connector after corrupted edid > checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 4/6] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-05 13:44:53) > Remove special handling of replug interrupt and instead treat replug event > as a sequential unplug followed by a plugin event. This is needed to meet > the requirements of DP Link Layer CTS test case 4.2.1.3. > > Changes in V2: > -- add fixes statement

Re: [Freedreno] [PATCH v3 2/6] drm/msm/dp: reduce link rate if failed at link training 1

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-05 13:44:51) > Reduce link rate and re start link training if link training 1 > failed due to loss of clock recovery done to fix Link Layer > CTS case 4.3.1.7. Also only update voltage and pre-emphasis > swing level after link training started to fix Link Layer CTS >

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread khsieh
On 2021-08-10 12:23, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-08-10 12:18:02) On 2021-08-10 11:33, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-08-10 08:29:22) >> Changes in V2: >> -- correct Fixes text >> -- drop commit text >> >> Fixes: 601f0479c583 ("drm/msm/dp: add logs ac

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-08-10 12:18:02) > On 2021-08-10 11:33, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-08-10 08:29:22) > >> Changes in V2: > >> -- correct Fixes text > >> -- drop commit text > >> > >> Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease > >> o

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread khsieh
On 2021-08-10 11:33, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-08-10 08:29:22) Changes in V2: -- correct Fixes text -- drop commit text Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of debugging") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-10 08:29:22) > Changes in V2: > -- correct Fixes text > -- drop commit text > > Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of > debugging") > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_display.c | 13 + > 1 fi

Re: [Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-08-10 08:29:22) > Changes in V2: > -- correct Fixes text > -- drop commit text > > Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of > debugging") > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

[Freedreno] [PATCH v2] drm/msm/dp: add drm debug logs to dp_pm_resume/suspend

2021-08-10 Thread Kuogee Hsieh
Changes in V2: -- correct Fixes text -- drop commit text Fixes: 601f0479c583 ("drm/msm/dp: add logs across DP driver for ease of debugging") Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm

Re: [Freedreno] [PATCH v2] drm/drv: Remove initialization of static variables

2021-08-10 Thread zhaoxiao
Thanks for you advice, and I modify the patch according to your suggestions. 在 2021/8/10 下午5:59, Daniel Vetter 写道: On Fri, Aug 06, 2021 at 10:30:47AM +0800, zhaoxiao wrote: Address the following checkpatch errors: ERROR: do not initialise statics to false FILE: :drivers/gpu/drm/msm/msm_drv.c:2

[Freedreno] [PATCH v3] drm/msm: Remove initialization of static variables

2021-08-10 Thread zhaoxiao
Address the following checkpatch errors: ERROR: do not initialise statics to false FILE: :drivers/gpu/drm/msm/msm_drv.c:21: -static bool reglog = false; FILE: :drivers/gpu/drm/msm/msm_drv.c:31: -bool dumpstate = false; Signed-off-by: zhaoxiao --- v3: Subject should start out with drm/msm, not d

Re: [Freedreno] [PATCH v2] drm/drv: Remove initialization of static variables

2021-08-10 Thread Daniel Vetter
On Fri, Aug 06, 2021 at 10:30:47AM +0800, zhaoxiao wrote: > Address the following checkpatch errors: > ERROR: do not initialise statics to false > > FILE: :drivers/gpu/drm/msm/msm_drv.c:21: > -static bool reglog = false; > > FILE: :drivers/gpu/drm/msm/msm_drv.c:31: > -bool dumpstate = false; > >

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-10 Thread Sai Prakash Ranjan
On 2021-08-10 14:46, Will Deacon wrote: On Mon, Aug 09, 2021 at 11:17:40PM +0530, Sai Prakash Ranjan wrote: On 2021-08-09 23:10, Will Deacon wrote: > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > > On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > > > On Mon, Aug 09, 2021 at 0

Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache

2021-08-10 Thread Will Deacon
On Mon, Aug 09, 2021 at 11:17:40PM +0530, Sai Prakash Ranjan wrote: > On 2021-08-09 23:10, Will Deacon wrote: > > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > > > On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > > > > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: >