Re: [Freedreno] [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-08-11 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-08-11 17:08:01) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > index b131fd37..1096c44 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > +++

Re: [Freedreno] [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string

2021-08-11 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-08-11 17:08:02) > The Qualcomm SC7280 platform supports an eDP controller, add > compatible string for it to msm/binding. > > Signed-off-by: Sankeerth Billakanti > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed,

Re: [Freedreno] [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-11 Thread Stephen Boyd
Quoting Rob Clark (2021-08-11 16:52:47) > From: Rob Clark > > If we created our own connector because the driver does not support the > NO_CONNECTOR flag, we don't want the downstream bridge to *also* create > a connector. And if this driver did pass the NO_CONNECTOR flag (and we > supported

[Freedreno] [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-08-11 Thread Sankeerth Billakanti
The eDP controller on SC7280 is similar to the eDP/DP controllers supported by the current driver implementation. SC7280 supports one EDP and one DP controller which can operate concurrently. The following are some required changes for the sc7280 sink: 1. Additional gpio configuration for

[Freedreno] [PATCH v1 2/2] dt-bindings: Add SC7280 compatible string

2021-08-11 Thread Sankeerth Billakanti
The Qualcomm SC7280 platform supports an eDP controller, add compatible string for it to msm/binding. Signed-off-by: Sankeerth Billakanti --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Freedreno] [PATCH v1 0/2] Add support for eDP on SC7280

2021-08-11 Thread Sankeerth Billakanti
This series will add eDP controller support for Qualcomm SC7280 platform. These patches are baseline changes with which we can enable eDP display on sc7280. The sc7280 eDP controller can also support additional features such as backlight control, PSR etc. which will be enabled in

[Freedreno] [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-08-11 Thread Rob Clark
From: Rob Clark Slightly awkward to fish out the display_info when we aren't creating own connector. But I don't see an obvious better way. Signed-off-by: Rob Clark --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 34 +++ 1 file changed, 29 insertions(+), 5 deletions(-)

[Freedreno] [PATCH 3/4] drm/bridge: ti-sn65dsi86: Implement bridge->mode_valid()

2021-08-11 Thread Rob Clark
From: Rob Clark For the brave new world of bridges not creating their own connectors, we need to implement the max clock limitation via bridge->mode_valid() instead of connector->mode_valid(). Signed-off-by: Rob Clark --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 24 +++- 1

[Freedreno] [PATCH 2/4] drm/msm/dsi: Support NO_CONNECTOR bridges

2021-08-11 Thread Rob Clark
From: Rob Clark For now, since we have a mix of bridges which support this flag, which which do *not* support this flag, or work both ways, try it once with NO_CONNECTOR and then fall back to the old way if that doesn't work. Eventually we can drop the fallback path. Signed-off-by: Rob Clark

[Freedreno] [PATCH 1/4] drm/bridge: ti-sn65dsi86: Avoid creating multiple connectors

2021-08-11 Thread Rob Clark
From: Rob Clark If we created our own connector because the driver does not support the NO_CONNECTOR flag, we don't want the downstream bridge to *also* create a connector. And if this driver did pass the NO_CONNECTOR flag (and we supported that mode) this would change nothing. Fixes:

[Freedreno] [PATCH 0/4] drm/msm+ti-sn65dsi86: Fix NO_CONNECTOR fallout

2021-08-11 Thread Rob Clark
From: Rob Clark The first patch fixes breakage in drm-next for the ti eDP bridge (which is used on nearly all the snapdragon windows laptops and chromebooks). The second add drm/msm NO_CONNECTOR support, and the final two add NO_CONNECTOR support to the ti eDP bridge. Would be nice to get at

Re: [Freedreno] [PATCH] drm/msm: Read frame_count and line_count even when disabled.

2021-08-11 Thread abhinavk
On 2021-08-11 16:28, Rob Clark wrote: On Wed, Aug 11, 2021 at 4:11 PM wrote: On 2021-08-11 11:43, Rob Clark wrote: > On Wed, Aug 11, 2021 at 11:12 AM Mark Yacoub > wrote: >> >> From: Mark Yacoub >> >> [why] >> Reading frame count register used to get the vblank counter, which >> calls >>

Re: [Freedreno] [PATCH] drm/msm: Read frame_count and line_count even when disabled.

2021-08-11 Thread Rob Clark
On Wed, Aug 11, 2021 at 4:11 PM wrote: > > On 2021-08-11 11:43, Rob Clark wrote: > > On Wed, Aug 11, 2021 at 11:12 AM Mark Yacoub > > wrote: > >> > >> From: Mark Yacoub > >> > >> [why] > >> Reading frame count register used to get the vblank counter, which > >> calls > >> dpu_encoder_phys to

Re: [Freedreno] [PATCH] drm/msm: Read frame_count and line_count even when disabled.

2021-08-11 Thread abhinavk
On 2021-08-11 11:43, Rob Clark wrote: On Wed, Aug 11, 2021 at 11:12 AM Mark Yacoub wrote: From: Mark Yacoub [why] Reading frame count register used to get the vblank counter, which calls dpu_encoder_phys to get the frame count. Even when it's disabled, the vblank counter (through frame

Re: [Freedreno] [PATCH] drm/msm: Read frame_count and line_count even when disabled.

2021-08-11 Thread Rob Clark
On Wed, Aug 11, 2021 at 11:12 AM Mark Yacoub wrote: > > From: Mark Yacoub > > [why] > Reading frame count register used to get the vblank counter, which calls > dpu_encoder_phys to get the frame count. Even when it's disabled, the > vblank counter (through frame count) should return a valid

Re: [Freedreno] [PATCH v5 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-08-11 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-08-11 07:23:54) > Add the necessary dt nodes for gpu support in sc7280. > > Signed-off-by: Akhil P Oommen > --- Reviewed-by: Stephen Boyd

[Freedreno] [PATCH v4 2/6] drm/msm/dp: reduce link rate if failed at link training 1

2021-08-11 Thread Kuogee Hsieh
Reduce link rate and re start link training if link training 1 failed due to loss of clock recovery done to fix Link Layer CTS case 4.3.1.7. Also only update voltage and pre-emphasis swing level after link training started to fix Link Layer CTS case 4.3.1.6. Changes in V2: -- replaced cr_status

[Freedreno] [PATCH v4 5/6] drm/msm/dp: return correct edid checksum after corrupted edid checksum read

2021-08-11 Thread Kuogee Hsieh
Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[Freedreno] [PATCH v4 6/6] drm/msm/dp: do not end dp link training until video is ready

2021-08-11 Thread Kuogee Hsieh
Initialize both pre-emphasis and voltage swing level to 0 before start link training and do not end link training until video is ready to reduce the period between end of link training and video start to meet Link Layer CTS requirement. Some dongle main link symbol may become unlocked again if

[Freedreno] [PATCH v4 1/6] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run

2021-08-11 Thread Kuogee Hsieh
DP cable should always connect to DPU during the entire PHY compliance testing run. Since DP PHY compliance test is executed at irq_hpd event context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). dp_ctrl_off() is used for unplug event which is triggered when DP cable is dis

[Freedreno] [PATCH v4 3/6] drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

2021-08-11 Thread Kuogee Hsieh
Aux hardware calibration sequence requires resetting the aux controller in order for the new setting to take effect. However resetting the AUX controller will also clear HPD interrupt status which may accidentally cause pending unplug interrupt to get lost. Therefore reset aux controller only when

[Freedreno] [PATCH v4 0/6] add fixes to pass DP Link Layer compliance test cases

2021-08-11 Thread Kuogee Hsieh
drm/msm/dp: add fixes to pass DP Link Layer compliance test cases Kuogee Hsieh (6): drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run drm/msm/dp: reduce link rate if failed at link training 1 drm/msm/dp: reset aux controller after dp_aux_cmd_fifo_tx() failed.

[Freedreno] [PATCH v4 4/6] drm/msm/dp: replug event is converted into an unplug followed by an plug events

2021-08-11 Thread Kuogee Hsieh
Remove special handling of replug interrupt and instead treat replug event as a sequential unplug followed by a plugin event. This is needed to meet the requirements of DP Link Layer CTS test case 4.2.1.3. Changes in V2: -- add fixes statement Changes in V3: -- delete EV_HPD_REPLUG_INT Fixes:

[Freedreno] [PATCH v5 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-08-11 Thread Akhil P Oommen
From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen Reviewed-by: Stephen Boyd --- (no changes since v1)

[Freedreno] [PATCH v5 1/2] arm64: dts: qcom: sc7280: Add gpu support

2021-08-11 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in sc7280. Signed-off-by: Akhil P Oommen --- Changes in v5: - Added Stephen's reviewed-by tag to patch-2 Changes in v4: - Removed the dependency on gpucc bindings (Stephen) - Reordered GPU's opp table Changes in v3: - Re-ordered the nodes based on

[Freedreno] [PATCH v4 2/2] arm64: dts: qcom: sc7280: Add gpu thermal zone cooling support

2021-08-11 Thread Akhil P Oommen
From: Manaf Meethalavalappu Pallikunhi Add cooling-cells property and the cooling maps for the gpu thermal zones to support GPU thermal cooling. Signed-off-by: Manaf Meethalavalappu Pallikunhi Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 29

Re: [Freedreno] [PATCH v3 0/6] add fixes to pass DP Link Layer compliance test cases

2021-08-11 Thread Jani Nikula
On Thu, 05 Aug 2021, Kuogee Hsieh wrote: > add fixes to pass DP Link Layer compliance test cases Nitpick, please also include the approriate subject prefix to the cover letter, e.g. "drm/msm" or "drm/msm/dp". Helps with mail filtering. :) BR, Jani. > > Kuogee Hsieh (6): > drm/msm/dp: use