Re: [Freedreno] [PATCH v2 00/22] drm/msm/dpu: switch dpu_plane to be virtual

2021-09-30 Thread Dmitry Baryshkov
Hi, On Thu, 30 Sept 2021 at 05:19, wrote: > > Hi Dmitry > > On 2021-07-04 18:20, Dmitry Baryshkov wrote: > > As discussed on IRC, change dpu_plane implementation to be virtual: > > register unified planes and select backing SSPP block at runtime. > > > > Use msm.dpu_use_virtual_planes=1 to enable

Re: [Freedreno] [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-09-30 Thread mkrishn
On 2021-08-19 01:27, Stephen Boyd wrote: Quoting Krishna Manikandan (2021-08-18 03:27:02) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 53a21d0..fd7ff1c 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi

[Freedreno] [PATCH 01/11] drm/msm/dpu: move LUT levels out of QOS config

2021-09-30 Thread Dmitry Baryshkov
LUT levels are setup outside of setup_qos_ctrl, so remove them from the struct dpu_hw_pipe_qos_cfg. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 15 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 16 ++-- drivers/gpu/drm/msm/disp/dp

[Freedreno] [PATCH 03/11] drm/msm/dpu: drop pipe_name from struct dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Use plane->name instead of artificial pipe_name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index

[Freedreno] [PATCH 05/11] drm/msm/dpu: move dpu_hw_pipe_cfg out of struct dpu_plane

2021-09-30 Thread Dmitry Baryshkov
struct dpu_hw_pipe_cfg represents an interim state during atomic update/color fill, so move it out of struct dpu_plane. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 104 -- 1 file changed, 57 insertions(+), 47 deletions(-) diff --git a/driv

[Freedreno] [PATCH 00/11] drm/msm/dpu: cleanup plane state

2021-09-30 Thread Dmitry Baryshkov
This is a cleanup part of the DPU multirect patchset [1], split away to ease review and merging per Abhinav's request. Currently significant part of atomic plane state is stored in the drm_plane's subclass rather than drm_plane_state's subclass. Move it either to the drm_plane_state or even to the

[Freedreno] [PATCH 04/11] drm/msm/dpu: remove stage_cfg from struct dpu_crtc

2021-09-30 Thread Dmitry Baryshkov
The stage_cfg is not used outside of _dpu_crtc_blend_setup(), so remove the temporary config from global struct. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 11 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 2 -- 2 files changed, 6 insertions(+), 7 de

[Freedreno] [PATCH 08/11] drm/msm/dpu: remove dpu_hw_pipe_cdp_cfg from dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Remove struct dpu_hw_pipe_cdp_cfg instance from dpu_plane, it is an interim configuration structure. Allocate it on stack instead. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 14 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h | 2 -- 2 files changed

[Freedreno] [PATCH 07/11] drm/msm/dpu: drop dpu_csc_cfg from dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Simplify code surrounding CSC table setup by removing struct dpu_csc_cfg pointer from dpu_plane and getting it directly at the CSC setup time. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 +- drivers/gpu

[Freedreno] [PATCH 10/11] drm/msm/dpu: don't cache pipe->cap->sblk in dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Do not cache hw_pipe's sblk in dpu_plane. Use pdpu->pipe_hw->cap->sblk directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 25 --- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b

[Freedreno] [PATCH 09/11] drm/msm/dpu: don't cache pipe->cap->features in dpu_plane

2021-09-30 Thread Dmitry Baryshkov
Do not cache hw_pipe's features in dpu_plane. Use pdpu->pipe_hw->cap->features directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/dri

[Freedreno] [PATCH 06/11] drm/msm/dpu: drop scaler config from plane state

2021-09-30 Thread Dmitry Baryshkov
Scaler and pixel_ext configuration does not contain a long living state, it is used only during plane update, so remove these two fiels from dpu_plane_state and allocate them on stack. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 59 ++- dri

[Freedreno] [PATCH 11/11] drm/msm/dpu: rip out debugfs support from dpu_plane

2021-09-30 Thread Dmitry Baryshkov
In preparations of virtualizing the dpu_plane rip out debugfs support from dpu_plane (as it is mostly used to expose plane's pipe registers). Also move disable_danger file to danger/ debugfs subdir where it belongs. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c |

[Freedreno] [PATCH 02/11] drm/msm/dpu: remove pipe_qos_cfg from struct dpu_plane

2021-09-30 Thread Dmitry Baryshkov
The pipe_qos_cfg is used only in _dpu_plane_set_qos_ctrl(), so remove it from the dpu_plane struct and allocate it on stack when necessary. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 30 --- 1 file changed, 16 insertions(+), 14 deletions(-

Re: [Freedreno] [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-09-30 Thread Stephen Boyd
Quoting mkri...@codeaurora.org (2021-09-30 04:56:59) > On 2021-08-19 01:27, Stephen Boyd wrote: > > Quoting Krishna Manikandan (2021-08-18 03:27:02) > >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> index 53a21d0..fd7ff1c 100644 > >> --- a/arch/

[Freedreno] [PATCH] drm/msm/a6xx: Track current ctx by seqno

2021-09-30 Thread Rob Clark
From: Rob Clark In theory a context can be destroyed and a new one allocated at the same address, making the pointer comparision to detect when we don't need to update the current pagetables invalid. Instead assign a sequence number to each context on creation, and use this for the check. Fixes

Re: [Freedreno] [PATCH] drm/msm/a6xx: Track current ctx by seqno

2021-09-30 Thread Daniel Vetter
On Thu, Sep 30, 2021 at 8:20 PM Rob Clark wrote: > > From: Rob Clark > > In theory a context can be destroyed and a new one allocated at the same > address, making the pointer comparision to detect when we don't need to > update the current pagetables invalid. Instead assign a sequence number >

Re: [Freedreno] [PATCH] drm/msm/a6xx: Track current ctx by seqno

2021-09-30 Thread Rob Clark
On Thu, Sep 30, 2021 at 11:34 AM Daniel Vetter wrote: > > On Thu, Sep 30, 2021 at 8:20 PM Rob Clark wrote: > > > > From: Rob Clark > > > > In theory a context can be destroyed and a new one allocated at the same > > address, making the pointer comparision to detect when we don't need to > > upda

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-30 Thread Amit Pundir
On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: > > On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: > > > > On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: > > > On Wed, Sep 29, 2021 at 2:27 PM John Stultz > > > wrote: > > > > On Fri, Sep 10, 2021 at 3:12 AM Maxime Ripard wrote: > > > >

Re: [Freedreno] [PATCH v4 00/24] drm/bridge: Make panel and bridge probe order consistent

2021-09-30 Thread Caleb Connolly
Hi, On 30/09/2021 20:49, Amit Pundir wrote: On Thu, 30 Sept 2021 at 04:50, Rob Clark wrote: On Wed, Sep 29, 2021 at 2:51 PM John Stultz wrote: On Wed, Sep 29, 2021 at 2:32 PM John Stultz wrote: On Wed, Sep 29, 2021 at 2:27 PM John Stultz wrote: On Fri, Sep 10, 2021 at 3:12 AM Maxime Ri

Re: [Freedreno] [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-09-30 Thread mkrishn
On 2021-09-30 23:28, Stephen Boyd wrote: Quoting mkri...@codeaurora.org (2021-09-30 04:56:59) On 2021-08-19 01:27, Stephen Boyd wrote: > Quoting Krishna Manikandan (2021-08-18 03:27:02) >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 53a21d