Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Saravana Kannan (2021-10-07 18:32:20) > On Thu, Oct 7, 2021 at 6:24 PM Stephen Boyd wrote: > > > > Anyway, I think we still have to do a rescan so that we can try to bind > > the aggregate device. Is there a better API to use for that? > > If you know the exact device, you could call devic

Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Saravana Kannan (2021-10-07 18:10:24) > On Thu, Oct 7, 2021 at 1:11 PM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2021-10-07 11:40:07) > > > Quoting Saravana Kannan (2021-10-06 20:07:11) > > > > On Wed, Oct 6, 2021 at 12:38 PM Stephen Boyd > > > > wrote: > > > > > diff --git a/dri

Re: [Freedreno] [PATCH v2 15/34] drm/ingenic: Migrate to aggregate driver

2021-10-07 Thread Paul Cercueil
Hi Stephen, Le mer., oct. 6 2021 at 12:38:00 -0700, Stephen Boyd a écrit : Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: Move the hel

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-10-07 13:28:12) > On 2021-10-07 13:06, Bjorn Andersson wrote: > > On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote: > > > >> On 2021-10-06 10:31, Bjorn Andersson wrote: > >> > On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: > >> > > >> > > On

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-07 Thread abhinavk
Hi Bjorn and Stephen On 2021-10-06 13:39, Bjorn Andersson wrote: On Wed 06 Oct 11:59 PDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-10-06 11:05:09) > On Wed 06 Oct 10:19 PDT 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-10-06 10:07:17) > > > On Tue 05 Oct 21:26 PDT

Re: [Freedreno] [PATCH v2 00/34] component: Make into an aggregate bus

2021-10-07 Thread Stephen Boyd
Quoting Andrzej Hajda (2021-10-07 03:16:27) > Hi Stephen, > > On 06.10.2021 21:37, Stephen Boyd wrote: > > This series is from discussion we had on reordering the device lists for > > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > > the aggregate device onto and then we pro

Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Greg Kroah-Hartman (2021-10-06 22:37:40) > On Wed, Oct 06, 2021 at 12:37:47PM -0700, Stephen Boyd wrote: > > > > Let's make the component driver into an actual device driver that has > > probe/remove/shutdown functions. The driver will only be bound to the > > aggregate device once all comp

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread khsieh
On 2021-10-07 13:06, Bjorn Andersson wrote: On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-06 10:31, Bjorn Andersson wrote: > On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: > > > On 2021-10-05 19:10, Bjorn Andersson wrote: > > > On Tue 05 Oct 16:04 PDT 2021, k

Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Stephen Boyd (2021-10-07 11:40:07) > Quoting Saravana Kannan (2021-10-06 20:07:11) > > On Wed, Oct 6, 2021 at 12:38 PM Stephen Boyd wrote: > > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > > index 0a41bbe14981..d99e99cabb99 100644 > > > --- a/drivers/base/component

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread Bjorn Andersson
On Thu 07 Oct 12:51 PDT 2021, khs...@codeaurora.org wrote: > On 2021-10-06 10:31, Bjorn Andersson wrote: > > On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: > > > > > On 2021-10-05 19:10, Bjorn Andersson wrote: > > > > On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: > > > >

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-07 Thread khsieh
On 2021-10-06 10:31, Bjorn Andersson wrote: On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-05 19:10, Bjorn Andersson wrote: > On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: > > > On 2021-10-05 15:36, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-10-0

[Freedreno] [PATCH v3 20/20] drm: cleanup: remove acquire_ctx from drm_mode_config

2021-10-07 Thread Fernando Ramos
--- include/drm/drm_mode_config.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h index 48b7de80daf5..b214b07157f2 100644 --- a/include/drm/drm_mode_config.h +++ b/include/drm/drm_mode_config.h @@ -383,16 +383,6 @@ struct

[Freedreno] [PATCH v3 19/20] drm: cleanup: remove drm_modeset_(un)lock_all()

2021-10-07 Thread Fernando Ramos
Functions drm_modeset_lock_all() and drm_modeset_unlock_all() are no longer used anywhere and can be removed. Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_modeset_lock.c | 94 +- include/drm/drm_modeset_lock.h | 2 - 2 files changed, 3 insertions(+), 93

[Freedreno] [PATCH v3 18/20] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 3]

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() NOTE: While this change is similar to the one done two commits ago, it contains an important extra nuances that I'm going to explain next. T

[Freedreno] [PATCH v3 17/20] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 2]

2021-10-07 Thread Fernando Ramos
Refactor places using drm_modeset_{lock,unlock}_all() so that they only appear once per function. This is needed so that in the next commit I can replace those functions by the new macros (which use labels that can only appear once per function). Signed-off-by: Fernando Ramos --- .../gpu/drm/am

[Freedreno] [PATCH v3 16/20] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 21 ++--- 1 file changed, 14 insertions(+),

[Freedreno] [PATCH v3 15/20] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/gma500/psb_device.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions

[Freedreno] [PATCH v3 14/20] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 3]

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() NOTE: While the previous two commits were a simple "search and replace", this time I had to do a bit of refactoring as only one call to DRM_M

[Freedreno] [PATCH v3 13/20] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() [part 2]

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() NOTE: I separated this change from the rest of modifications to the i915 driver to point out something special explained next. The only diff

[Freedreno] [PATCH v3 12/20] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/i915/display/intel_audio.c| 16 --- .../drm/i915/display/intel_display_debugfs.c

[Freedreno] [PATCH v3 11/20] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

[Freedreno] [PATCH v3 10/20] drm/nouveau: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 15 ++- 1 file changed, 10 i

[Freedreno] [PATCH v3 09/20] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/omapdrm/omap_fb.c | 9 ++--- 1 file changed, 6 insertions(+),

[Freedreno] [PATCH v3 08/20] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/radeon/radeon_device.c | 21 +++-- drivers/gpu/drm/radeon/radeon_dp_mst.c

[Freedreno] [PATCH v3 07/20] drm/shmobile: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 6 -- 1 file changed, 4 insertions(

[Freedreno] [PATCH v3 06/20] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/tegra/dsi.c | 6 -- drivers/

[Freedreno] [PATCH v3 05/20] drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 11 +++ drivers/gpu/drm/vmwgfx/vmw

[Freedreno] [PATCH v3 04/20] drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_client_modeset.c | 5 +++-- drivers/gpu/drm/drm_crtc_helper.c

[Freedreno] [PATCH v3 03/20] drm/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/msm/disp/msm_

[Freedreno] [PATCH v3 02/20] drm/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_display.c | 18 +--

[Freedreno] [PATCH v3 01/20] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

2021-10-07 Thread Fernando Ramos
As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_client_modeset.c | 9 +++-- 1 file changed, 3 insertions(+),

[Freedreno] [PATCH v3 00/20] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers

2021-10-07 Thread Fernando Ramos
Hi all, One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this patch series is about. You will find two types of changes here: - Replacing "drm_modeset_lock_all_ctx()" (and surrounding boilerpl

[Freedreno] [PATCH v2] drm/msm/dp: Simplify the dp_debug debugfs show function

2021-10-07 Thread Bjorn Andersson
The "dp_debug" show function allocates a buffer and piecemeal appends line by line, checking for buffer overflows etc. Migrate the function to seq_file, to remove all the extra book keeping and simplify the function. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v1

Re: [Freedreno] [PATCH] drm/msm/dp: Simplify the dp_debug debugfs show function

2021-10-07 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-10-07 11:33:41) > The "dp_debug" show function allocates a buffer and piecemeal appends > line by line, checking for buffer overflows etc. > > Migrate the function to seq_file, to remove all the extra book keeping > and simplify the function. > > Signed-off-by: Bjorn A

Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-07 Thread Stephen Boyd
Quoting Saravana Kannan (2021-10-06 20:07:11) > On Wed, Oct 6, 2021 at 12:38 PM Stephen Boyd wrote: > > diff --git a/drivers/base/component.c b/drivers/base/component.c > > index 0a41bbe14981..d99e99cabb99 100644 > > --- a/drivers/base/component.c > > +++ b/drivers/base/component.c [...] > > +

Re: [Freedreno] [PATCH v2 01/34] component: Introduce struct aggregate_device

2021-10-07 Thread Stephen Boyd
Quoting Laurent Pinchart (2021-10-06 18:17:25) > Hi Stephen, > > Thank you for the patch. > > On Wed, Oct 06, 2021 at 12:37:46PM -0700, Stephen Boyd wrote: > > Replace 'struct master' with 'struct aggregate_device' and then rename > > 'master' to 'adev' everywhere in the code. While we're here, put

[Freedreno] [PATCH] drm/msm/dp: Simplify the dp_debug debugfs show function

2021-10-07 Thread Bjorn Andersson
The "dp_debug" show function allocates a buffer and piecemeal appends line by line, checking for buffer overflows etc. Migrate the function to seq_file, to remove all the extra book keeping and simplify the function. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_debug.c | 161 +++

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-07 Thread Bjorn Andersson
On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: > Hi guys, > > On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > > (CC+ Heikki) > > > > Hi, > > > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Oct 5, 2021 at 7:27 PM Bjorn Anderss

[Freedreno] [PATCH v2 2/2] qcom_scm: hide Kconfig symbol

2021-10-07 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_available'

[Freedreno] [PATCH v2 1/2] firmware: include drivers/firmware/Kconfig unconditionally

2021-10-07 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing drivers that require access to a firmware layer fails when that firmware symbol is unavailable. This happened twice this week: - My proposed to change to rework the QCOM_SCM firmware symbol broke on ppc64 and others. - The cs_dsp firmware patch added dev

Re: [Freedreno] [PATCH] drm/msm: fix compilation when COMMON_CLK is disabled

2021-10-07 Thread Alex Deucher
On Thu, Oct 7, 2021 at 5:13 AM Christian König wrote: > > We can't even compile test without this > > Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/msm/Kconfig | 2 +- > 1 file changed, 1 insertion(+

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-07 Thread Heikki Krogerus
Hi guys, On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > (CC+ Heikki) > > Hi, > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson > > wrote: > > > > > > > > For reference, this is how I thought one is sup

Re: [Freedreno] [PATCH v2 00/34] component: Make into an aggregate bus

2021-10-07 Thread Andrzej Hajda
On 07.10.2021 13:22, Andy Shevchenko wrote: On Wednesday, October 6, 2021, Stephen Boyd > wrote: This series is from discussion we had on reordering the device lists for drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put the aggregate

Re: [Freedreno] [PATCH v2 00/34] component: Make into an aggregate bus

2021-10-07 Thread Andrzej Hajda
Hi Stephen, On 06.10.2021 21:37, Stephen Boyd wrote: This series is from discussion we had on reordering the device lists for drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put the aggregate device onto and then we probe the aggregate device once all the components are probed

Re: [Freedreno] [PATCH v2 00/34] component: Make into an aggregate bus

2021-10-07 Thread Andy Shevchenko
On Wednesday, October 6, 2021, Stephen Boyd wrote: > This series is from discussion we had on reordering the device lists for > drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put > the aggregate device onto and then we probe the aggregate device once > all the components are pr

Re: [Freedreno] [PATCH v2 31/34] ASoC: codecs: wcd938x: Migrate to aggregate driver

2021-10-07 Thread Mark Brown
On Wed, Oct 06, 2021 at 12:38:16PM -0700, Stephen Boyd wrote: > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to all > the component devices that make up the aggregate device. Acked-by: Mark Brown signatur

Re: [Freedreno] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-07 Thread Geert Uytterhoeven
Hi Christian, On Wed, Oct 6, 2021 at 9:28 AM Christian König wrote: > Am 06.10.21 um 09:20 schrieb Stephen Rothwell: > > On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap > > wrote: > >> on i386: > >> > >> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined > >> reference to `msm_h

[Freedreno] [PATCH] drm/msm: fix compilation when COMMON_CLK is disabled

2021-10-07 Thread Christian König
We can't even compile test without this Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") Signed-off-by: Christian König --- drivers/gpu/drm/msm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index 5

[Freedreno] [PATCH v2 11/11] drm/msm/dsi: Pass DSC params to drm_panel

2021-10-07 Thread Vinod Koul
When DSC is enabled, we need to pass the DSC parameters to panel driver as well, so add a dsc parameter in panel and set it when DSC is enabled Signed-off-by: Vinod Koul --- drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++- include/drm/drm_panel.h| 7 +++ 2 files changed

[Freedreno] [PATCH v2 10/11] drm/msm/dsi: Add support for DSC configuration

2021-10-07 Thread Vinod Koul
When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-off-by: Vinod Koul --- drivers/gpu/drm/ms

[Freedreno] [PATCH v2 09/11] drm/msm/disp/dpu1: Add support for DSC in topology

2021-10-07 Thread Vinod Koul
For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. Also, it is better to use 2 LMs and DSC instances as half width results in lesser power consumption as compared to single LM, DSC at full width. The

[Freedreno] [PATCH v2 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-10-07 Thread Vinod Koul
We need to configure the encoder for DSC configuration and calculate DSC parameters for the given timing so this patch adds that support by adding dpu_encoder_prep_dsc() which is invoked when DSC is enabled. Signed-off-by: Vinod Koul --- Changes since v1: - Remove duplicate defines - Update cha

[Freedreno] [PATCH v2 07/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-07 Thread Vinod Koul
Later gens of hardware have DSC bits moved to hw_ctl, so configure these bits so that DSC would work there as well Signed-off-by: Vinod Koul --- Changes since v1: - Move this patch from 6 to 7 due to dependency on 6th one - Use DSC indices for programming DSC registers and program only on non

[Freedreno] [PATCH v2 06/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-07 Thread Vinod Koul
We cannot enable mode_3d when we are using the DSC. So pass configuration to detect DSC is enabled and not enable mode_3d when we are using DSC We add a helper dpu_encoder_helper_get_dsc_mode() to detect dsc enabled and pass this to .setup_intf_cfg() Signed-off-by: Vinod Koul --- Changes since v

[Freedreno] [PATCH v2 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-07 Thread Vinod Koul
This adds SDM845 DSC blocks into hw_catalog Signed-off-by: Vinod Koul --- Changes since v1: - Remove DSC_SDM845_MASK and use 0 as feature mask .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 20 +++ 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dp

[Freedreno] [PATCH v2 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-07 Thread Vinod Koul
This add the bits in RM to enable the DSC blocks Signed-off-by: Vinod Koul --- Changes since v1: - Add _dpu_rm_reserve_dsc() function which checks if DSC is enabled - Fix to use dsc_blks drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 61 +

[Freedreno] [PATCH v2 03/11] drm/msm/disp/dpu1: Add support for DSC in pingpong block

2021-10-07 Thread Vinod Koul
In SDM845, DSC can be enabled by writing to pingpong block registers, so add support for DSC in hw_pp Reviewed-by: Abhinav Kumar Signed-off-by: Vinod Koul --- .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 32 +++ .../gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 2 f

[Freedreno] [PATCH v2 02/11] drm/msm/disp/dpu1: Add support for DSC

2021-10-07 Thread Vinod Koul
Display Stream Compression (DSC) is one of the hw blocks in dpu, so add support by adding hw blocks for DSC Signed-off-by: Vinod Koul --- Changes since v1: - remove unused variable lp - Update copyright year RFC: - Drop unused enums drivers/gpu/drm/msm/Makefile | 1 + .../

[Freedreno] [PATCH v2 01/11] drm/msm/dsi: add support for dsc data

2021-10-07 Thread Vinod Koul
Display Stream Compression (DSC) parameters need to be calculated. Add helpers and struct msm_display_dsc_config in msm_drv for this msm_display_dsc_config uses drm_dsc_config for DSC parameters. Signed-off-by: Vinod Koul --- Changes since v1: - Drop unused fields from msm_display_dsc_config RFC

[Freedreno] [PATCH v2 00/11] drm/msm: Add Display Stream Compression Support

2021-10-07 Thread Vinod Koul
Display Stream Compression (DSC) compresses the display stream in host which is later decoded by panel. This series enables this for Qualcomm msm driver. This was tested on Google Pixel3 phone which use LGE SW43408 panel. The changes include DSC data and hardware block enabling for DPU1 then supp