Re: [Freedreno] [PATCH 11/11] drm/msm/dpu: rip out debugfs support from dpu_plane

2021-10-21 Thread abhinavk
On 2021-09-30 07:00, Dmitry Baryshkov wrote: In preparations of virtualizing the dpu_plane rip out debugfs support from dpu_plane (as it is mostly used to expose plane's pipe registers). Also move disable_danger file to danger/ debugfs subdir where it belongs. Signed-off-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH 10/11] drm/msm/dpu: don't cache pipe->cap->sblk in dpu_plane

2021-10-21 Thread abhinavk
On 2021-09-30 07:00, Dmitry Baryshkov wrote: Do not cache hw_pipe's sblk in dpu_plane. Use pdpu->pipe_hw->cap->sblk directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 25 --- 1 file changed, 8

Re: [Freedreno] [PATCH 09/11] drm/msm/dpu: don't cache pipe->cap->features in dpu_plane

2021-10-21 Thread abhinavk
On 2021-09-30 07:00, Dmitry Baryshkov wrote: Do not cache hw_pipe's features in dpu_plane. Use pdpu->pipe_hw->cap->features directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 +--- 1 file changed, 5 insertions(+),

Re: [Freedreno] [PATCH 08/11] drm/msm/dpu: remove dpu_hw_pipe_cdp_cfg from dpu_plane

2021-10-21 Thread abhinavk
On 2021-09-30 06:59, Dmitry Baryshkov wrote: Remove struct dpu_hw_pipe_cdp_cfg instance from dpu_plane, it is an interim configuration structure. Allocate it on stack instead. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 14

Re: [Freedreno] [PATCH 07/11] drm/msm/dpu: drop dpu_csc_cfg from dpu_plane

2021-10-21 Thread abhinavk
On 2021-09-30 06:59, Dmitry Baryshkov wrote: Simplify code surrounding CSC table setup by removing struct dpu_csc_cfg pointer from dpu_plane and getting it directly at the CSC setup time. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

Re: [Freedreno] [PATCH 06/11] drm/msm/dpu: drop scaler config from plane state

2021-10-21 Thread abhinavk
On 2021-09-30 06:59, Dmitry Baryshkov wrote: Scaler and pixel_ext configuration does not contain a long living state, it is used only during plane update, so remove these two fiels from fiels ---> fields dpu_plane_state and allocate them on stack. Signed-off-by: Dmitry Baryshkov While

Re: [Freedreno] [PATCH 05/11] drm/msm/dpu: move dpu_hw_pipe_cfg out of struct dpu_plane

2021-10-21 Thread abhinavk
On 2021-09-30 06:59, Dmitry Baryshkov wrote: struct dpu_hw_pipe_cfg represents an interim state during atomic update/color fill, so move it out of struct dpu_plane. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 104

Re: [Freedreno] [PATCH 04/11] drm/msm/dpu: remove stage_cfg from struct dpu_crtc

2021-10-21 Thread abhinavk
On 2021-09-30 06:59, Dmitry Baryshkov wrote: The stage_cfg is not used outside of _dpu_crtc_blend_setup(), so remove the temporary config from global struct. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 11 ++-

Re: [Freedreno] [PATCH 01/11] drm/msm/dpu: move LUT levels out of QOS config

2021-10-21 Thread abhinavk
On 2021-09-30 06:59, Dmitry Baryshkov wrote: LUT levels are setup outside of setup_qos_ctrl, so remove them from the struct dpu_hw_pipe_qos_cfg. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 15 ---

Re: [Freedreno] [PATCH] drm/msm/dsi: use bulk clk API

2021-10-21 Thread abhinavk
On 2021-10-01 18:27, Dmitry Baryshkov wrote: Use clk_bulk_* API instead of hand-coding them. Note, this drops support for legacy clk naming (e.g. "iface_clk" instead of just "iface"), however all in-kernel device trees were converted long long ago. The warning is present there since 2017.

Re: [Freedreno] [PATCH v2 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:52) > Add DSI controller and PHY nodes for sc7280. > > Signed-off-by: Rajeev Nandan > Signed-off-by: Krishna Manikandan > Reviewed-by: Matthias Kaehlcke > > Changes in v2: > - Drop flags from interrupts (Stephen Boyd) > - Rename dsi-opp-table

Re: [Freedreno] [PATCH v2 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:53) > From: Sankeerth Billakanti > > Add edp controller and phy DT nodes for sc7280. > > Signed-off-by: Sankeerth Billakanti > Signed-off-by: Krishna Manikandan > Some comments below Reviewed-by: Stephen Boyd > Changes in v2: > - Move

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:51) > Add mdss and mdp DT nodes for sc7280. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Rename display dt nodes (Stephen Boyd) > - Add clock names one per line for readability (Stephen Boyd) > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-10-21 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-10-20 06:58:50) > MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI, EDP etc. Add required DPU > device tree bindings for SC7280. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Drop target from

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dp: Add support for SC7280 eDP

2021-10-21 Thread Stephen Boyd
Quoting Sankeerth Billakanti (2021-10-20 05:14:10) > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c > b/drivers/gpu/drm/msm/dp/dp_ctrl.c > index 62e75dc..9fea49c 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c > @@ -1238,9 +1240,21 @@ static int

Re: [Freedreno] [PATCH v5 21/21] drm/msm/dsi: Adjust probe order

2021-10-21 Thread Rob Clark
On Thu, Oct 21, 2021 at 12:41 AM Maxime Ripard wrote: > > From: Rob Clark > > Switch to the documented order dsi-host vs bridge probe. > > Tested-by: Amit Pundir > Tested-by: Caleb Connolly > Tested-by: John Stultz > Signed-off-by: Rob Clark > Signed-off-by: Maxime Ripard I guess this

Re: [Freedreno] [PATCH v5 00/21] drm/bridge: Make panel and bridge probe order consistent

2021-10-21 Thread Sam Ravnborg
Hi Maxime, > Let me know what you think, apply the lot to drm-misc-next. Maybe wait for an r-b or a-b on the kirin patch but the rest is IMO good to go. Sam

Re: [Freedreno] [PATCH v5 13/21] drm/bridge: sn65dsi83: Fix bridge removal

2021-10-21 Thread Sam Ravnborg
On Thu, Oct 21, 2021 at 09:39:39AM +0200, Maxime Ripard wrote: > Commit 24417d5b0c00 ("drm/bridge: ti-sn65dsi83: Implement .detach > callback") moved the unregistration of the bridge DSI device and bridge > itself to the detach callback. > > While this is correct for the DSI device detach and

Re: [Freedreno] [PATCH v3 13/13] drm/i915: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

2021-10-21 Thread Ville Syrjälä
On Wed, Oct 20, 2021 at 12:51:21AM +0200, Claudio Suarez wrote: > drm_get_edid() internally calls to drm_connector_update_edid_property() > and then drm_add_display_info(), which parses the EDID. > This happens in the function intel_hdmi_set_edid() and > intel_sdvo_tmds_sink_detect() (via

Re: [Freedreno] [PATCH v2 2/2] dt-bindings: Add SC7280 compatible string

2021-10-21 Thread quic_sbillaka
Hi Doug, Sorry about that, this is the first time I am posting changes upstream and still getting hold of conventions. I think I misinterpreted your subject line comment and changed the just title to include dp-controller. I will correct it in the next version. sc7280-dp will be added later

Re: [Freedreno] [PATCH 0/2] drm/msm: fix build error

2021-10-21 Thread yanteng si
Yanteng Si 于2021年10月14日周四 下午4:51写道: > > Include linux/vmalloc.h to fix below errors: > > error: implicit declaration of function 'vmap'; > error: implicit declaration of function 'register_vmap_purge_notifier' > error: implicit declaration of function 'unregister_vmap_purge_notifier' > > Yanteng

[Freedreno] [PATCH v5 14/21] drm/bridge: sn65dsi83: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge but don't remove its driver. Acked-by: Sam Ravnborg Tested-by: Laurent Pinchart Signed-off-by: Maxime Ripard ---

[Freedreno] [PATCH v5 18/21] drm/bridge: tc358775: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 13 - 1 file changed, 4

[Freedreno] [PATCH v5 11/21] drm/bridge: ps8640: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device on removal. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 15 +-- 1 file changed, 5 insertions(+), 10

[Freedreno] [PATCH v5 12/21] drm/bridge: ps8640: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/parade-ps8640.c | 100

[Freedreno] [PATCH v5 21/21] drm/msm/dsi: Adjust probe order

2021-10-21 Thread Maxime Ripard
From: Rob Clark Switch to the documented order dsi-host vs bridge probe. Tested-by: Amit Pundir Tested-by: Caleb Connolly Tested-by: John Stultz Signed-off-by: Rob Clark Signed-off-by: Maxime Ripard --- drivers/gpu/drm/msm/dsi/dsi.c | 50 ---

[Freedreno] [PATCH v5 16/21] drm/bridge: sn65dsi86: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 22 +++--- 1 file changed,

[Freedreno] [PATCH v5 15/21] drm/bridge: sn65dsi83: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: Laurent Pinchart Signed-off-by: Maxime Ripard ---

[Freedreno] [PATCH v5 10/21] drm/bridge: lt9611uxc: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 31

[Freedreno] [PATCH v5 17/21] drm/bridge: sn65dsi86: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 77

[Freedreno] [PATCH v5 13/21] drm/bridge: sn65dsi83: Fix bridge removal

2021-10-21 Thread Maxime Ripard
Commit 24417d5b0c00 ("drm/bridge: ti-sn65dsi83: Implement .detach callback") moved the unregistration of the bridge DSI device and bridge itself to the detach callback. While this is correct for the DSI device detach and unregistration, the bridge is added in the driver probe, and should thus be

[Freedreno] [PATCH v5 19/21] drm/bridge: tc358775: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/tc358775.c | 37

[Freedreno] [PATCH v5 04/21] drm/bridge: anx7625: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20

[Freedreno] [PATCH v5 01/21] drm/bridge: adv7533: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. This also avoids leaking the device when we detach the bridge. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 -

[Freedreno] [PATCH v5 08/21] drm/bridge: lt9611: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard ---

[Freedreno] [PATCH v5 03/21] drm/bridge: anx7625: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/analogix/anx7625.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git

[Freedreno] [PATCH v5 09/21] drm/bridge: lt9611uxc: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 38 +- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git

[Freedreno] [PATCH v5 06/21] drm/bridge: lt8912b: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 11

[Freedreno] [PATCH v5 00/21] drm/bridge: Make panel and bridge probe order consistent

2021-10-21 Thread Maxime Ripard
Hi, We've encountered an issue with the RaspberryPi DSI panel that prevented the whole display driver from probing. The issue is described in detail in the commit 7213246a803f ("drm/vc4: dsi: Only register our component once a DSI device is attached"), but the basic idea is that since the panel

[Freedreno] [PATCH v5 07/21] drm/bridge: lt9611: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 24 1 file changed, 4 insertions(+), 20 deletions(-)

[Freedreno] [PATCH v5 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-10-21 Thread Maxime Ripard
In order to avoid any probe ordering issue, the best practice is to move the secondary MIPI-DSI device registration and attachment to the MIPI-DSI host at probe time. Let's do this. Acked-by: Sam Ravnborg Tested-by: John Stultz Signed-off-by: Maxime Ripard ---

[Freedreno] [PATCH v5 05/21] drm/bridge: lt8912b: Switch to devm MIPI-DSI helpers

2021-10-21 Thread Maxime Ripard
Let's switch to the new devm MIPI-DSI function to register and attach our secondary device. Acked-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git