Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-05 10:28:11) > From: Kuogee Hsieh > > Combo phy supports both USB and DP simultaneously. There may has a > possible conflict during phy initialization phase between USB and > DP driver which may cause USB phy timeout when USB tries to power > up its phy. This patch ha

Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-11-05 10:48:37) > On Fri 05 Nov 10:28 PDT 2021, Kuogee Hsieh wrote: > > > From: Kuogee Hsieh > > > > Combo phy supports both USB and DP simultaneously. There may has a > > possible conflict during phy initialization phase between USB and > > DP driver which may cause

Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Kuogee Hsieh
On 11/5/2021 10:48 AM, Bjorn Andersson wrote: On Fri 05 Nov 10:28 PDT 2021, Kuogee Hsieh wrote: From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout w

Re: [Freedreno] [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Akhil P Oommen
On 11/6/2021 1:50 AM, Rob Clark wrote: From: Rob Clark Reported-by: Douglas Anderson Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfr

[Freedreno] [PATCH v2] drm/msm/dp: employ bridge mechanism for display enable and disable

2021-11-05 Thread Kuogee Hsieh
Currently the msm_dp_*** functions implement the same sequence which would happen when drm_bridge is used. hence get rid of this intermediate layer and align with the drm_bridge usage to avoid customized implementation. Signed-off-by: Kuogee Hsieh Changes in v2: -- revise commit text -- rename d

Re: [Freedreno] [PATCH 2/2] drm/msm/gpu: Respect PM QoS constraints

2021-11-05 Thread Doug Anderson
Hi, On Wed, Nov 3, 2021 at 1:59 PM Rob Clark wrote: > > From: Rob Clark > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 31 +-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c > b/dr

Re: [Freedreno] [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Steev Klimaszewski
On 11/5/21 3:20 PM, Rob Clark wrote: From: Rob Clark Reported-by: Douglas Anderson Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfr

Re: [Freedreno] [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Doug Anderson
Hi, On Fri, Nov 5, 2021 at 1:15 PM Rob Clark wrote: > > From: Rob Clark > > Reported-by: Douglas Anderson > Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Dougl

[Freedreno] [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Rob Clark
From: Rob Clark Reported-by: Douglas Anderson Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq

Re: [Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Bjorn Andersson
On Fri 05 Nov 10:28 PDT 2021, Kuogee Hsieh wrote: > From: Kuogee Hsieh > > Combo phy supports both USB and DP simultaneously. There may has a > possible conflict during phy initialization phase between USB and > DP driver which may cause USB phy timeout when USB tries to power > up its phy. This

[Freedreno] [PATCH] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-11-05 Thread Kuogee Hsieh
From: Kuogee Hsieh Combo phy supports both USB and DP simultaneously. There may has a possible conflict during phy initialization phase between USB and DP driver which may cause USB phy timeout when USB tries to power up its phy. This patch has the DP driver not initialize its phy during DP drive

Re: [Freedreno] [PATCH] drm/msm/devfreq: Fix OPP refcnt leak

2021-11-05 Thread Doug Anderson
Hi, On Thu, Nov 4, 2021 at 9:32 PM Steev Klimaszewski wrote: > > > On 11/4/21 5:28 PM, Rob Clark wrote: > > From: Rob Clark > > > > Reported-by: Douglas Anderson > > Fixes: 9bc95570175a ("drm/msm: Devfreq tuning") > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/msm/msm_gpu_devfreq.c