Re: [Freedreno] [PATCH bpf v2] treewide: add missing includes masked by cgroup -> bpf dependency

2021-12-02 Thread Greg KH
On Thu, Dec 02, 2021 at 12:34:00PM -0800, Jakub Kicinski wrote: > cgroup.h (therefore swap.h, therefore half of the universe) > includes bpf.h which in turn includes module.h and slab.h. > Since we're about to get rid of that dependency we need > to clean things up. > > v2: drop the cpu.h include

Re: [Freedreno] [PATCH bpf v2] treewide: add missing includes masked by cgroup -> bpf dependency

2021-12-02 Thread Christoph Hellwig
Thanks, always good to see someone else helping to unwind our include dependency mess.. Reviewed-by: Christoph Hellwig

[Freedreno] [PATCH -next] drm: remove node from list before freeing the node

2021-12-02 Thread Yang Li
fix the following smatch warning: drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:1675 dpu_plane_init() warn: '>mplane_list' not removed from list Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received

2021-12-02 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-11-09 13:38:13) > From: Kuogee Hsieh > > Current DP drivers have regulators, clocks, irq and phy are grouped > together within a function and executed not in a symmetric manner. > This increase difficulty of code maintenance and limited code scalability. > This patch

Re: [Freedreno] [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-02 Thread Linus Walleij
On Thu, Dec 2, 2021 at 11:27 PM Stephen Boyd wrote: > drm/mcde: Migrate to aggregate driver This also works fine after the patch series. Tested-by: Linus Walleij Yours, Linus Walleij

Re: [Freedreno] [PATCH v4 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-12-02 Thread Linus Walleij
On Thu, Dec 2, 2021 at 11:27 PM Stephen Boyd wrote: > Use an aggregate driver instead of component ops so that we can get > proper driver probe ordering of the aggregate device with respect to all > the component devices that make up the aggregate device. > > Acked-by: Sebastian Reichel > Cc:

Re: [Freedreno] [PATCH v4] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-12-02 Thread Bjorn Andersson
On Tue 14 Sep 09:45 PDT 2021, Kuogee Hsieh wrote: $suject says "add support", but afaict the code already configures voltage and pre-emphasis swing. If I understand your change you're not adding support for the swing, but rather you make it possible to have different tables for different

Re: [Freedreno] [PATCH v4] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-12-02 Thread Stephen Boyd
Quoting Stephen Boyd (2021-09-14 12:49:13) > Quoting Kuogee Hsieh (2021-09-14 09:45:01) > > Both voltage and pre-emphasis swing level are set during link training > > negotiation between host and sink. There are totally four tables added. > > A voltage swing table for both hbr and hbr1, a voltage

[Freedreno] [PATCH v4 34/34] component: Remove component_master_ops and friends

2021-12-02 Thread Stephen Boyd
The struct is unused now so drop it along with the functions that use it. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 148

[Freedreno] [PATCH v4 32/34] mei: pxp: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Vitaly Lubart Cc: Tomas Winkler Cc: Daniele Ceraolo Spurio Cc: Rodrigo Vivi Cc: Daniel

[Freedreno] [PATCH v4 27/34] mei: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Tomas Winkler Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: "Rafael J.

[Freedreno] [PATCH v4 29/34] fbdev: omap2: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Cc: Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana

[Freedreno] [PATCH v4 33/34] component: Get rid of drm_of_component_probe()

2021-12-02 Thread Stephen Boyd
There aren't any users anymore so drop it. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_of.c | 85 +---

[Freedreno] [PATCH v4 26/34] iommu/mtk: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Yong Wu Cc: Joerg Roedel Cc: Will Deacon Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob

[Freedreno] [PATCH v4 30/34] sound: hdac: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Kai Vehmanen Cc: Daniel Vetter Cc: "Rafael J. Wysocki"

[Freedreno] [PATCH v4 31/34] ASoC: codecs: wcd938x: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Acked-by: Mark Brown Cc: Jaroslav Kysela Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob

[Freedreno] [PATCH v4 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Acked-by: Sebastian Reichel Cc: Cc: Daniel Vetter Cc: Linus Walleij Cc: "Rafael J. Wysocki"

[Freedreno] [PATCH v4 23/34] drm/sun4i: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[Freedreno] [PATCH v4 25/34] drm/vc4: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Emma Anholt Cc: Maxime Ripard Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[Freedreno] [PATCH v4 24/34] drm/tilcdc: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Tested-by: Jyri Sarha Cc: Tomi Valkeinen Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob

[Freedreno] [PATCH v4 21/34] drm/rockchip: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark

[Freedreno] [PATCH v4 22/34] drm/sti: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan

[Freedreno] [PATCH v4 19/34] drm/meson: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Neil Armstrong Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King

[Freedreno] [PATCH v4 20/34] drm/omap: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Tomi Valkeinen Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King

[Freedreno] [PATCH v4 15/34] drm/imx: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Philipp Zabel Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[Freedreno] [PATCH v4 12/34] drm/etnaviv: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: Daniel Vetter Cc: "Rafael J.

[Freedreno] [PATCH v4 17/34] drm/mcde: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan

[Freedreno] [PATCH v4 13/34] drm/kirin: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Xinliang Liu Cc: Tian Tao Cc: John Stultz Cc: Xinwei Kong Cc: Chen Feng Cc: Daniel Vetter

[Freedreno] [PATCH v4 18/34] drm/mediatek: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark

[Freedreno] [PATCH v4 16/34] drm/ingenic: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: Move the helpers to PM in aggregate driver hooks. Acked-by: Paul Cercueil Cc: Daniel Vetter

[Freedreno] [PATCH v4 11/34] drm/armada: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Russell King Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Saravana Kannan

[Freedreno] [PATCH v4 14/34] drm/exynos: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Daniel Vetter Cc:

[Freedreno] [PATCH v4 09/34] drm/arm/hdlcd: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[Freedreno] [PATCH v4 10/34] drm/malidp: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: This can be updated to move the drm helper logic into the aggregate driver shutdown op. Cc:

[Freedreno] [PATCH v4 07/34] drm/msm: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
The device lists are poorly ordered when the component device code is used. This is because component_master_add_with_match() returns 0 regardless of component devices calling component_add() first. It can really only fail if an allocation fails, in which case everything is going bad and we're out

[Freedreno] [PATCH v4 08/34] drm/komeda: Migrate to aggregate driver

2021-12-02 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: James Qian Wang (Arm Technology China) Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob

[Freedreno] [PATCH v4 06/34] drm/of: Add a drm_of_aggregate_probe() API

2021-12-02 Thread Stephen Boyd
Similar to drm_of_component_probe() but using the new API that registers a driver instead of an ops struct. This allows us to migrate the users of drm_of_component_probe() to the new way of doing things. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell

[Freedreno] [PATCH v4 04/34] component: Move struct aggregate_device out to header file

2021-12-02 Thread Stephen Boyd
This allows aggregate driver writers to use the device passed to their probe/remove/shutdown functions properly instead of treating it as an opaque pointer. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana

[Freedreno] [PATCH v4 05/34] component: Add {bind, unbind}_component() ops that take aggregate device

2021-12-02 Thread Stephen Boyd
We'd like to get more device model features in the component framework so let's pass the struct aggregate_device pointer instead of the parent device pointer to the component binding functions. This will allow drivers to inspect and control things related to the aggregate device in case they need

[Freedreno] [PATCH v4 03/34] component: Introduce the aggregate bus_type

2021-12-02 Thread Stephen Boyd
The component driver only provides 'bind' and 'unbind' callbacks to tell the host driver that it is time to assemble the aggregate driver now that all the components have probed. The component driver model doesn't attempt to resolve runtime PM or suspend/resume ordering, and explicitly mentions

[Freedreno] [PATCH v4 02/34] component: Remove most references to 'master'

2021-12-02 Thread Stephen Boyd
Remove most references to 'master' in the code now that we've decided to migrate all the users of the ops structure to the aggregate driver. Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Laurent Pinchart Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan

[Freedreno] [PATCH v4 01/34] component: Introduce struct aggregate_device

2021-12-02 Thread Stephen Boyd
Replace 'struct master' with 'struct aggregate_device' and then rename 'master' to 'adev' everywhere in the code. While we're here, put a struct device inside the aggregate device so that we can register it with a bus_type in the next patch. The diff is large but that's because this is mostly a

[Freedreno] [PATCH v4 00/34] component: Make into an aggregate bus

2021-12-02 Thread Stephen Boyd
This series is from discussion we had on reordering the device lists for drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put the aggregate device onto and then we probe the aggregate device once all the components are probed and call component_add(). The probe/remove hooks are

[Freedreno] [PATCH bpf v2] treewide: add missing includes masked by cgroup -> bpf dependency

2021-12-02 Thread Jakub Kicinski
cgroup.h (therefore swap.h, therefore half of the universe) includes bpf.h which in turn includes module.h and slab.h. Since we're about to get rid of that dependency we need to clean things up. v2: drop the cpu.h include from cacheinfo.h, it's not necessary and it makes riscv sensitive to