Re: [Freedreno] [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-07 Thread Greg Kroah-Hartman
On Mon, Feb 07, 2022 at 08:43:28PM -0800, Bjorn Andersson wrote: > The Qualcomm DisplayPort driver contains traces of the necessary > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > dp_usbpd_cb struct. Use this as basis for implementing the > oob_hotplug_event() callback, by

[Freedreno] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-07 Thread Bjorn Andersson
In some implementations, such as the Qualcomm platforms, the display driver has no way to query the current HPD state and as such it's impossible to distinguish between disconnect and attention events. Add a parameter to drm_connector_oob_hotplug_event() to pass the HPD state. Also push the test

[Freedreno] [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-07 Thread Bjorn Andersson
The Qualcomm DisplayPort driver contains traces of the necessary plumbing to hook up USB HPD, in the form of the dp_hpd module and the dp_usbpd_cb struct. Use this as basis for implementing the oob_hotplug_event() callback, by amending the dp_hpd module with the missing logic. Overall the solution

Re: [Freedreno] [PATCH -next] drm/msm/dpu: clean up some inconsistent indenting

2022-02-07 Thread Abhinav Kumar
On 2/7/2022 5:23 PM, Yang Li wrote: Eliminate the follow smatch warning: drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:411 _dpu_crtc_blend_setup_mixer() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/

[Freedreno] [PATCH -next] drm/msm/dpu: clean up some inconsistent indenting

2022-02-07 Thread Yang Li
Eliminate the follow smatch warning: drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:411 _dpu_crtc_blend_setup_mixer() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Freedreno] [PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

2022-02-07 Thread Doug Anderson
Hi, On Wed, Feb 2, 2022 at 1:54 PM Stephen Boyd wrote: > > Quoting Sankeerth Billakanti (2021-11-15 23:07:35) > > This series adds support for the eDP PHY on Qualcomm SC7280 platform. > > The changes are dependent on v4 of the new eDP PHY driver introduced by > > Bjorn: > > https://patchwork.ker

Re: [Freedreno] [PATCH 04/23] drm/msm/mdp5: Fix zpos initial value mismatch

2022-02-07 Thread Dmitry Baryshkov
On Mon, 7 Feb 2022 at 19:56, Maxime Ripard wrote: > > While the mdp5_plane_install_properties() function calls > drm_plane_create_zpos_property() with an initial value of 1, > mdp5_plane_reset() will force it to another value depending on the plane > type. > > Fix the discrepancy by setting the in

[Freedreno] [PATCH 04/23] drm/msm/mdp5: Fix zpos initial value mismatch

2022-02-07 Thread Maxime Ripard
While the mdp5_plane_install_properties() function calls drm_plane_create_zpos_property() with an initial value of 1, mdp5_plane_reset() will force it to another value depending on the plane type. Fix the discrepancy by setting the initial zpos value to the same value in the drm_plane_create_zpos_

[Freedreno] [PATCH 12/23] drm/msm/mdp5: Remove redundant zpos initialisation

2022-02-07 Thread Maxime Ripard
The mdp KMS driver will call drm_plane_create_zpos_property() with an init value depending on the plane purpose. Since the initial value wasn't carried over in the state, the driver had to set it again in mdp5_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so t