Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Doug Anderson
Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: > > > +static int dp_link_psr_status(struct dp_link_private *link) > > +{ > > + u8 status[2]; > > + > > + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2); > > + > > + if (status[0] & DP_PSR_LINK_CRC_ERROR) >

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 05:12:06) > Panels with higher refresh rate will need mdp clk above 300Mhz. > Select max frequency for mdp clock during bootup, dpu driver will > scale down the clock as per usecase when first update from the framework is > received. > > Signed-off-by: Vinod Poli

Re: [Freedreno] [PATCH] drm/msm/dp: switch to devm_drm_of_get_bridge

2022-02-22 Thread Stephen Boyd
Quoting José Expósito (2022-02-20 23:33:39) > The function "drm_of_find_panel_or_bridge" has been deprecated in > favor of "devm_drm_of_get_bridge". > > Switch to the new function and reduce boilerplate. > > Signed-off-by: José Expósito > --- Dmitry is rewriting this code in a larger series. This

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Bjorn Andersson
On Mon 21 Feb 06:51 PST 2022, Vinod Polimera wrote: > Add support for basic panel self refresh (PSR) feature for eDP. > Add a new interface to set PSR state in the sink from DPU. > Program the eDP controller to issue PSR enter and exit SDP to > the sink. > > Signed-off-by: Sankeerth Billakanti >

Re: [Freedreno] [PATCH v2 2/4] drm/bridge: use atomic enable/disable for bridge callbacks

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 06:51:24) > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index b32295a..5c7dc82 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -102,30 +136,82 @@ static void panel_bridge_detach(struct dr

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Dmitry Baryshkov
On 22/02/2022 22:25, Doug Anderson wrote: Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: +static int dp_link_psr_status(struct dp_link_private *link) +{ + u8 status[2]; + + drm_dp_dpcd_read(link->aux, DP_PSR_ERROR_STATUS, status, 2); + + if (status[0] & DP_PSR_

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > Panels with higher refresh rate will need mdp clk above 300Mhz. > > Select max frequency for mdp clock during bootup, dpu driver will > > scale down the clock as per usecase when first up

Re: [Freedreno] [PATCH v2 4/4] drm/msm/disp/dpu1: add PSR support for eDP interface in dpu driver

2022-02-22 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-21 06:51:26) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index e7c9fe1..ba3240c 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -951,6 +952,14 @@

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 1:23 PM Dmitry Baryshkov wrote: > > On 22/02/2022 22:25, Doug Anderson wrote: > > Hi, > > > > On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov > > wrote: > >> > >>> +static int dp_link_psr_status(struct dp_link_private *link) > >>> +{ > >>> + u8 status[2]; > >>>

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Stephen Boyd
Quoting Doug Anderson (2022-02-22 13:25:05) > Hi, > > On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > > Panels with higher refresh rate will need mdp clk above 300Mhz. > > > Select max frequency for mdp clock during bootup, dpu driver w

Re: [Freedreno] [PATCH v3 2/2] dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings

2022-02-22 Thread Rob Herring
On Mon, 14 Feb 2022 16:29:07 +0100, Loic Poulain wrote: > QCM2290 MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema for DPU device > tree bindings > > Signed-off-by: Loic Poulain > --- > v2: no change > v3: no change (resent with

Re: [Freedreno] [v1] arm64/dts/qcom/sc7280: update mdp clk to max supported value to support higher refresh rates

2022-02-22 Thread Doug Anderson
Hi, On Tue, Feb 22, 2022 at 1:46 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2022-02-22 13:25:05) > > Hi, > > > > On Tue, Feb 22, 2022 at 12:58 PM Stephen Boyd wrote: > > > > > > Quoting Vinod Polimera (2022-02-21 05:12:06) > > > > Panels with higher refresh rate will need mdp clk above 30

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Dmitry Baryshkov
On 23/02/2022 00:32, Doug Anderson wrote: Hi, On Tue, Feb 22, 2022 at 1:23 PM Dmitry Baryshkov wrote: On 22/02/2022 22:25, Doug Anderson wrote: Hi, On Mon, Feb 21, 2022 at 7:12 PM Dmitry Baryshkov wrote: +static int dp_link_psr_status(struct dp_link_private *link) +{ + u8 status[2

Re: [Freedreno] [PATCH v2 3/3] dt-bindings: msm/dsi: Add qcm2290 dsi controller binding

2022-02-22 Thread Rob Herring
On Mon, 14 Feb 2022 16:37:40 +0100, Loic Poulain wrote: > Add DSI block specific qcm2290 compatible string as valid > Qualcomm DSI controller. > > Signed-off-by: Loic Poulain > --- > v2: no change > > .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 5 > +++-- > 1 file c

[Freedreno] [PATCH v9 0/2] drm/msm/dpu: enable widebus feature base on chip hardware revision

2022-02-22 Thread Kuogee Hsieh
revise widebus timing engine programming and enable widebus feature base on chip Kuogee Hsieh (4): drm/msm/dpu: adjust display_v_end for eDP and DP drm/msm/dpu: replace BIT(x) with correspond marco define string drm/msm/dpu: revise timing engine programming to support widebus feature

[Freedreno] [PATCH v9 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-22 Thread Kuogee Hsieh
The “DP timing” requires the active region to be defined in the bottom-right corner of the frame dimensions which is different with DSI. Therefore both display_h_end and display_v_end need to be adjusted accordingly. However current implementation has only display_h_end adjusted. Signed-off-by: Ku

[Freedreno] [PATCH v9 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-22 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. Timing engine provides driving force for this purpose. This patch base on HPG (Hardware Programming Guide) to revise timing engine register setting to accommodate both widebus and non widebus application. Also horizontal wid

[Freedreno] [PATCH v9 2/4] drm/msm/dpu: replace BIT(x) with correspond marco define string

2022-02-22 Thread Kuogee Hsieh
To improve code readability, this patch replace BIT(x) with correspond register bit define string Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gp

[Freedreno] [PATCH v9 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-22 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy chipsets does not support this feature, this feature is enabled base on chip's hardware revisi

Re: [Freedreno] [PATCH v8 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-22 Thread Kuogee Hsieh
On 2/18/2022 6:53 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-02-17 13:36:27) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 0d315b4..0c22839 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm

[Freedreno] [PATCH v10 0/4] drm/msm/dpu: enable widebus feature base on chip hardware revision

2022-02-22 Thread Kuogee Hsieh
revise widebus timing engine programming and enable widebus feature base on chip Kuogee Hsieh (4): drm/msm/dpu: adjust display_v_end for eDP and DP drm/msm/dpu: replace BIT(x) with correspond marco define string drm/msm/dpu: revise timing engine programming to support widebus feature

[Freedreno] [PATCH v10 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-22 Thread Kuogee Hsieh
The “DP timing” requires the active region to be defined in the bottom-right corner of the frame dimensions which is different with DSI. Therefore both display_h_end and display_v_end need to be adjusted accordingly. However current implementation has only display_h_end adjusted. Signed-off-by: Ku

[Freedreno] [PATCH v10 2/4] drm/msm/dpu: replace BIT(x) with correspond marco define string

2022-02-22 Thread Kuogee Hsieh
To improve code readability, this patch replace BIT(x) with correspond register bit define string Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(

[Freedreno] [PATCH v10 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-22 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy chipsets does not support this feature, this feature is enabled base on chip's hardware revisi

[Freedreno] [PATCH v10 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-22 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. Timing engine provides driving force for this purpose. This patch base on HPG (Hardware Programming Guide) to revise timing engine register setting to accommodate both widebus and non widebus application. Also horizontal wid

Re: [Freedreno] [PATCH 1/3] drm/msm/adreno: Add A619 support

2022-02-22 Thread Rob Clark
On Mon, Feb 21, 2022 at 5:23 PM Konrad Dybcio wrote: > > Add support for the Adreno 619 GPU, as found in Snapdragon 690 (SM6350), > 480 (SM4350) and 750G (SM7225). > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 ++-- > drivers/gpu/drm/msm/adreno/a6xx_gpu

Re: [Freedreno] [PATCH v8 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-22 Thread Kuogee Hsieh
On 2/18/2022 6:48 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-02-17 13:36:25) The “DP timing” requires the active region to be defined in the bottom-right corner of the frame dimensions which is different with DSI. Therefore both display_h_end and display_v_end need to be adjusted accor

Re: [Freedreno] [PATCH 2/5] drm/msm/adreno: Generate name from chipid for 7c3

2022-02-22 Thread Rob Clark
On Mon, Feb 21, 2022 at 6:41 AM Akhil P Oommen wrote: > > Use a gpu name which is sprintf'ed from the chipid for 7c3 gpu instead of > hardcoding one. This helps to avoid code churn in case of a gpu rename. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/adreno_device.c |

Re: [Freedreno] [PATCH 0/5] Support 7c3 gpu SKUs

2022-02-22 Thread Rob Clark
On Mon, Feb 21, 2022 at 6:41 AM Akhil P Oommen wrote: > > This series supercedes [1]. Major change in this series is that it is now > optional to include a gpu name in the gpu-list. This helps to avoid the > confusion when we have different SKUs with different gpu names. And also > I am pretty hap

Re: [Freedreno] [PATCH] drm/msm/gpu: Fix crash on devices without devfreq support

2022-02-22 Thread Dmitry Baryshkov
On 19/02/2022 21:33, Rob Clark wrote: From: Rob Clark Avoid going down devfreq paths on devices where devfreq is not initialized. Reported-by: Linux Kernel Functional Testing Reported-by: Anders Roxell Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 31 +++

Re: [Freedreno] [v1] drm/msm/disp/dpu1: add inline rotation support for sc7280 target

2022-02-22 Thread Dmitry Baryshkov
On 18/02/2022 14:30, Vinod Polimera wrote: - Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and