Re: [Freedreno] [PATCH v12 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-25 13:23:12) > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher > resolution applications in future. However since some legacy chipsets > does not support this feature, thi

Re: [Freedreno] [PATCH 3/3] drm/msm: Expose client engine utilization via fdinfo

2022-02-25 Thread Rob Clark
On Fri, Feb 25, 2022 at 12:25 PM Rob Clark wrote: > > From: Rob Clark > > Similar to AMD commit > 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the > infrastructure added in previous patches, we add basic client info > and GPU engine utilisation for msm. > > Example output: > >

Re: [Freedreno] [PATCH 1/3] drm: Extend DEFINE_DRM_GEM_FOPS() for optional fops

2022-02-25 Thread Sam Ravnborg
Hi Rob, > > > diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h > > > index 35e7f44c2a75..987e78b18244 100644 > > > --- a/include/drm/drm_gem.h > > > +++ b/include/drm/drm_gem.h > > > @@ -327,7 +327,7 @@ struct drm_gem_object { > > > * non-static version of this you're probably doing it

Re: [Freedreno] [PATCH 1/3] drm: Extend DEFINE_DRM_GEM_FOPS() for optional fops

2022-02-25 Thread Rob Clark
On Fri, Feb 25, 2022 at 12:36 PM Ville Syrjälä wrote: > > On Fri, Feb 25, 2022 at 12:26:12PM -0800, Rob Clark wrote: > > From: Rob Clark > > > > Extend the helper macro so we don't have to throw it away if driver adds > > support for optional fops, like show_fdinfo(). > > > > Signed-off-by: Rob C

[Freedreno] [PATCH v12 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy chipsets does not support this feature, this feature is enabled by setting wide_bus_en flag to

[Freedreno] [PATCH v12 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-25 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. Timing engine provides driving force for this purpose. This patch base on HPG (Hardware Programming Guide) to revise timing engine register setting to accommodate both widebus and non widebus application. Also horizontal wid

[Freedreno] [PATCH v12 2/4] drm/msm/dpu: replace BIT(x) with correspond marco define string

2022-02-25 Thread Kuogee Hsieh
To improve code readability, this patch replace BIT(x) with correspond register bit define string Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(

[Freedreno] [PATCH v12 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-25 Thread Kuogee Hsieh
The “DP timing” requires the active region to be defined in the bottom-right corner of the frame dimensions which is different with DSI. Therefore both display_h_end and display_v_end need to be adjusted accordingly. However current implementation has only display_h_end adjusted. Signed-off-by: Ku

[Freedreno] [PATCH v12 0/4] drm/msm/dpu: enable widebus feature base on chip hardware revision

2022-02-25 Thread Kuogee Hsieh
revise widebus timing engine programming and enable widebus feature base on chip Kuogee Hsieh (4): drm/msm/dpu: adjust display_v_end for eDP and DP drm/msm/dpu: replace BIT(x) with correspond marco define string drm/msm/dpu: revise timing engine programming to support widebus feature

Re: [Freedreno] [PATCH v11 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-25 12:45:57) > Widebus feature will transmit two pixel data per pixel clock to interface. > This feature now is required to be enabled to easy migrant to higher > resolution applications in future. However since some legacy chipsets > does not support this feature, thi

[Freedreno] [PATCH v11 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy chipsets does not support this feature, this feature is enabled by setting wide_bus_en flag to

[Freedreno] [PATCH v11 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-25 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. Timing engine provides driving force for this purpose. This patch base on HPG (Hardware Programming Guide) to revise timing engine register setting to accommodate both widebus and non widebus application. Also horizontal wid

[Freedreno] [PATCH v11 2/4] drm/msm/dpu: replace BIT(x) with correspond marco define string

2022-02-25 Thread Kuogee Hsieh
To improve code readability, this patch replace BIT(x) with correspond register bit define string Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(

[Freedreno] [PATCH v11 1/4] drm/msm/dpu: adjust display_v_end for eDP and DP

2022-02-25 Thread Kuogee Hsieh
The “DP timing” requires the active region to be defined in the bottom-right corner of the frame dimensions which is different with DSI. Therefore both display_h_end and display_v_end need to be adjusted accordingly. However current implementation has only display_h_end adjusted. Signed-off-by: Ku

[Freedreno] [PATCH v11 0/4] drm/msm/dpu: enable widebus feature base on chip hardware revision

2022-02-25 Thread Kuogee Hsieh
revise widebus timing engine programming and enable widebus feature base on chip Kuogee Hsieh (4): drm/msm/dpu: adjust display_v_end for eDP and DP drm/msm/dpu: replace BIT(x) with correspond marco define string drm/msm/dpu: revise timing engine programming to support widebus feature

Re: [Freedreno] [PATCH 1/3] drm: Extend DEFINE_DRM_GEM_FOPS() for optional fops

2022-02-25 Thread Ville Syrjälä
On Fri, Feb 25, 2022 at 12:26:12PM -0800, Rob Clark wrote: > From: Rob Clark > > Extend the helper macro so we don't have to throw it away if driver adds > support for optional fops, like show_fdinfo(). > > Signed-off-by: Rob Clark > --- > include/drm/drm_gem.h | 3 ++- > 1 file changed, 2 ins

[Freedreno] [PATCH 3/3] drm/msm: Expose client engine utilization via fdinfo

2022-02-25 Thread Rob Clark
From: Rob Clark Similar to AMD commit 874442541133 ("drm/amdgpu: Add show_fdinfo() interface"), using the infrastructure added in previous patches, we add basic client info and GPU engine utilisation for msm. Example output: # cat /proc/`pgrep glmark2`/fdinfo/6 pos:0

[Freedreno] [PATCH 2/3] drm/msm: Remove unused field in submit

2022-02-25 Thread Rob Clark
From: Rob Clark Noticed this was unused and never set. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h | 1 - drivers/gpu/drm/msm/msm_gpu.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h index af612ad

[Freedreno] [PATCH 1/3] drm: Extend DEFINE_DRM_GEM_FOPS() for optional fops

2022-02-25 Thread Rob Clark
From: Rob Clark Extend the helper macro so we don't have to throw it away if driver adds support for optional fops, like show_fdinfo(). Signed-off-by: Rob Clark --- include/drm/drm_gem.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_gem.h b/include/drm/d

[Freedreno] [PATCH v2 5/5] arm64: dts: qcom: sc7280: Support gpu speedbin

2022-02-25 Thread Akhil P Oommen
Add speedbin fuse and additional OPPs for gpu to support sc7280 SKUs. Signed-off-by: Akhil P Oommen --- (no changes since v1) arch/arm64/boot/dts/qcom/sc7280.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/a

[Freedreno] [PATCH v2 4/5] drm/msm/adreno: Expose speedbin to userspace

2022-02-25 Thread Akhil P Oommen
Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace identify the sku. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 3 +-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 21 + drivers/gpu/drm/msm/adreno/adren

[Freedreno] [PATCH v2 3/5] drm/msm/a6xx: Add support for 7c3 SKUs

2022-02-25 Thread Akhil P Oommen
Add support for 7c3 SKU detection using speedbin fuse. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu

[Freedreno] [PATCH v2 2/5] drm/msm/adreno: Generate name from chipid for 7c3

2022-02-25 Thread Akhil P Oommen
Use a gpu name which is sprintf'ed from the chipid for 7c3 gpu instead of hardcoding one. This helps to avoid code churn in case of a gpu rename. Signed-off-by: Akhil P Oommen --- Changes in v2: - use devm_kasprintf() to generate gpu name (Rob) drivers/gpu/drm/msm/adreno/adreno_device.c | 1 -

[Freedreno] [PATCH v2 1/5] drm/msm: Use generic name for gpu resources

2022-02-25 Thread Akhil P Oommen
Use generic name for resources like irq and kthread instead of hardware specific name to make it easier to grep. Signed-off-by: Akhil P Oommen --- (no changes since v1) drivers/gpu/drm/msm/msm_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/msm

[Freedreno] [PATCH v2 0/5] Support 7c3 gpu SKUs

2022-02-25 Thread Akhil P Oommen
This series supercedes [1]. Major change in this series is that it is now optional to include a gpu name in the gpu-list. This helps to avoid the confusion when we have different SKUs with different gpu names. And also I am pretty happy that the overall changes are smaller now. [1] https://patchwo

Re: [Freedreno] [PATCH v10 4/4] drm/msm/dp: enable widebus feature for display port

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-22 16:27:40) > diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c > b/drivers/gpu/drm/msm/dp/dp_catalog.c > index 6ae9b29..c789f4e 100644 > --- a/drivers/gpu/drm/msm/dp/dp_catalog.c > +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c > @@ -483,6 +485,22 @@ int dp_catalog_ctrl_s

Re: [Freedreno] [PATCH v10 3/4] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-25 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-22 16:27:39) > Widebus feature will transmit two pixel data per pixel clock to interface. > Timing engine provides driving force for this purpose. This patch base > on HPG (Hardware Programming Guide) to revise timing engine register > setting to accommodate both wideb

Re: [Freedreno] [PATCH v2 2/2] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table

2022-02-25 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-25 07:57:50) > use max clock during resume sequence from the opp table. s/use/Use/ > The clock will be scaled down when framework sends an update. > > Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes") Presumably this is the wrong fixes tag, see be

Re: [Freedreno] [PATCH v2 1/2] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-02-25 Thread Stephen Boyd
Quoting Vinod Polimera (2022-02-25 07:57:49) > Kernel clock driver assumes that initial rate is the > max rate for that clock and was not allowing it to scale > beyond the assigned clock value. > > drop the assigned clock rate property and set it > during resume sequence with max value in the opp t

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-25 Thread Dmitry Baryshkov
On Fri, 25 Feb 2022 at 20:11, Abhinav Kumar wrote: > > > > On 2/25/2022 1:04 AM, Dmitry Baryshkov wrote: > > On Fri, 25 Feb 2022 at 07:45, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/24/2022 8:22 PM, Dmitry Baryshkov wrote: > >>> On Fri, 25 Feb 2022 at 05:01, Abhinav Kumar > >>> wrote: >

Re: [Freedreno] (subset) [PATCH v2 12/22] drm/msm/mdp5: Remove redundant zpos initialisation

2022-02-25 Thread Maxime Ripard
On Mon, 21 Feb 2022 10:59:08 +0100, Maxime Ripard wrote: > The mdp KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane purpose. > > Since the initial value wasn't carried over in the state, the driver had > to set it again in mdp5_plane_reset(). Howeve

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-25 Thread Abhinav Kumar
On 2/25/2022 1:04 AM, Dmitry Baryshkov wrote: On Fri, 25 Feb 2022 at 07:45, Abhinav Kumar wrote: On 2/24/2022 8:22 PM, Dmitry Baryshkov wrote: On Fri, 25 Feb 2022 at 05:01, Abhinav Kumar wrote: On 2/24/2022 12:41 PM, Dmitry Baryshkov wrote: On Thu, 24 Feb 2022 at 21:25, Abhinav Kum

[Freedreno] [PATCH v2 1/2] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-02-25 Thread Vinod Polimera
Kernel clock driver assumes that initial rate is the max rate for that clock and was not allowing it to scale beyond the assigned clock value. drop the assigned clock rate property and set it during resume sequence with max value in the opp table. Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add d

[Freedreno] [PATCH v2 2/2] drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table

2022-02-25 Thread Vinod Polimera
use max clock during resume sequence from the opp table. The clock will be scaled down when framework sends an update. Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes") Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++ 1 file changed, 3 insertio

[Freedreno] [PATCH v2 0/2] Update mdp clk to max supported value to support higher refresh rates

2022-02-25 Thread Vinod Polimera
*** BLURB HERE *** Vinod Polimera (2): arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk drm/msm/disp/dpu1: set mdp clk to the maximum frequency in opp table arch/arm64/boot/dts/qcom/sc7280.dtsi| 9 ++--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +++ 2 files c

Re: [Freedreno] [PATCH] drm/msm/dpu: wire up MSM8998's DSPP blocks

2022-02-25 Thread Marijn Suijten
On 2022-02-22 06:19:48, Dmitry Baryshkov wrote: > The commit adding msm8998 support didn't added msm8998's DSPP blocks You might have meant: [did*] add(ed) msm8998's DSPP blocks configuration [to the source /code file], but did not... Or however you wish to word this :) - Marijn > configuration

Re: [Freedreno] [RFC PATCH v2 1/5] drm/msm/dp: fix panel bridge attachment

2022-02-25 Thread Dmitry Baryshkov
On Fri, 25 Feb 2022 at 07:45, Abhinav Kumar wrote: > > > > On 2/24/2022 8:22 PM, Dmitry Baryshkov wrote: > > On Fri, 25 Feb 2022 at 05:01, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/24/2022 12:41 PM, Dmitry Baryshkov wrote: > >>> On Thu, 24 Feb 2022 at 21:25, Abhinav Kumar > >>> wrote: