[Freedreno] [PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Chia-I Wu
In practice, trace_dma_fence_init called from dma_fence_init is good enough and almost no driver calls trace_dma_fence_emit. But drm_sched and virtio both have cases where trace_dma_fence_init and trace_dma_fence_emit can be apart. It is easier for visualization tools to always use the more corre

Re: [Freedreno] [PATCH] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Rob Clark
On Sat, Apr 9, 2022 at 7:33 AM Christian König wrote: > > Am 08.04.22 um 23:12 schrieb Chia-I Wu: > > In practice, trace_dma_fence_init is good enough and almost no driver > > calls trace_dma_fence_emit. But this is still more correct in theory. > > Well, the reason why basically no driver is cal

Re: [Freedreno] [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > From: Sean Paul > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > moved hdcp registers into the trogdor dtsi file to avoid differences > with sc7180-based windows devices. The set is 4 patches lighter since

Re: [Freedreno] [PATCH v5 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:34PM +, Sean Paul wrote: > From: Sean Paul > > Stick all of the setup for HDCP into a dedicated function. No functional > change, but this will facilitate moving HDCP logic into helpers. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Nikula > Signed-off-by:

Re: [Freedreno] [PATCH v5 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:35PM +, Sean Paul wrote: > From: Sean Paul > > The shim functions return error codes, but they are discarded in > intel_hdcp.c. This patch plumbs the return codes through so they are > properly handled. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Nikula > S

Re: [Freedreno] [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > From: Sean Paul > > This patch updates the connector's property value in 2 cases which were > previously missed: > > 1- Content type changes. The value should revert back to DESIRED from >ENABLED in case the driver must re-authenti

Re: [Freedreno] [PATCH v5 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:31PM +, Sean Paul wrote: > From: Sean Paul > > Instead of forcing a modeset in the hdcp atomic check, simply return > true if the content protection value is changing and let the driver > decide whether a modeset is required or not. > > Acked-by: Jani Nikula >

Re: [Freedreno] [PATCH v5 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:30PM +, Sean Paul wrote: > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the > code when moving it over. Reviewed-by: Rodrigo Vivi > > Acked-by: