Re: [Freedreno] [PATCH AUTOSEL 5.4 11/14] drm/msm: Stop using iommu_present()

2022-04-23 Thread Sasha Levin
On Tue, Apr 19, 2022 at 11:53:23AM -0700, Rob Clark wrote: You might want to drop this one, it seems to be causing some issues on older generations.. I'll be sending another PR shortly with a revert. https://patchwork.freedesktop.org/patch/482453 Dropped, thanks! -- Thanks, Sasha

Re: [Freedreno] [PATCH] drm/msm/dp: move add fail safe mode to dp_connector_get_mode()

2022-04-23 Thread Abhinav Kumar
On 4/22/2022 11:25 PM, Dmitry Baryshkov wrote: On Sat, 23 Apr 2022 at 03:12, Abhinav Kumar wrote: On 4/22/2022 5:07 PM, Dmitry Baryshkov wrote: On 23/04/2022 02:45, Kuogee Hsieh wrote: Current DP driver implementation has adding safe mode done at dp_hpd_plug_handle() which is expected t

[Freedreno] [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-04-23 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- v2: don't print irq, and return ERR_PTR(-EINVAL) --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++--- 1 file changed, 3 inserti

[Freedreno] [PATCH v2] drm/msm/dp: fix error check return value of irq_of_parse_and_map()

2022-04-23 Thread cgel . zte
From: Lv Ruyi The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") Reported-by: Zeal Robot Signed-off-by: Lv Ruyi --- v2: don't print rc, and return -EINVAL rather th