On 18-05-22, 14:36, Kuogee Hsieh wrote:
> This patch add regulator_set_load() before enable regulator at
> DP phy driver.
sigh! still wrong tags!
>
> Signed-off-by: Kuogee Hsieh
> Reviewed-by: Stephen Boyd
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 12
> 1 file changed, 12 ins
On 5/18/2022 5:40 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2022-05-18 15:34:07)
If there are errors while trying to enable the pm in the
bind path, it will lead to unclocked access of hw revision
register thereby crashing the device.
This will not address why the pm_runtime_get_sync()
Quoting Abhinav Kumar (2022-05-18 15:34:07)
> If there are errors while trying to enable the pm in the
> bind path, it will lead to unclocked access of hw revision
> register thereby crashing the device.
>
> This will not address why the pm_runtime_get_sync() fails
> but at the very least we should
On Wed, May 18, 2022 at 3:34 PM Abhinav Kumar wrote:
>
> If there are errors while trying to enable the pm in the
> bind path, it will lead to unclocked access of hw revision
> register thereby crashing the device.
>
> This will not address why the pm_runtime_get_sync() fails
> but at the very lea
If there are errors while trying to enable the pm in the
bind path, it will lead to unclocked access of hw revision
register thereby crashing the device.
This will not address why the pm_runtime_get_sync() fails
but at the very least we should be able to prevent the
crash by handling the error and
On Thu, 19 May 2022 at 00:36, Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() before enable regulator at
> eDP phy driver.
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/phy/qualcomm/phy-qcom-edp.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/dr
On Thu, 19 May 2022 at 00:36, Kuogee Hsieh wrote:
>
> Vdda regulators are related to both eDP and DP phy so that it should be
> managed at eDP and DP phy driver instead of controller. This patch removes
> vdda regulators related functions out of eDP/DP controller.
>
> Signed-off-by: Kuogee Hsieh
On Thu, 19 May 2022 at 00:36, Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() before enable regulator at
> DP phy driver.
>
> Signed-off-by: Kuogee Hsieh
> Reviewed-by: Stephen Boyd
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 12
> 1 file changed, 12 insertions(+)
>
>
This patch add regulator_set_load() before enable regulator at
DP phy driver.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c
b/drivers/phy/qualco
Vdda regulators are related to both eDP and DP phy so that it should be
managed at eDP and DP phy driver instead of controller. This patch removes
vdda regulators related functions out of eDP/DP controller.
Signed-off-by: Kuogee Hsieh
Reviewed-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_pars
This patch add regulator_set_load() before enable regulator at
eDP phy driver.
Signed-off-by: Kuogee Hsieh
---
drivers/phy/qualcomm/phy-qcom-edp.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c
b/drivers/phy/qualcomm/phy-qcom-ed
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy/qualcomm: add regulator_set_load to edp phy
phy/qualcomm: add regulator_set_load to dp phy
drm/msm/dp: delete vdda regulator related fun
Quoting Kuogee Hsieh (2022-05-18 13:24:04)
> Vdda regulators are related to both eDP and DP phy so that it should be
> managed at eDP and DP phy driver instead of controller. This patch removes
> vdda regulators related functions out of eDP/DP controller.
>
> Signed-off-by: Kuogee Hsieh
> ---
Rev
Quoting Kuogee Hsieh (2022-05-18 13:24:03)
> This patch add regulator_set_load() before enable regulator at
> DP phy driver.
>
> Changes in v2:
> -- no regulator_set_load() before disable regulator
>
> Changes in v3:
> -- split into two patches
Same changelog comment
>
> Signed-off-by: Kuogee Hs
Should subject be "phy: qcom:" prefix?
Quoting Kuogee Hsieh (2022-05-18 13:24:02)
> This patch add regulator_set_load() before enable regulator at
> eDP phy driver.
>
> Changes in v3:
> -- no regulator_set_load before disable regulator
> -- no supply name string change at probe
> -- split into two
This patch add regulator_set_load() before enable regulator at
DP phy driver.
Changes in v2:
-- no regulator_set_load() before disable regulator
Changes in v3:
-- split into two patches
Signed-off-by: Kuogee Hsieh
---
drivers/phy/qualcomm/phy-qcom-qmp.c | 12
1 file changed, 12 i
Vdda regulators are related to both eDP and DP phy so that it should be
managed at eDP and DP phy driver instead of controller. This patch removes
vdda regulators related functions out of eDP/DP controller.
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_parser.c | 14 --
drivers/g
This patch add regulator_set_load() before enable regulator at
eDP phy driver.
Changes in v3:
-- no regulator_set_load before disable regulator
-- no supply name string change at probe
-- split into two patches
Signed-off-by: Kuogee Hsieh
---
drivers/phy/qualcomm/phy-qcom-edp.c | 10 +-
1) add regulator_set_load() to eDP phy
2) add regulator_set_load() to DP phy
3) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (3):
phy/qualcomm: add regulator_set_load to edp phy
phy/qualcomm: add regulator_set_load to dp phy
drm/msm/dp: delete vdda regulator related fun
On 5/18/2022 10:31 AM, Dmitry Baryshkov wrote:
On 18/05/2022 20:29, Kuogee Hsieh wrote:
On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh
wrote:
1) add regulator_set_load() to eDP/DP phy
2) remove vdda related function out of eDP/DP controller
These
Quoting Abhinav Kumar (2022-05-18 12:55:40)
> If there are errors while trying to enable the pm in the
> bind path, it will lead to unclocked access of hw revision
> register thereby crashing the device.
>
> This will not address why the pm_runtime_get_sync() fails
> but at the very least we should
If there are errors while trying to enable the pm in the
bind path, it will lead to unclocked access of hw revision
register thereby crashing the device.
This will not address why the pm_runtime_get_sync() fails
but at the very least we should be able to prevent the
crash by handling the error and
On 14/05/2022 01:59, Abhinav Kumar wrote:
Writeback modes were being added according to mode_config.max_width
but this is assigned to double of max_mixer_width.
For compositors/clients using a single SSPP, this will fail
the dpu_plane's atomic check as it checks for max_linewidth.
Limit writeba
On 5/18/2022 10:52 AM, Dmitry Baryshkov wrote:
On 18/05/2022 20:36, Kuogee Hsieh wrote:
On 5/18/2022 10:12 AM, Dmitry Baryshkov wrote:
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh
wrote:
This patch add regulator_set_load() to both eDP and DP phy driver
to have totally control regulators.
Ch
On 18/05/2022 20:36, Kuogee Hsieh wrote:
On 5/18/2022 10:12 AM, Dmitry Baryshkov wrote:
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh
wrote:
This patch add regulator_set_load() to both eDP and DP phy driver
to have totally control regulators.
Changes in v2:
-- no regulator_set_laod() before dis
On 5/18/2022 10:12 AM, Dmitry Baryshkov wrote:
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh wrote:
This patch add regulator_set_load() to both eDP and DP phy driver
to have totally control regulators.
Changes in v2:
-- no regulator_set_laod() before disable regulator
Signed-off-by: Kuogee Hsi
On 18/05/2022 20:29, Kuogee Hsieh wrote:
On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh
wrote:
1) add regulator_set_load() to eDP/DP phy
2) remove vdda related function out of eDP/DP controller
These patches touch two subsystems and have a dependenc
On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh wrote:
1) add regulator_set_load() to eDP/DP phy
2) remove vdda related function out of eDP/DP controller
These patches touch two subsystems and have a dependency between them.
How do we merge them?
c
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh wrote:
>
> 1) add regulator_set_load() to eDP/DP phy
> 2) remove vdda related function out of eDP/DP controller
These patches touch two subsystems and have a dependency between them.
How do we merge them?
>
> Kuogee Hsieh (2):
> phy/qcom: add regulato
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh wrote:
>
> Vdda regulators are related to both eDP and DP phy so that it should be
> managed at eDP and DP phy driver instead of controller. This patch remove
removes
> vdda regulators related functions out of eDP/DP controller.
> Signed-off-by: Kuogee
On Wed, 18 May 2022 at 19:43, Kuogee Hsieh wrote:
>
> This patch add regulator_set_load() to both eDP and DP phy driver
> to have totally control regulators.
>
> Changes in v2:
> -- no regulator_set_laod() before disable regulator
>
> Signed-off-by: Kuogee Hsieh
> ---
> drivers/phy/qualcomm/phy-
Vdda regulators are related to both eDP and DP phy so that it should be
managed at eDP and DP phy driver instead of controller. This patch remove
vdda regulators related functions out of eDP/DP controller.
Signed-off-by: Kuogee Hsieh
---
drivers/gpu/drm/msm/dp/dp_parser.c | 14 --
drivers/gp
This patch add regulator_set_load() to both eDP and DP phy driver
to have totally control regulators.
Changes in v2:
-- no regulator_set_laod() before disable regulator
Signed-off-by: Kuogee Hsieh
---
drivers/phy/qualcomm/phy-qcom-edp.c | 25 +
drivers/phy/qualcomm/phy-q
1) add regulator_set_load() to eDP/DP phy
2) remove vdda related function out of eDP/DP controller
Kuogee Hsieh (2):
phy/qcom: add regulator_set_load to edp/dp phy
drm/msm/dp: delete vdda regulator related functions from eDP/DP
controller
drivers/gpu/drm/msm/dp/dp_parser.c | 14 --
On 5/18/2022 2:29 AM, Vinod Koul wrote:
On 17-05-22, 10:25, Kuogee Hsieh wrote:
pls use the correct subsystem tag, "phy: xxx" in this case
This patch add regulator_set_load() to both eDP and DP phy driver
to have totally control regulators.
Can you explain what is meant by "totally control
On 17-05-22, 10:25, Kuogee Hsieh wrote:
pls use the correct subsystem tag, "phy: xxx" in this case
> This patch add regulator_set_load() to both eDP and DP phy driver
> to have totally control regulators.
Can you explain what is meant by "totally control regulators"
>
> Signed-off-by: Kuogee H
36 matches
Mail list logo