Re: [Freedreno] [PATCH v2] drm/msm/dp: force link training for display resolution change

2022-05-26 Thread kernel test robot
Hi Kuogee, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on next-20220526] [cannot apply to v5.18] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-26 Thread Rob Clark
On Thu, May 26, 2022 at 6:29 AM Tvrtko Ursulin wrote: > > > On 26/05/2022 04:15, Rob Clark wrote: > > On Wed, May 25, 2022 at 9:11 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 24/05/2022 15:57, Rob Clark wrote: > >>> On Tue, May 24, 2022 at 6:45 AM Tvrtko Ursulin > >>> wrote: > > On

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-26 Thread Rob Clark
On Thu, May 26, 2022 at 4:38 AM Tvrtko Ursulin wrote: > > > On 26/05/2022 04:37, Rob Clark wrote: > > On Wed, May 25, 2022 at 9:22 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 25/05/2022 14:41, Rob Clark wrote: > >>> On Wed, May 25, 2022 at 2:46 AM Tvrtko Ursulin > >>> wrote: > > > >

Re: [Freedreno] [PATCH 18/25] drm/msm/dpu: move the rest of plane checks to dpu_plane_atomic_check()

2022-05-26 Thread Abhinav Kumar
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote: Remove plane checks/state updates from dpu_crtc_atomic_check(). The belong to dpu_plane_atomic_check(). The --> They Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 44 --- drivers/gpu/drm/m

Re: [Freedreno] [PATCH v13 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-26 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-25 14:02:18) > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH] drm/msm/dp: force link training for display resolution change

2022-05-26 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-05-26 10:26:18) > During display resolution changes display have to be disabled first > followed by display enable with new resolution. This patch force > main link always be retrained during display enable procedure to > simplify implementation instead of manually kickin

[Freedreno] [PATCH v2] drm/msm/dp: force link training for display resolution change

2022-05-26 Thread Kuogee Hsieh
During display resolution changes display have to be disabled first followed by display enable with new resolution. This patch force main link always be retrained during display enable procedure to simplify implementation instead of manually kicking of irq_hpd handle. Changes in v2: -- set force_l

Re: [Freedreno] [PATCH 17/25] drm/msm/dpu: drop src_split and multirect check from dpu_crtc_atomic_check

2022-05-26 Thread Abhinav Kumar
On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote: Neither source split nor multirect are properly supported at this moment. Both of these checks depend on normalized_zpos being equal for several planes (which is never the case for normalized zpos). Drop these checks to simplify dpu_crtc_atomic_chec

Re: [Freedreno] [PATCH 05/25] drm/msm/dpu: move pipe_hw to dpu_plane_state

2022-05-26 Thread Abhinav Kumar
On 5/13/2022 11:37 PM, Dmitry Baryshkov wrote: On 04/05/2022 01:32, Abhinav Kumar wrote: On 2/9/2022 9:25 AM, Dmitry Baryshkov wrote: In preparation to adding fully virtualized planes, move struct dpu_hw_pipe instance from struct dpu_plane to struct dpu_plane_state, as it will become a par

[Freedreno] [PATCH] drm/msm/dp: force link training for display resolution change

2022-05-26 Thread Kuogee Hsieh
During display resolution changes display have to be disabled first followed by display enable with new resolution. This patch force main link always be retrained during display enable procedure to simplify implementation instead of manually kicking of irq_hpd handle. Signed-off-by: Kuogee Hsieh

Re: [Freedreno] [PATCH v3] drm/probe-helper: Make 640x480 first if no EDID

2022-05-26 Thread Doug Anderson
Hi, On Thu, May 26, 2022 at 8:42 AM Daniel Vetter wrote: > > On Thu, 26 May 2022 at 03:28, Sean Paul wrote: > > > > On Wed, May 25, 2022 at 9:26 AM Daniel Vetter wrote: > > > > > > On Mon, May 23, 2022 at 05:59:02PM -0700, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Fri, May 20, 2022 at

Re: [Freedreno] [PATCH v3] drm/probe-helper: Make 640x480 first if no EDID

2022-05-26 Thread Daniel Vetter
On Thu, 26 May 2022 at 03:28, Sean Paul wrote: > > On Wed, May 25, 2022 at 9:26 AM Daniel Vetter wrote: > > > > On Mon, May 23, 2022 at 05:59:02PM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Fri, May 20, 2022 at 5:01 PM Doug Anderson > > > wrote: > > > > > > > > Hi, > > > > > > > > On

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-26 Thread Tvrtko Ursulin
On 26/05/2022 04:15, Rob Clark wrote: On Wed, May 25, 2022 at 9:11 AM Tvrtko Ursulin wrote: On 24/05/2022 15:57, Rob Clark wrote: On Tue, May 24, 2022 at 6:45 AM Tvrtko Ursulin wrote: On 23/05/2022 23:53, Rob Clark wrote: btw, one fun (but unrelated) issue I'm hitting with scheduler..

Re: [Freedreno] [GIT PULL] drm/msm: drm-msm-fixes-2022-05-19

2022-05-26 Thread Dmitry Baryshkov
On 19/05/2022 19:21, Abhinav Kumar wrote: Hi Rob Here is the pull request for the fixes for 5.19. Just a few more changes on top of msm-fixes-staging. Mainly it has the foll fixes: - Limiting WB modes to max sspp linewidth - Fixing the supported rotations to add 180 back for IGT - Fix to hand

[Freedreno] [PATCH 14/31] drm/msm: Migrate to dev_pm_opp_set_config()

2022-05-26 Thread Viresh Kumar
The OPP core now provides a unified API for setting all configuration types, i.e. dev_pm_opp_set_config(). Lets start using it. Signed-off-by: Viresh Kumar --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 8 ++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 10 +- drivers/gpu/drm/msm/dis

[Freedreno] [PATCH 00/31] OPP: Add new configuration interface: dev_pm_opp_set_config()

2022-05-26 Thread Viresh Kumar
Hello, We have too many configuration specific APIs currently, six of them already, like dev_pm_opp_set_regulators(). This makes it complex/messy for both the OPP core and its users to manage. There is also code redundancy in these API, in the way they add/manage the OPP table specific stuff. Thi

Re: [Freedreno] [PATCH v4 12/13] drm/msm: Utilize gpu scheduler priorities

2022-05-26 Thread Tvrtko Ursulin
On 26/05/2022 04:37, Rob Clark wrote: On Wed, May 25, 2022 at 9:22 AM Tvrtko Ursulin wrote: On 25/05/2022 14:41, Rob Clark wrote: On Wed, May 25, 2022 at 2:46 AM Tvrtko Ursulin wrote: On 24/05/2022 15:50, Rob Clark wrote: On Tue, May 24, 2022 at 6:45 AM Tvrtko Ursulin wrote: On 23